Skip to content

PR #831 broke stale host cleanup for hosts that are part of groups #844

@mignaulo

Description

@mignaulo

We recently upgraded our Teletraan setup to the latest commit from master and ran into issues where hosts stopped getting cleaned up when they where terminated. We were able to revert to the commit just before #831 was merged to restore this functionality. I'm no expert here, here is what I found out by digging into the PR.

The previous version of the cleanup code was split into two parts:

Would it be possible to reintroduce the "cleanup stale hosts that are part of groups" functionality?
(Roughly these lines https://github.com/pinterest/teletraan/pull/831/files#diff-d325e9aa7284f0411829cb75934a0ddae12c7281fda3b09da7779c406e8bad3cL124-L173)

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions