Skip to content

Missing migrations from the schema upgrade script. #700

@mignaulo

Description

@mignaulo

Hello,
We have a fairly old Teletraan setup that we are planning to update to the latest version. This requires us to upgrade the MySQL schema. We have been doing testing the MySQL upgrade script and comparing them to https://github.com/pinterest/teletraan/blob/master/deploy-service/common/src/main/resources/sql/deploy.sql and noticed some discrepancies.

After some sleuthing, I tracked the changes down to this PR: #491
That PR updated the complete schema without creating a new schema_version. These are the changes missing: https://github.com/pinterest/teletraan/pull/491/files#diff-380d85d61edaf8019bd4a4cd16a48c36
I believe this migration would in theory live somewhere between schema_version 1 and 2.

We can definitely patch our setup without trouble, but I figured I would raise this issue regardless. I could create a PR to update the MySQL upgrade script to handle this and help others that might run into this. I could add the missing migrations to the end of tools/mysql/schema-update-1.sql or the beginning of tools/mysql/schema-update-2.sql. Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions