Merge pull request #471 from jfzunigac/remove_noisy_metric

High tag cardinality metrics changes

Author: jfzunigac

pom.xml

@@ -6,7 +6,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>com.pinterest.singer</groupId>
     <artifactId>singer-package</artifactId>
-    <version>0.8.0.94</version>
+    <version>0.8.0.95</version>
     <packaging>pom</packaging>
     <description>Singer Logging Agent modules</description>
     <inceptionYear>2013</inceptionYear>

singer-commons/pom.xml

@@ -19,7 +19,7 @@
   <parent>
     <groupId>com.pinterest.singer</groupId>
     <artifactId>singer-package</artifactId>
-    <version>0.8.0.94</version>
+    <version>0.8.0.95</version>
     <relativePath>../pom.xml</relativePath>
   </parent>
   <developers>

singer/pom.xml

@@ -10,7 +10,7 @@
     <parent>
         <groupId>com.pinterest.singer</groupId>
         <artifactId>singer-package</artifactId>
-        <version>0.8.0.94</version>
+        <version>0.8.0.95</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
     <licenses>

singer/src/main/java/com/pinterest/singer/monitor/LogStreamManager.java

@@ -722,7 +722,6 @@ public void initializeLogStreamForPod(String podUid, Collection<SingerLogConfig>
           Map<String, String> podMetadata = PodMetadataWatcher.getInstance().getPodMetadata(podUid);
           if (podMetadata != null) {
             LOG.info("Initializing pod metadata {} for pod: {}", podMetadata, podUid);
-            OpenTsdbMetricConverter.incr("pod_metadata_enabled", 1, "pod=" + podUid, "log=" + clone.getName());
             for (Map.Entry<String, String> entry : podMetadata.entrySet()) {
               singerLog.addMetadata(entry.getKey(), SingerUtils.getByteBuf(entry.getValue()));
             }

singer/src/main/java/com/pinterest/singer/reader/ThriftLogFileReader.java

@@ -153,7 +153,7 @@ public LogMessageAndPosition readLogMessageAndPosition() throws LogFileReaderExc
         if (messageSize > maxMessageSize) {
           LOG.warn("Found a message at offset " + newByteOffset + "that exceeds the size limit in "
               + logFile.toString() + ": messageSize =  " + messageSize);
-          OpenTsdbMetricConverter.incr("singer.thrift_reader.skip_message", 1, "path=" + path, "log=" + logStream.getSingerLog().getLogName());
+          OpenTsdbMetricConverter.incr("singer.thrift_reader.skip_message", 1, "log=" + logStream.getSingerLog().getLogName());
           logMessage = thriftReader.read();
         } else {
           LogPosition position = new LogPosition(logFile, newByteOffset);

thrift-logger/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.pinterest.singer</groupId>
     <artifactId>singer-package</artifactId>
-    <version>0.8.0.94</version>
+    <version>0.8.0.95</version>
     <relativePath>../pom.xml</relativePath>
   </parent>
   <artifactId>thrift-logger</artifactId>