Skip to content

Commit de3687b

Browse files
authored
feat: support markdown for the query review modal (#1568)
* feat: use markdown for the query review modal text * add some bolds * update version
1 parent 7fcebdf commit de3687b

File tree

4 files changed

+20
-62
lines changed

4 files changed

+20
-62
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "querybook",
3-
"version": "3.41.3",
3+
"version": "3.41.4",
44
"description": "A Big Data Webapp",
55
"private": true,
66
"scripts": {

querybook/config/querybook_public_config.yaml

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -50,23 +50,25 @@ github_integration:
5050

5151
peer_review:
5252
enabled: true
53-
request_texts: # When users request reviews
53+
request_texts: # When users request reviews
5454
description: |
5555
This peer review system helps ensure query quality and data safety.
5656
57-
Note: Queries that fail after approval will require a new review request.
57+
**Note: Queries that fail after approval will require a new review request.**
5858
59-
Important Guidelines:
60-
• Choose reviewers familiar with the affected data
61-
• Include relevant references in query title or justification
62-
• Document query purpose and impact
63-
guide_link: 'https://www.querybook.org/'
59+
**Important Guidelines**:
60+
61+
- Choose reviewers familiar with the affected data
62+
- Include relevant references in query title or justification
63+
- Document query purpose and impact
64+
guide_link: 'https://www.querybook.org/docs/user_guide/query_review/'
6465
tip: |
6566
Before Submitting:
66-
• Run query to verify syntax
67-
• Validate table names and fields
68-
• Check query performance
69-
reviewer_texts: # When reviewers take actions
67+
68+
- Run query to verify syntax
69+
- Validate table names and fields
70+
- Check query performance
71+
reviewer_texts: # When reviewers take actions
7072
approve_message: |
7173
As a reviewer, you are responsible for validating:
7274

querybook/webapp/components/QueryPeerReviewModal/QueryPeerReviewModal.scss

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -33,32 +33,6 @@
3333
.main-description {
3434
padding: 20px;
3535
background: var(--bg);
36-
37-
.description-text {
38-
color: var(--text);
39-
font-size: var(--text-size);
40-
line-height: 1.6;
41-
white-space: pre-wrap;
42-
43-
ul {
44-
list-style-type: none;
45-
padding-left: 0;
46-
margin: 12px 0;
47-
48-
li {
49-
position: relative;
50-
padding-left: 20px;
51-
margin-bottom: 8px;
52-
53-
&:before {
54-
content: "";
55-
position: absolute;
56-
left: 0;
57-
color: var(--color-accent);
58-
}
59-
}
60-
}
61-
}
6236
}
6337

6438
.checklist-box {
@@ -70,25 +44,6 @@
7044
color: var(--text);
7145
font-size: var(--text-size);
7246
line-height: 1.6;
73-
74-
ul {
75-
list-style-type: none;
76-
padding-left: 0;
77-
margin: 12px 0;
78-
79-
li {
80-
position: relative;
81-
padding-left: 20px;
82-
margin-bottom: 8px;
83-
84-
&:before {
85-
content: "";
86-
position: absolute;
87-
left: 0;
88-
color: var(--color-true);
89-
}
90-
}
91-
}
9247
}
9348

9449
.guide-link {

querybook/webapp/components/QueryPeerReviewModal/QueryPeerReviewModal.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,23 @@ import { Form, Formik } from 'formik';
22
import React, { useCallback } from 'react';
33
import { toast } from 'react-hot-toast';
44
import * as Yup from 'yup';
5-
import { navigateWithinEnv } from 'lib/utils/query-string';
65

76
import { MultiCreatableUserSelect } from 'components/UserSelect/MultiCreatableUserSelect';
87
import { IPeerReviewParams } from 'const/datadoc';
8+
import { usePeerReview } from 'lib/peer-review/config';
9+
import { navigateWithinEnv } from 'lib/utils/query-string';
910
import { AsyncButton } from 'ui/AsyncButton/AsyncButton';
1011
import { FormField } from 'ui/Form/FormField';
1112
import { FormWrapper } from 'ui/Form/FormWrapper';
1213
import { SimpleField } from 'ui/FormikField/SimpleField';
14+
import { Icon } from 'ui/Icon/Icon';
1315
import { Link } from 'ui/Link/Link';
16+
import { Markdown } from 'ui/Markdown/Markdown';
1417
import { Message } from 'ui/Message/Message';
1518
import { Modal } from 'ui/Modal/Modal';
1619
import { IStandardModalProps } from 'ui/Modal/types';
17-
import { Icon } from 'ui/Icon/Icon';
1820

1921
import './QueryPeerReviewModal.scss';
20-
import { usePeerReview } from 'lib/peer-review/config';
2122

2223
interface IQueryPeerReviewFormProps {
2324
onSubmit: (peerReviewParams: IPeerReviewParams) => Promise<number>;
@@ -40,12 +41,12 @@ const DescriptionSection: React.FC<IDescriptionSectionProps> = ({
4041
<div className="description-content">
4142
<div className="main-description">
4243
<h4>About Peer Review</h4>
43-
<div className="description-text">{description}</div>
44+
<Markdown>{description}</Markdown>
4445
</div>
4546

4647
<div className="checklist-box">
4748
<h4>Review Checklist</h4>
48-
<div className="checklist-content">{tip}</div>
49+
<Markdown>{tip}</Markdown>
4950
<div className="guide-link">
5051
<Link to={guideLink} newTab>
5152
<Icon name="Book" size={12} />

0 commit comments

Comments
 (0)