Skip to content

Commit bded2c6

Browse files
Popover: remove border options (#4020)
1 parent 100938a commit bded2c6

File tree

9 files changed

+6
-18
lines changed

9 files changed

+6
-18
lines changed

packages/gestalt/src/Contents.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
.border {
2-
border: 1px solid currentColor;
3-
}
4-
51
.maxDimensions {
62
max-height: 90vh;
73
max-width: 90vw;

packages/gestalt/src/Popover/Contents.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ type Props = {
2626
accessibilityLabel?: string;
2727
anchor: HTMLElement;
2828
bgColor?: 'blue' | 'darkGray' | 'white';
29-
border?: boolean;
3029
caret?: boolean;
3130
children?: ReactNode;
3231
id: string | undefined;
@@ -48,7 +47,6 @@ export default function Contents({
4847
accessibilityLabel,
4948
anchor,
5049
bgColor,
51-
border = true,
5250
caret = true,
5351
children,
5452
id,
@@ -156,7 +154,6 @@ export default function Contents({
156154
aria-label={accessibilityLabel}
157155
className={classnames(layoutStyles.relative, styles.maxDimensions, {
158156
[styles.minDimensions]: width != null,
159-
[styles.border]: border,
160157
[styles.primary]: bgColor === 'white',
161158
[styles.secondary]: bgColor === 'darkGray',
162159
[styles.education]: bgColor === 'blue',

packages/gestalt/src/Popover/Controller.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ type Props = {
1717
accessibilityLabel?: string;
1818
anchor: HTMLElement;
1919
bgColor?: 'blue' | 'darkGray' | 'white';
20-
border?: boolean;
2120
caret?: boolean;
2221
children?: ReactNode;
2322
onKeyDown?: (arg1: { event: React.KeyboardEvent<HTMLElement> }) => void;
@@ -41,7 +40,6 @@ export default function Controller({
4140
accessibilityLabel,
4241
anchor,
4342
bgColor,
44-
border,
4543
caret,
4644
children,
4745
id,
@@ -81,7 +79,6 @@ export default function Controller({
8179
accessibilityLabel={accessibilityLabel}
8280
anchor={anchor}
8381
bgColor={bgColor}
84-
border={border}
8582
caret={caret}
8683
forceDirection={forceDirection}
8784
hideWhenReferenceHidden={hideWhenReferenceHidden}

packages/gestalt/src/Popover/InternalPopover.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ export default function InternalPopover({
7676
accessibilityLabel={accessibilityLabel}
7777
anchor={anchor}
7878
bgColor={color}
79-
border
8079
caret={showCaret}
8180
disablePortal={disablePortal}
8281
forceDirection={forceDirection}

packages/gestalt/src/Tooltip/InternalTooltip.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ export default function InternalTooltip({
157157
<Controller
158158
anchor={anchor}
159159
bgColor={isInVRExperiment ? undefined : 'darkGray'}
160-
border={false}
161160
caret={false}
162161
disablePortal
163162
hideWhenReferenceHidden

packages/gestalt/src/__snapshots__/Dropdown.jsdom.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ exports[`Dropdown renders a menu of 3 items conditionally 1`] = `
2626
>
2727
<div
2828
aria-label="Dropdown"
29-
class="relative maxDimensions minDimensions border primary rounding4"
29+
class="relative maxDimensions minDimensions primary rounding4"
3030
id="ex-1"
3131
role="menu"
3232
style="max-width: 360px; overflow: auto;"
@@ -593,7 +593,7 @@ exports[`Dropdown renders a menu of 6 items 1`] = `
593593
>
594594
<div
595595
aria-label="Dropdown"
596-
class="relative maxDimensions minDimensions border primary rounding4"
596+
class="relative maxDimensions minDimensions primary rounding4"
597597
id="ex-1"
598598
role="menu"
599599
style="max-width: 360px; overflow: auto;"

packages/gestalt/src/__snapshots__/OverlayPanel.jsdom.test.tsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ exports[`OverlayPanel renders OverlayPanel with confirmation modal 1`] = `
9595
>
9696
<div
9797
aria-label="Popover"
98-
class="relative maxDimensions minDimensions border primary rounding4"
98+
class="relative maxDimensions minDimensions primary rounding4"
9999
role="dialog"
100100
style="max-width: 284px; overflow: auto;"
101101
>

packages/gestalt/src/__snapshots__/Popover.jsdom.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ exports[`Popover renders correctly 1`] = `
2121
>
2222
<div
2323
aria-label="text"
24-
class="relative maxDimensions minDimensions border primary rounding4"
24+
class="relative maxDimensions minDimensions primary rounding4"
2525
role="dialog"
2626
style="max-width: 230px; overflow: auto;"
2727
>
@@ -72,7 +72,7 @@ exports[`Popover renders correctly with portal 1`] = `
7272
>
7373
<div
7474
aria-label="text"
75-
class="relative maxDimensions minDimensions border primary rounding4"
75+
class="relative maxDimensions minDimensions primary rounding4"
7676
role="dialog"
7777
style="max-width: 230px; overflow: auto;"
7878
>

packages/gestalt/src/__snapshots__/PopoverEducational.jsdom.test.tsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ exports[`PopoverEducational renders 1`] = `
2727
</div>
2828
<div
2929
aria-label="test"
30-
class="relative maxDimensions minDimensions border education rounding4"
30+
class="relative maxDimensions minDimensions education rounding4"
3131
role="dialog"
3232
style="max-width: 230px; overflow: auto;"
3333
>

0 commit comments

Comments
 (0)