Skip to content

Seed does not appear to be random and changing it does not change the output #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lrq3000 opened this issue Dec 30, 2024 · 4 comments

Comments

@lrq3000
Copy link

lrq3000 commented Dec 30, 2024

I tried to generate multiple times and I always get the same output image, whether the seed is set to -1 or any other value, so it seems the seed is hardcoded somewhere in the code, this seems like a bug unless I'm mistaken (assuming all other parameters are fixed).

@ai-anchorite
Copy link
Collaborator

hmm. I'll dig in at some stage and see what's happening. Added to my to-do list.

The app is a port of https://huggingface.co/spaces/finegrain/finegrain-image-enhancer to local via Pinokio, as per the README, so it's doing whatever it does.

@ai-anchorite
Copy link
Collaborator

i tested an image with different set seeds on the HF demo and can't see a difference between them. So might be an issue there.

Thanks for the report! Will look into it when i get a chance.

@lrq3000
Copy link
Author

lrq3000 commented Dec 31, 2024

Oh OK thank you for investing this issue! Then I will also report the issue upstream, along with a few others, such as the app strangely downscaling already large images.

@ai-anchorite
Copy link
Collaborator

The downscaling is part of the process for sure. I think partly due to the first upscaling pass being ESRSGAN x4; and partly due to it being a demo project rather than intended as a fully functional upscaling app. They direct people to their paid image editor app from the HF demo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants