From 88de41e7da063224b9c6a4a03c479ae9e73acc14 Mon Sep 17 00:00:00 2001 From: Connor Dirks Date: Thu, 6 Jun 2024 20:13:50 -0400 Subject: [PATCH 1/6] fix: domain typing --- packages/permissionless/actions/smartAccount/signTypedData.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/permissionless/actions/smartAccount/signTypedData.ts b/packages/permissionless/actions/smartAccount/signTypedData.ts index bc7e07fa..84a2d07b 100644 --- a/packages/permissionless/actions/smartAccount/signTypedData.ts +++ b/packages/permissionless/actions/smartAccount/signTypedData.ts @@ -6,6 +6,7 @@ import { type Transport, type TypedData, type TypedDataDefinition, + type TypedDataDomain, getTypesForEIP712Domain, validateTypedData } from "viem" @@ -136,10 +137,9 @@ export async function signTypedData< const account = parseAccount(account_) const types = { - EIP712Domain: getTypesForEIP712Domain({ domain }), + EIP712Domain: getTypesForEIP712Domain(domain as {domain: TypedDataDomain}), // Cast 'domain' to 'TypedDataDomain' ...(types_ as TTypedData) } - validateTypedData({ domain, message, From 0bcaa27f2382f2bfa6970bb62aba2161031e570b Mon Sep 17 00:00:00 2001 From: Connor Dirks <80544198+cdirks4@users.noreply.github.com> Date: Thu, 6 Jun 2024 20:31:31 -0400 Subject: [PATCH 2/6] fix: remove comment --- packages/permissionless/actions/smartAccount/signTypedData.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/permissionless/actions/smartAccount/signTypedData.ts b/packages/permissionless/actions/smartAccount/signTypedData.ts index 84a2d07b..c46d78c8 100644 --- a/packages/permissionless/actions/smartAccount/signTypedData.ts +++ b/packages/permissionless/actions/smartAccount/signTypedData.ts @@ -137,7 +137,7 @@ export async function signTypedData< const account = parseAccount(account_) const types = { - EIP712Domain: getTypesForEIP712Domain(domain as {domain: TypedDataDomain}), // Cast 'domain' to 'TypedDataDomain' + EIP712Domain: getTypesForEIP712Domain(domain as {domain: TypedDataDomain}), ...(types_ as TTypedData) } validateTypedData({ From 7dde111ad35385c3da1db2b09b1e4ffae19c684d Mon Sep 17 00:00:00 2001 From: Connor Dirks <80544198+cdirks4@users.noreply.github.com> Date: Thu, 6 Jun 2024 20:32:57 -0400 Subject: [PATCH 3/6] create changeset --- .changeset/metal-trainers-sit.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/metal-trainers-sit.md diff --git a/.changeset/metal-trainers-sit.md b/.changeset/metal-trainers-sit.md new file mode 100644 index 00000000..3343adf8 --- /dev/null +++ b/.changeset/metal-trainers-sit.md @@ -0,0 +1,5 @@ +--- +"permissionless": patch +--- + +fix: domain typing From 6585394b6ecedb1f80bd99a581cd1c0c5765a0d4 Mon Sep 17 00:00:00 2001 From: Connor Dirks Date: Fri, 7 Jun 2024 11:56:29 -0400 Subject: [PATCH 4/6] fix: domain should still be and object --- packages/permissionless/actions/smartAccount/signTypedData.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/permissionless/actions/smartAccount/signTypedData.ts b/packages/permissionless/actions/smartAccount/signTypedData.ts index c46d78c8..a5aec580 100644 --- a/packages/permissionless/actions/smartAccount/signTypedData.ts +++ b/packages/permissionless/actions/smartAccount/signTypedData.ts @@ -137,7 +137,7 @@ export async function signTypedData< const account = parseAccount(account_) const types = { - EIP712Domain: getTypesForEIP712Domain(domain as {domain: TypedDataDomain}), + EIP712Domain: getTypesForEIP712Domain({domain} as {domain: TypedDataDomain}), ...(types_ as TTypedData) } validateTypedData({ From b6117f8bfe4faeb58aa6476927bb9987e9ec5ad6 Mon Sep 17 00:00:00 2001 From: Connor Dirks Date: Fri, 7 Jun 2024 11:57:17 -0400 Subject: [PATCH 5/6] fix: update change log --- .changeset/metal-trainers-sit.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/metal-trainers-sit.md b/.changeset/metal-trainers-sit.md index 3343adf8..32c098bf 100644 --- a/.changeset/metal-trainers-sit.md +++ b/.changeset/metal-trainers-sit.md @@ -2,4 +2,4 @@ "permissionless": patch --- -fix: domain typing +Fixed domain not typed as TypedDataDomain From 54c14cb61dc1d9279c5342cd5b7f2d5e927e2ca9 Mon Sep 17 00:00:00 2001 From: Garvit Khatri Date: Sun, 9 Jun 2024 17:53:52 +0530 Subject: [PATCH 6/6] Lint --- packages/permissionless/actions/smartAccount/signTypedData.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/permissionless/actions/smartAccount/signTypedData.ts b/packages/permissionless/actions/smartAccount/signTypedData.ts index a5aec580..5b833f6e 100644 --- a/packages/permissionless/actions/smartAccount/signTypedData.ts +++ b/packages/permissionless/actions/smartAccount/signTypedData.ts @@ -137,7 +137,9 @@ export async function signTypedData< const account = parseAccount(account_) const types = { - EIP712Domain: getTypesForEIP712Domain({domain} as {domain: TypedDataDomain}), + EIP712Domain: getTypesForEIP712Domain({ domain } as { + domain: TypedDataDomain + }), ...(types_ as TTypedData) } validateTypedData({