Fix achievement and highscore systems not writing files to user's application data folder

Author: henriiquecampos

source/meta/Score.gd

@@ -2,19 +2,12 @@ extends Node
 
 signal scored
 
+const USER_PATH = "user://highscore"
 var current_score = 0 setget set_score, get_score
 var high_score = 0
 
 func _ready():
-	var f = File.new()
-	if f.file_exists("user://highscore"):
-		f.open("user://highscore", f.READ)
-		high_score = f.get_var()
-		f.close()
-	else:
-		f.open("user://highscore", f.WRITE)
-		f.store_var(high_score)
-		f.close()
+	read_highscore()
 
 func set_score(value):
 	current_score = value
@@ -30,16 +23,20 @@ func get_score():
 	return(current_score)
 
 func write_highscore():
-	var f = File.new()
-	if f.file_exists("user://highscore"):
-		f.open("user://highscore", f.WRITE)
-		f.store_var(high_score)
-		f.close()
+	var file = File.new()
+	if file.file_exists(USER_PATH):
+		file.open(USER_PATH, file.WRITE)
+	else:
+		file.open(USER_PATH, file.WRITE_READ)
+	file.store_var(high_score)
+	file.close()
 
 func read_highscore():
-	var f = File.new()
-	if f.file_exists("user://highscore"):
-		f.open("user://highscore", f.READ)
-		high_score = f.get_var()
-		f.close()
+	var file = File.new()
+	if file.file_exists(USER_PATH):
+		file.open(USER_PATH, file.READ)
+		high_score = file.get_var()
+		file.close()
+	else:
+		write_highscore()
 	return(high_score)

source/meta/Score.tscn

@@ -2,7 +2,6 @@
 
 [ext_resource path="res://meta/Score.gd" type="Script" id=1]
 
-
 [node name="Score" type="Node"]
 script = ExtResource( 1 )
 

source/meta/achievements/AchievementsDictionary.gd

@@ -26,10 +26,10 @@ func read_achievements():
 
 func write_achievements():
 	var file = File.new()
-	file.open(USER_PATH, file.WRITE)
+	file.open(USER_PATH, file.WRITE_READ)
 	file.store_string(to_json(_dict))
 	file.close()
-		
+
 func set_achievement_progress(achievement_name, new_value):
 	var achievement = _get_achievement(achievement_name)
 	var is_complete = is_achievement_complete(achievement_name)