chore: new compilation warnings dropped

Author: gmoshkin

tarantool/src/error.rs

@@ -441,7 +441,7 @@ unsafe fn error_get_file_line(ptr: *const ffi::BoxError) -> Option<(String, u32)
     struct Failure;
     static mut FIELD_OFFSETS: Option<std::result::Result<(u32, u32), Failure>> = None;
 
-    if FIELD_OFFSETS.is_none() {
+    if (*std::ptr::addr_of!(FIELD_OFFSETS)).is_none() {
         let lua = crate::lua_state();
         let res = lua.eval::<(u32, u32)>(
             "ffi = require 'ffi'

tarantool/src/ffi/mod.rs

@@ -78,7 +78,7 @@ pub fn has_datetime() -> bool {
 #[inline]
 pub unsafe fn has_fiber_set_ctx() -> bool {
     static mut RESULT: Option<bool> = None;
-    if RESULT.is_none() {
+    if (*std::ptr::addr_of!(RESULT)).is_none() {
         RESULT = Some(helper::has_dyn_symbol(crate::c_str!("fiber_set_ctx")));
     }
     RESULT.unwrap()
@@ -114,7 +114,7 @@ pub fn has_fully_temporary_spaces() -> bool {
 #[inline]
 pub unsafe fn has_fiber_id() -> bool {
     static mut RESULT: Option<bool> = None;
-    if RESULT.is_none() {
+    if (*std::ptr::addr_of!(RESULT)).is_none() {
         RESULT = Some(helper::has_dyn_symbol(crate::c_str!("fiber_id")));
     }
     RESULT.unwrap()

tarantool/src/network/client/tcp.rs

@@ -28,7 +28,7 @@ use std::pin::Pin;
 use std::rc::Rc;
 use std::task::{Context, Poll};
 use std::time::Duration;
-use std::{io, marker, vec};
+use std::{io, marker};
 
 #[cfg(feature = "async-std")]
 use async_std::io::{Read as AsyncRead, Write as AsyncWrite};

tarantool/src/space.rs

@@ -1370,7 +1370,7 @@ pub fn space_id_temporary_min() -> Option<SpaceId> {
     static mut VALUE: Option<Option<SpaceId>> = None;
     // SAFETY: this is safe as we only call this from tx thread.
     unsafe {
-        if VALUE.is_none() {
+        if (*std::ptr::addr_of!(VALUE)).is_none() {
             VALUE = Some(
                 crate::lua_state()
                     .eval("return box.schema.SPACE_ID_TEMPORARY_MIN")

tarantool/src/uuid.rs

@@ -257,8 +257,9 @@ impl<'de> serde::Deserialize<'de> for Uuid {
 static mut CTID_UUID: Option<u32> = None;
 
 fn ctid_uuid() -> u32 {
+    // SAFETY: only safe to call this from tx thread
     unsafe {
-        if CTID_UUID.is_none() {
+        if (*std::ptr::addr_of!(CTID_UUID)).is_none() {
             let lua = crate::global_lua();
             let ctid_uuid =
                 tlua::ffi::luaL_ctypeid(tlua::AsLua::as_lua(&lua), crate::c_ptr!("struct tt_uuid"));

tests/src/define_str_enum.rs

@@ -95,6 +95,7 @@ pub fn basic() {
 
     // other claimed traits
     impl<'de, L: tlua::AsLua> AssertImpl<'de, L> for Color {}
+    #[allow(unused)]
     trait AssertImpl<'de, L: tlua::AsLua>:
         AsRef<str>
         + Into<String>

tests/src/fiber/channel.rs

@@ -303,6 +303,7 @@ pub fn into_clones() {
     struct NonClonable();
 
     #[derive(Clone)]
+    #[allow(unused)]
     struct MyChannel(fiber::Channel<NonClonable>);
 
     let (_, _) = MyChannel(fiber::Channel::new(1)).into_clones();

tests/src/proc.rs

@@ -256,7 +256,7 @@ pub fn inject() {
     fn global() -> &'static GlobalData {
         static mut GLOBAL: Option<GlobalData> = None;
         unsafe {
-            GLOBAL.get_or_insert_with(|| GlobalData {
+            (*std::ptr::addr_of_mut!(GLOBAL)).get_or_insert_with(|| GlobalData {
                 data: vec!["some".into(), "global".into(), "data".into()],
             })
         }

tests/src/tlua/functions_write.rs

@@ -246,7 +246,10 @@ pub fn closures_must_be_static() {
     }
     let f: LuaFunction<_> = lua.get("a").unwrap();
     let () = f.call().unwrap();
-    assert_eq!(unsafe { &GLOBAL }, &Some(vec![1, 2, 3]));
+    assert_eq!(
+        unsafe { &*std::ptr::addr_of!(GLOBAL) },
+        &Some(vec![1, 2, 3])
+    );
 }
 
 pub fn pcall() {
@@ -263,20 +266,20 @@ pub fn pcall() {
 pub fn error() {
     let lua = tarantool::lua_state();
     lua.set("error_callback",
-        tlua::function1(|lua: tlua::LuaState| tlua::error!(lua, "but it compiled :("))
+        tlua::function1(|lua: tlua::LuaState| -> () { tlua::error!(lua, "but it compiled :(") })
     );
     let msg = lua.exec("return error_callback()").unwrap_err().to_string();
     assert_eq!(msg, "but it compiled :(");
 
     lua.set("error_callback_2",
-        tlua::function2(|msg: String, lua: tlua::LuaState| tlua::error!(lua, "your message: {}", msg))
+        tlua::function2(|msg: String, lua: tlua::LuaState| -> () { tlua::error!(lua, "your message: {}", msg) })
     );
     let msg = lua.exec("return error_callback_2('my message')").unwrap_err().to_string();
     assert_eq!(msg, "your message: my message");
 
     lua.set("error_callback_3",
         tlua::Function::new(
-            |qualifier: String, lua: tlua::StaticLua| {
+            |qualifier: String, lua: tlua::StaticLua| -> () {
                 tlua::error!(lua, "this way is {qualifier}")
             }
         )

tests/src/tlua/lua_tables.rs

@@ -94,6 +94,7 @@ pub fn get_or_create_metatable() {
     {
         let table = lua.get::<LuaTable<_>, _>("a").unwrap();
 
+        #[allow(deprecated)]
         let metatable = table.get_or_create_metatable();
         fn handler() -> i32 {
             5
@@ -180,6 +181,7 @@ pub fn registry_metatable() {
     let lua = Lua::new();
 
     let registry = LuaTable::registry(&lua);
+    #[allow(deprecated)]
     let metatable = registry.get_or_create_metatable();
     metatable.set(3, "hello");
 }