Skip to content

Commit abd4d9d

Browse files
authored
settings-level-expert: hide them by default (#3487)
2 parents 8e89ec2 + a186291 commit abd4d9d

File tree

8 files changed

+21
-21
lines changed

8 files changed

+21
-21
lines changed

scripts/js/footer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,7 @@ function applyExpertSettings() {
684684
if (localStorage.getItem("expert_settings") === "true") {
685685
for (const element of expertSettingsNodes) element.classList.remove("d-none");
686686
} else {
687-
for (const element of expertSettingsNodes) element.classList.add("d-none");
687+
for (const element of expertSettingsNodes) element.classList.toggle("d-none", true);
688688

689689
// If we left with an empty page (no visible boxes) after switching from
690690
// Expert to Basic settings, redirect to admin/settings/system instead

scripts/lua/sidebar.lp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@
175175
<i class="fa-fw menu-icon fa-solid fa-address-book"></i> <span>Local DNS Records</span>
176176
</a>
177177
</li>
178-
<li class="settings-level-expert<? if scriptname == 'settings/all' then ?> active<? end ?>">
178+
<li class="settings-level-expert d-none<? if scriptname == 'settings/all' then ?> active<? end ?>">
179179
<a href="<?=webhome?>settings/all">
180180
<i class="fa-fw menu-icon fa-solid fa-pen-to-square"></i> <span>All settings</span>
181181
</a>

settings-all.lp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ mg.include('scripts/lua/header_authenticated.lp','r')
1313
PageTitle = "All Settings"
1414
mg.include('scripts/lua/settings_header.lp','r')
1515
?>
16-
<div class="row settings-level-expert" id="advanced-content">
16+
<div class="row settings-level-expert d-none" id="advanced-content">
1717
<div class="overlay" id="advanced-overlay">
1818
<i class="fa fa-sync fa-spin"></i>
1919
</div>
@@ -28,7 +28,7 @@ mg.include('scripts/lua/settings_header.lp','r')
2828
<!-- dynamically filled with content -->
2929
</div>
3030

31-
<div class="col-sm-12 settings-level-expert save-button-container">
31+
<div class="col-sm-12 settings-level-expert d-none save-button-container">
3232
<button type="button" class="btn btn-primary save-button"><i class="fa-solid fa-fw fa-floppy-disk"></i>&nbsp;Save & Apply</button>
3333
</div>
3434
</div>

settings-api.lp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ mg.include('scripts/lua/settings_header.lp','r')
4949
</div>
5050
</div>
5151

52-
<div class="col-md-6 settings-level-expert">
52+
<div class="col-md-6 settings-level-expert d-none">
5353
<div class="box box-warning">
5454
<div class="box-header with-border">
5555
<h3 class="box-title" data-configkeys="webserver.api.prettyJSON webserver.api.allow_destructive">Advanced Settings</h3>
@@ -82,7 +82,7 @@ mg.include('scripts/lua/settings_header.lp','r')
8282
</div>
8383

8484
<div class="row">
85-
<div class="col-md-12 settings-level-expert">
85+
<div class="col-md-12 settings-level-expert d-none">
8686
<div class="box box-warning">
8787
<div class="box-header with-border">
8888
<h3 class="box-title" data-configkeys="webserver.api.excludeDomains webserver.api.excludeClients">Exclusions</h3>
@@ -134,7 +134,7 @@ mg.include('scripts/lua/settings_header.lp','r')
134134
</div>
135135
</div>-->
136136

137-
<div class="col-md-12 settings-level-expert">
137+
<div class="col-md-12 settings-level-expert d-none">
138138
<div class="box box-warning">
139139
<div class="box-header with-border">
140140
<h3 class="box-title">Currently active sessions</h3>

settings-dhcp.lp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ mg.include('scripts/lua/settings_header.lp','r')
8686
</div>
8787
</div>
8888
</div>
89-
<div class="col-md-6 settings-level-expert">
89+
<div class="col-md-6 settings-level-expert d-none">
9090
<div class="box box-warning">
9191
<div class="box-header with-border">
9292
<h3 class="box-title" data-configkeys="dhcp.leaseTime dhcp.rapidCommit dhcp.multiDNS">Advanced DHCP Settings</h3>
@@ -165,7 +165,7 @@ mg.include('scripts/lua/settings_header.lp','r')
165165
</div>
166166
</div>
167167
</div>
168-
<div class="col-md-12 settings-level-expert">
168+
<div class="col-md-12 settings-level-expert d-none">
169169
<div class="box box-warning">
170170
<div class="box-header with-border">
171171
<h3 class="box-title" data-configkeys="dhcp.hosts">Static DHCP configuration</h3>

settings-dns.lp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ mg.include('scripts/lua/settings_header.lp','r')
5757
</div>
5858
</div>
5959
</div>
60-
<div class="box box-warning settings-level-expert">
60+
<div class="box box-warning settings-level-expert d-none">
6161
<div class="box-header with-border">
6262
<h3 class="box-title" data-configkeys="dns.domain dns.expandHosts">DNS domain settings</h3>
6363
</div>
@@ -81,7 +81,7 @@ mg.include('scripts/lua/settings_header.lp','r')
8181
</div>
8282
</div>
8383
</div>
84-
<div class="box box-warning settings-level-expert">
84+
<div class="box box-warning settings-level-expert d-none">
8585
<div class="box-header with-border">
8686
<h3 class="box-title" data-configkeys="dns.rateLimit.count dns.rateLimit.interval">Rate-limiting</h3>
8787
</div>
@@ -106,7 +106,7 @@ mg.include('scripts/lua/settings_header.lp','r')
106106
</div>
107107
</div>
108108
</div>
109-
<div class="col-lg-6 settings-level-expert">
109+
<div class="col-lg-6 settings-level-expert d-none">
110110
<div class="box box-warning">
111111
<div class="box-header with-border">
112112
<h1 class="box-title" data-configkeys="dns.listeningMode">Interface settings</h1>
@@ -197,7 +197,7 @@ mg.include('scripts/lua/settings_header.lp','r')
197197
</div>
198198
</div>
199199
<div class="col-lg-12">
200-
<div class="box box-warning settings-level-expert">
200+
<div class="box box-warning settings-level-expert d-none">
201201
<div class="box-header with-border">
202202
<h3 class="box-title" data-configkeys="dns.revServers">Conditional forwarding</h3>
203203
</div>

settings-privacy.lp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ mg.include('scripts/lua/settings_header.lp','r')
3434
</div>
3535
</div>
3636
</div>
37-
<div class="col-md-12 settings-level-expert">
37+
<div class="col-md-12 settings-level-expert d-none">
3838
<div class="box box-warning">
3939
<div class="box-header with-border">
4040
<h3 class="box-title" data-configkeys="database.DBimport database.maxDBdays database.network.expire">Privacy-related database settings</h3>
@@ -64,7 +64,7 @@ mg.include('scripts/lua/settings_header.lp','r')
6464
</div>
6565
</div>
6666
</div>
67-
<div class="col-md-6 settings-level-expert">
67+
<div class="col-md-6 settings-level-expert d-none">
6868
<div class="box box-warning">
6969
<div class="box-header with-border">
7070
<h3 class="box-title" data-configkeys="misc.privacylevel">Query Anonymization ("Privacy Level")</h3>

settings-system.lp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ mg.include('scripts/lua/settings_header.lp','r')
7474
<i class="fa fa-sync fa-spin"></i>
7575
</div>
7676
</div>
77-
<div class="box settings-level-expert">
77+
<div class="box settings-level-expert d-none">
7878
<div class="box-header with-border">
7979
<h3 class="box-title">DHCP server metrics</h3>
8080
</div>
@@ -150,7 +150,7 @@ mg.include('scripts/lua/settings_header.lp','r')
150150
</div>
151151
</div>
152152
<div class="col-md-6">
153-
<div class="box settings-level-expert" id="cache-metrics">
153+
<div class="box settings-level-expert d-none" id="cache-metrics">
154154
<div class="box-header with-border">
155155
<h3 class="box-title">DNS cache metrics</h3>
156156
</div>
@@ -185,7 +185,7 @@ mg.include('scripts/lua/settings_header.lp','r')
185185
</tr>
186186
</tbody>
187187
</table>
188-
<!-- <table class="table table-striped table-bordered nowrap settings-level-expert">
188+
<!-- <table class="table table-striped table-bordered nowrap settings-level-expert d-none">
189189
<tbody id="dns-cache-table">
190190
</tbody>
191191
</table> -->
@@ -230,7 +230,7 @@ mg.include('scripts/lua/settings_header.lp','r')
230230
<th scope="row">Unanswered queries:</th>
231231
<td id="sysinfo-dns-replies-unanswered">&nbsp;</td>
232232
</tr>
233-
<tr class="settings-level-expert">
233+
<tr class="settings-level-expert d-none">
234234
<th scope="row">Authoritative replies:</th>
235235
<td id="sysinfo-dns-replies-auth">&nbsp;</td>
236236
</tr>
@@ -244,7 +244,7 @@ mg.include('scripts/lua/settings_header.lp','r')
244244
</div>
245245
</div>
246246
</div>
247-
<div class="col-md-12 settings-level-expert">
247+
<div class="col-md-12 settings-level-expert d-none">
248248
<div class="box box-warning">
249249
<div class="box-header with-border">
250250
<h3 class="box-title">Actions</h3>
@@ -260,7 +260,7 @@ mg.include('scripts/lua/settings_header.lp','r')
260260
<div class="col-xs-12 col-md-6 col-lg-3">
261261
<button type="button" class="btn btn-danger confirm-flusharp btn-block button-pad destructive_action" disabled>Flush network table</button>
262262
</div>
263-
<div class="col-xs-12 col-md-6 col-lg-3 settings-level-expert">
263+
<div class="col-xs-12 col-md-6 col-lg-3 settings-level-expert d-none">
264264
<button type="button" class="btn btn-danger confirm-flushlogs btn-block button-pad destructive_action" disabled>Flush logs (last 24 hours)</button>
265265
</div>
266266
</div>

0 commit comments

Comments
 (0)