Skip to content

Commit d88e2fe

Browse files
committed
Remove dead code
1 parent 222676e commit d88e2fe

File tree

3 files changed

+6
-17
lines changed

3 files changed

+6
-17
lines changed

src/Analyser/NodeScopeResolver.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5404,7 +5404,7 @@ private function processAssignVar(
54045404
$conditionalExpressions = $this->processSureTypesForConditionalExpressionsAfterAssign($scope, $var->name, $conditionalExpressions, $falseySpecifiedTypes, $falseyType);
54055405
$conditionalExpressions = $this->processSureNotTypesForConditionalExpressionsAfterAssign($scope, $var->name, $conditionalExpressions, $falseySpecifiedTypes, $falseyType);
54065406

5407-
$nodeCallback(new VariableAssignNode($var, $assignedExpr, $isAssignOp), $result->getScope());
5407+
$nodeCallback(new VariableAssignNode($var, $assignedExpr), $result->getScope());
54085408
$scope = $scope->assignVariable($var->name, $type, $scope->getNativeType($assignedExpr), TrinaryLogic::createYes());
54095409
foreach ($conditionalExpressions as $exprString => $holders) {
54105410
$scope = $scope->addConditionalExpressions($exprString, $holders);
@@ -5542,7 +5542,7 @@ private function processAssignVar(
55425542

55435543
if ($varType->isArray()->yes() || !(new ObjectType(ArrayAccess::class))->isSuperTypeOf($varType)->yes()) {
55445544
if ($var instanceof Variable && is_string($var->name)) {
5545-
$nodeCallback(new VariableAssignNode($var, $assignedPropertyExpr, $isAssignOp), $scope);
5545+
$nodeCallback(new VariableAssignNode($var, $assignedPropertyExpr), $scope);
55465546
$scope = $scope->assignVariable($var->name, $valueToWrite, $nativeValueToWrite, TrinaryLogic::createYes());
55475547
} else {
55485548
if ($var instanceof PropertyFetch || $var instanceof StaticPropertyFetch) {
@@ -5574,7 +5574,7 @@ private function processAssignVar(
55745574
}
55755575
} else {
55765576
if ($var instanceof Variable) {
5577-
$nodeCallback(new VariableAssignNode($var, $assignedPropertyExpr, $isAssignOp), $scope);
5577+
$nodeCallback(new VariableAssignNode($var, $assignedPropertyExpr), $scope);
55785578
} elseif ($var instanceof PropertyFetch || $var instanceof StaticPropertyFetch) {
55795579
$nodeCallback(new PropertyAssignNode($var, $assignedPropertyExpr, $isAssignOp), $scope);
55805580
if ($var instanceof PropertyFetch && $var->name instanceof Node\Identifier && !$isAssignOp) {
@@ -5861,7 +5861,7 @@ static function (): void {
58615861
}
58625862

58635863
if ($var instanceof Variable && is_string($var->name)) {
5864-
$nodeCallback(new VariableAssignNode($var, $assignedPropertyExpr, $isAssignOp), $scope);
5864+
$nodeCallback(new VariableAssignNode($var, $assignedPropertyExpr), $scope);
58655865
$scope = $scope->assignVariable($var->name, $valueToWrite, $nativeValueToWrite, TrinaryLogic::createYes());
58665866
} else {
58675867
if ($var instanceof PropertyFetch || $var instanceof StaticPropertyFetch) {

src/Node/PropertyHookStatementNode.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,9 @@
2020
final class PropertyHookStatementNode extends Stmt implements VirtualNode
2121
{
2222

23-
public function __construct(private PropertyHook $propertyHook)
23+
public function __construct(PropertyHook $propertyHook)
2424
{
25-
parent::__construct($this->propertyHook->getAttributes());
26-
}
27-
28-
public function getPropertyHook(): PropertyHook
29-
{
30-
return $this->propertyHook;
25+
parent::__construct($propertyHook->getAttributes());
3126
}
3227

3328
/**

src/Node/VariableAssignNode.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ final class VariableAssignNode extends NodeAbstract implements VirtualNode
1111
public function __construct(
1212
private Expr\Variable $variable,
1313
private Expr $assignedExpr,
14-
private bool $assignOp,
1514
)
1615
{
1716
parent::__construct($variable->getAttributes());
@@ -27,11 +26,6 @@ public function getAssignedExpr(): Expr
2726
return $this->assignedExpr;
2827
}
2928

30-
public function isAssignOp(): bool
31-
{
32-
return $this->assignOp;
33-
}
34-
3529
public function getType(): string
3630
{
3731
return 'PHPStan_Node_VariableAssignNodeNode';

0 commit comments

Comments
 (0)