Avoid duplicating the same strpos() function call

zonuexe · ondrejmirtes · commit 888056e6d4bc · 2025-07-06T19:44:37.000+02:00
diff --git a/src/Rules/ClassForbiddenNameCheck.php b/src/Rules/ClassForbiddenNameCheck.php
@@ -59,11 +59,12 @@ public function checkClassNames(array $pairs): array
 				$projectName = $project;
 				$withoutPrefixClassName = substr($className, strlen($prefix));
 
-				if (strpos($withoutPrefixClassName, '\\') === false) {
+				$pos = strpos($withoutPrefixClassName, '\\');
+				if ($pos === false) {
 					continue;
 				}
 
-				$withoutPrefixClassName = substr($withoutPrefixClassName, strpos($withoutPrefixClassName, '\\'));
+				$withoutPrefixClassName = substr($withoutPrefixClassName, $pos);
 			}
 
 			if ($projectName === null) {

Original file line number	Diff line number	Diff line change
`@@ -59,11 +59,12 @@ public function checkClassNames(array $pairs): array`
`59`	`59`	`$projectName = $project;`
`60`	`60`	`$withoutPrefixClassName = substr($className, strlen($prefix));`
`61`	`61`
`62`		`- if (strpos($withoutPrefixClassName, '\\') === false) {`
	`62`	`+ $pos = strpos($withoutPrefixClassName, '\\');`
	`63`	`+ if ($pos === false) {`
`63`	`64`	`continue;`
`64`	`65`	`}`
`65`	`66`
`66`		`- $withoutPrefixClassName = substr($withoutPrefixClassName, strpos($withoutPrefixClassName, '\\'));`
	`67`	`+ $withoutPrefixClassName = substr($withoutPrefixClassName, $pos);`
`67`	`68`	`}`
`68`	`69`
`69`	`70`	`if ($projectName === null) {`