PropertyHookAttributesRule - level 0

Author: ondrejmirtes

conf/config.level0.neon

@@ -97,6 +97,7 @@ rules:
 	- PHPStan\Rules\Properties\MissingReadOnlyByPhpDocPropertyAssignRule
 	- PHPStan\Rules\Properties\PropertiesInInterfaceRule
 	- PHPStan\Rules\Properties\PropertyAttributesRule
+	- PHPStan\Rules\Properties\PropertyHookAttributesRule
 	- PHPStan\Rules\Properties\PropertyInClassRule
 	- PHPStan\Rules\Properties\ReadOnlyPropertyRule
 	- PHPStan\Rules\Properties\ReadOnlyByPhpDocPropertyRule

src/Rules/Properties/PropertyHookAttributesRule.php

@@ -0,0 +1,37 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Properties;
+
+use Attribute;
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Node\InPropertyHookNode;
+use PHPStan\Rules\AttributesCheck;
+use PHPStan\Rules\Rule;
+
+/**
+ * @implements Rule<InPropertyHookNode>
+ */
+final class PropertyHookAttributesRule implements Rule
+{
+
+	public function __construct(private AttributesCheck $attributesCheck)
+	{
+	}
+
+	public function getNodeType(): string
+	{
+		return InPropertyHookNode::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		return $this->attributesCheck->check(
+			$scope,
+			$node->getOriginalNode()->attrGroups,
+			Attribute::TARGET_METHOD,
+			'method',
+		);
+	}
+
+}

tests/PHPStan/Rules/Properties/PropertyHookAttributesRuleTest.php

@@ -0,0 +1,62 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Properties;
+
+use PHPStan\Rules\AttributesCheck;
+use PHPStan\Rules\ClassCaseSensitivityCheck;
+use PHPStan\Rules\ClassForbiddenNameCheck;
+use PHPStan\Rules\ClassNameCheck;
+use PHPStan\Rules\FunctionCallParametersCheck;
+use PHPStan\Rules\NullsafeCheck;
+use PHPStan\Rules\PhpDoc\UnresolvableTypeHelper;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleLevelHelper;
+use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
+
+/**
+ * @extends RuleTestCase<PropertyHookAttributesRule>
+ */
+class PropertyHookAttributesRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		$reflectionProvider = $this->createReflectionProvider();
+		return new PropertyHookAttributesRule(
+			new AttributesCheck(
+				$reflectionProvider,
+				new FunctionCallParametersCheck(
+					new RuleLevelHelper($reflectionProvider, true, false, true, false, false, false),
+					new NullsafeCheck(),
+					new UnresolvableTypeHelper(),
+					new PropertyReflectionFinder(),
+					true,
+					true,
+					true,
+					true,
+				),
+				new ClassNameCheck(
+					new ClassCaseSensitivityCheck($reflectionProvider, false),
+					new ClassForbiddenNameCheck(self::getContainer()),
+				),
+				true,
+			),
+		);
+	}
+
+	public function testRule(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->analyse([__DIR__ . '/data/property-hook-attributes.php'], [
+			[
+				'Attribute class PropertyHookAttributes\Foo does not have the method target.',
+				27,
+			],
+		]);
+	}
+
+}

tests/PHPStan/Rules/Properties/data/property-hook-attributes.php

@@ -0,0 +1,57 @@
+<?php // lint >= 8.4
+
+namespace PropertyHookAttributes;
+
+#[\Attribute(\Attribute::TARGET_CLASS)]
+class Foo
+{
+
+}
+
+#[\Attribute(\Attribute::TARGET_METHOD)]
+class Bar
+{
+
+}
+
+#[\Attribute(\Attribute::TARGET_ALL)]
+class Baz
+{
+
+}
+
+class Lorem
+{
+
+	public int $i {
+		#[Foo]
+		get {
+
+		}
+	}
+
+}
+
+class Ipsum
+{
+
+	public int $i {
+		#[Bar]
+		get {
+
+		}
+	}
+
+}
+
+class Dolor
+{
+
+	public int $i {
+		#[Baz]
+		get {
+
+		}
+	}
+
+}