Handle class without namespace

Author: VincentLanglet

src/Rules/InternalTag/RestrictedInternalUsageHelper.php

@@ -13,12 +13,14 @@ final class RestrictedInternalUsageHelper
 	public function shouldBeReported(Scope $scope, string $name): bool
 	{
 		$currentNamespace = $scope->getNamespace();
-		$namespace = array_slice(explode('\\', $name), 0, -1)[0] ?? null;
 		if ($currentNamespace === null) {
-			return true;
+			$currentClass = $scope->getClassReflection()?->getName();
+
+			return $currentClass !== $name;
 		}
 
 		$currentNamespace = explode('\\', $currentNamespace)[0];
+		$namespace = array_slice(explode('\\', $name), 0, -1)[0] ?? null;
 
 		return !str_starts_with($namespace . '\\', $currentNamespace . '\\');
 	}

tests/PHPStan/Rules/InternalTag/RestrictedInternalClassConstantUsageExtensionTest.php

@@ -77,4 +77,14 @@ public function testBug12951(): void
 		]);
 	}
 
+	public function testNoNamespace(): void
+	{
+		$this->analyse([__DIR__ . '/data/no-namespace.php'], [
+			[
+				'Access to internal constant ClassInternal::INTERNAL_CONSTANT.',
+				41,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/InternalTag/RestrictedInternalMethodUsageExtensionTest.php

@@ -56,4 +56,14 @@ public function testRule(): void
 		]);
 	}
 
+	public function testNoNamespace(): void
+	{
+		$this->analyse([__DIR__ . '/data/no-namespace.php'], [
+			[
+				'Call to internal method ClassInternal::internalMethod().',
+				38,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/InternalTag/RestrictedInternalStaticMethodUsageExtensionTest.php

@@ -66,4 +66,14 @@ public function testStaticMethodCallOnInternalSubclass(): void
 		]);
 	}
 
+	public function testNoNamespace(): void
+	{
+		$this->analyse([__DIR__ . '/data/no-namespace.php'], [
+			[
+				'Call to internal static method ClassInternal::internalStaticMethod().',
+				39,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/InternalTag/data/no-namespace.php

@@ -0,0 +1,43 @@
+<?php
+
+class ClassInternal {
+	/**
+	 * @internal
+	 */
+	public const INTERNAL_CONSTANT = 'xxx';
+
+	/**
+	 * @internal
+	 */
+	public function internalMethod(): void
+	{
+
+	}
+
+	/**
+	 * @internal
+	 */
+	public static function internalStaticMethod(): void
+	{
+
+	}
+
+	protected function getFoo(): string
+	{
+		$this->internalMethod();
+		self::internalStaticMethod();
+
+		return self::INTERNAL_CONSTANT;
+	}
+}
+
+class ClassAccessOnInternal {
+	protected function getFoo(): string
+	{
+		$classInternal = new ClassInternal();
+		$classInternal->internalMethod();
+		ClassInternal::internalStaticMethod();
+
+		return ClassInternal::INTERNAL_CONSTANT;
+	}
+}