Remove Retenciones 2.0

These changes will be commited later after expression is validated

Author: eclipxe13

README.md

@@ -8,7 +8,7 @@
 [![Coverage Status][badge-coverage]][coverage]
 [![Total Downloads][badge-downloads]][downloads]
 
-> Genera expresiones de CFDI 4.4, CFDI 3.3, CFDI 3.2, RET 1.0 y RET 2.0
+> Genera expresiones de CFDI 4.4, CFDI 3.3, CFDI 3.2 y RET 1.0
 
 :us: The documentation of this project is in spanish as this is the natural language for intended audience.
 
@@ -42,12 +42,6 @@ Ejemplo de expresión para RET 1.0:
 ?&re=XAXX010101000&nr=12345678901234567890%tt=1234567890.123456&id=ad662d33-6934-459c-a128-BDf0393f0f44
 ```
 
-Ejemplo de expresión para RET 2.0:
-
-```text
-https://prodretencionverificacion.clouda.sat.gob.mx?id=AAAAAAAA-BBBB-CCCC-DDDD-000000000000&re=Ñ&A010101AAA&nr=0000000000000000000X&tt=123456.78&fe=qsIe6w==
-```
-
 ## Instalación
 
 Usa [composer](https://getcomposer.org/)

composer.json

@@ -1,6 +1,6 @@
 {
     "name": "phpcfdi/cfdi-expresiones",
-    "description": "Genera expresiones de CFDI 4.4, CFDI 3.3, CFDI 3.2, RET 1.0 y RET 2.0",
+    "description": "Genera expresiones de CFDI 4.4, CFDI 3.3, CFDI 3.2 y RET 1.0",
     "keywords": ["phpcfdi", "sat", "cfdi"],
     "homepage": "https://github.com/phpcfdi/cfdi-expresiones",
     "license": "MIT",

docs/CHANGELOG.md

@@ -19,10 +19,6 @@ Se agrega el soporte de CFDI 4.0 con fundamento en el Anexo 20.
 Para ello, la *Especificación técnica del código de barras bidimensional a incorporar en la representación impresa*
 se separa a un estándar interno llamado `CfdiStandard20170701`
 
-#### Soporte de RET 2.0
-
-Se agrega el soporte de RET 2.0 con fundamento en el Anexo 20.
-
 #### Refactorización de métodos compartidos
 
 Las expresiones de CFDI 3.3 y CFDI 4.0 son idénticas, así como la forma de formatear datos como RFC, Sello, Total, etc. 

src/DiscoverExtractor.php

@@ -10,7 +10,6 @@
 use PhpCfdi\CfdiExpresiones\Extractors\Comprobante33;
 use PhpCfdi\CfdiExpresiones\Extractors\Comprobante40;
 use PhpCfdi\CfdiExpresiones\Extractors\Retenciones10;
-use PhpCfdi\CfdiExpresiones\Extractors\Retenciones20;
 
 class DiscoverExtractor implements ExpressionExtractorInterface
 {
@@ -32,7 +31,6 @@ public function defaultExtractors(): array
             new Comprobante40(),
             new Comprobante33(),
             new Comprobante32(),
-            new Retenciones20(),
             new Retenciones10(),
         ];
     }

src/Extractors/Retenciones20.php

@@ -30,20 +30,6 @@ public function documentCfdi32(): DOMDocument
         return $document;
     }
 
-    public function documentRet20Mexican(): DOMDocument
-    {
-        $document = new DOMDocument();
-        $document->load($this->filePath('ret20-mexican-fake.xml'));
-        return $document;
-    }
-
-    public function documentRet20Foreign(): DOMDocument
-    {
-        $document = new DOMDocument();
-        $document->load($this->filePath('ret20-foreign-fake.xml'));
-        return $document;
-    }
-
     public function documentRet10Mexican(): DOMDocument
     {
         $document = new DOMDocument();

tests/Unit/DOMDocumentsTestCase.php

@@ -12,7 +12,6 @@
 use PhpCfdi\CfdiExpresiones\Extractors\Comprobante33;
 use PhpCfdi\CfdiExpresiones\Extractors\Comprobante40;
 use PhpCfdi\CfdiExpresiones\Extractors\Retenciones10;
-use PhpCfdi\CfdiExpresiones\Extractors\Retenciones20;
 
 class DiscoverExtractorTest extends DOMDocumentsTestCase
 {
@@ -35,11 +34,10 @@ public function testDefaultExtractorContainsKnownClasses(): void
         $extrator = new DiscoverExtractor();
         $extractorClasses = array_map('get_class', $extrator->defaultExtractors());
         $this->assertContains(Retenciones10::class, $extractorClasses);
-        $this->assertContains(Retenciones20::class, $extractorClasses);
         $this->assertContains(Comprobante32::class, $extractorClasses);
         $this->assertContains(Comprobante33::class, $extractorClasses);
         $this->assertContains(Comprobante40::class, $extractorClasses);
-        $this->assertCount(5, $extractorClasses);
+        $this->assertCount(4, $extractorClasses);
     }
 
     public function testDontMatchUsingEmptyDocument(): void
@@ -65,8 +63,6 @@ public function providerExpressionOnValidDocuments(): array
             'Cfdi40' => [$this->documentCfdi40(), 'CFDI40'],
             'Cfdi33' => [$this->documentCfdi33(), 'CFDI33'],
             'Cfdi32' => [$this->documentCfdi32(), 'CFDI32'],
-            'Ret20Mexican' => [$this->documentRet20Mexican(), 'RET20'],
-            'Ret20Foreign' => [$this->documentRet20Foreign(), 'RET20'],
             'Ret10Mexican' => [$this->documentRet10Mexican(), 'RET10'],
             'Ret10Foreign' => [$this->documentRet10Foreign(), 'RET10'],
         ];

tests/Unit/DiscoverExtractorTest.php

@@ -47,8 +47,8 @@ public function testExtractRetenciones10Mexican(): void
     public function providerCfdiDifferentVersions(): array
     {
         return [
-            'RET 2.0 Mexican' => [$this->documentRet20Mexican()],
-            'RET 2.0 Foreign' => [$this->documentRet20Foreign()],
+            'CFDI 3.3' => [$this->documentCfdi33()],
+            'CFDI 4.0' => [$this->documentCfdi40()],
         ];
     }