recognize where nullable types are used, and where they are not;

Author: ashnazg

src/phpDocumentor/Reflection/NodeVisitor/ElementNameResolver.php

@@ -121,7 +121,7 @@ private function resetState(?string $namespace = null): void
     /**
      * Builds the name of the current node using the parts that are pushed to the parts list.
      */
-    private function buildName(): ?string
+    private function buildName(): string
     {
         $name = null;
         foreach ($this->parts as $part) {

src/phpDocumentor/Reflection/Php/Class_.php

@@ -43,7 +43,7 @@ final class Class_ implements Element
     private $final = false;
 
     /**
-     * @var Class_ The class this class is extending.
+     * @var null|Fqsen The class this class is extending.
      */
     private $parent = null;
 
@@ -75,11 +75,11 @@ final class Class_ implements Element
      */
     public function __construct(
         Fqsen $fqsen,
-        DocBlock $docBlock = null,
-        Fqsen $parent = null,
+        ?DocBlock $docBlock = null,
+        ?Fqsen $parent = null,
         bool $abstract = false,
         bool $final = false,
-        Location $location = null
+        ?Location $location = null
     ) {
         if ($location === null) {
             $location = new Location(-1);

src/phpDocumentor/Reflection/Php/Factory/AbstractFactory.php

@@ -45,9 +45,9 @@ protected function createMember($stmt, StrategyContainer $strategies, ?Context $
     /**
      * @return null|DocBlockInstance
      */
-    protected function createDocBlock(StrategyContainer $strategies, ?Doc $docBlock = null, ?Context $context = null)
+    protected function createDocBlock(?StrategyContainer $strategies = null, ?Doc $docBlock = null, ?Context $context = null)
     {
-        if ($docBlock === null) {
+        if ($docBlock === null || $strategies === null) {
             return null;
         }
 

src/phpDocumentor/Reflection/Php/Factory/ClassConstantIterator.php

@@ -72,7 +72,7 @@ public function getFqsen(): Fqsen
      *
      * The doc comment has to be the last comment associated with the node.
      *
-     * @return null|string|Doc Doc comment object or null
+     * @return null|Doc Doc comment object or null
      */
     public function getDocComment()
     {

src/phpDocumentor/Reflection/Php/Factory/DocBlock.php

@@ -67,7 +67,7 @@ public function matches($object): bool
      */
     public function create($object, StrategyContainer $strategies, ?Context $context = null)
     {
-        if ($object === null) {
+        if ($object == null) {
             return null;
         }
 

src/phpDocumentor/Reflection/Php/Factory/PropertyIterator.php

@@ -89,7 +89,7 @@ public function getLine(): int
      *
      * The doc comment has to be the last comment associated with the node.
      *
-     * @return null|string|Doc Doc comment object or null
+     * @return null|Doc Doc comment object or null
      */
     public function getDocComment()
     {

src/phpDocumentor/Reflection/Php/File.php

@@ -36,7 +36,7 @@ final class File
     /** @var string $path */
     private $path = null;
 
-    /** @var string|null $source */
+    /** @var string $source */
     private $source = null;
 
     /** @var Fqsen[] $namespaces */
@@ -65,9 +65,8 @@ final class File
      *
      *
      * @param string $hash An MD5 hash of the contents if this file.
-     * @param string|null $source
      */
-    public function __construct(string $hash, string $path, ?string $source = null, ?DocBlock $docBlock = null)
+    public function __construct(string $hash, string $path, string $source = '', ?DocBlock $docBlock = null)
     {
         $this->hash = $hash;
         $this->path = $path;
@@ -87,7 +86,7 @@ public function getHash(): string
     /**
      * Retrieves the contents of this file.
      */
-    public function getSource(): ?string
+    public function getSource(): string
     {
         return $this->source;
     }

src/phpDocumentor/Reflection/Php/Interface_.php

@@ -58,8 +58,8 @@ final class Interface_ implements Element
     public function __construct(
         Fqsen $fqsen,
         array $parents = [],
-        DocBlock $docBlock = null,
-        Location $location = null
+        ?DocBlock $docBlock = null,
+        ?Location $location = null
     ) {
         if ($location === null) {
             $location = new Location(-1);

src/phpDocumentor/Reflection/Php/Method.php

@@ -45,7 +45,7 @@ final class Method implements Element
     /** @var bool $static */
     private $static = false;
 
-    /** @var Visibility visibility of this method */
+    /** @var null|Visibility visibility of this method */
     private $visibility = null;
 
     /** @var Argument[] */
@@ -71,13 +71,13 @@ final class Method implements Element
      */
     public function __construct(
         Fqsen $fqsen,
-        Visibility $visibility = null,
-        DocBlock $docBlock = null,
+        ?Visibility $visibility = null,
+        ?DocBlock $docBlock = null,
         bool $abstract = false,
         bool $static = false,
         bool $final = false,
-        Location $location = null,
-        Type $returnType = null
+        ?Location $location = null,
+        ?Type $returnType = null
     ) {
         $this->fqsen = $fqsen;
         $this->visibility = $visibility;
@@ -129,7 +129,7 @@ public function isStatic(): bool
     /**
      * Returns the Visibility of this method.
      */
-    public function getVisibility(): Visibility
+    public function getVisibility(): ?Visibility
     {
         return $this->visibility;
     }

src/phpDocumentor/Reflection/Php/Project.php

@@ -25,7 +25,7 @@ final class Project implements ProjectInterface
     /** @var string $name */
     private $name = '';
 
-    /** @var Namespace_ $rootNamespace */
+    /** @var Namespace_|null */
     private $rootNamespace;
 
     /**
@@ -100,7 +100,7 @@ public function addNamespace(Namespace_ $namespace): void
     /**
      * Returns the root (global) namespace.
      */
-    public function getRootNamespace(): Namespace_
+    public function getRootNamespace(): ?Namespace_
     {
         return $this->rootNamespace;
     }