Merge pull request #102 from marcosh/bug/anonymous-classes

expose invalid Fqsen bug and fix it

Author: jaapio

src/phpDocumentor/Reflection/NodeVisitor/ElementNameResolver.php

@@ -25,6 +25,7 @@
 use PhpParser\Node\Stmt\Namespace_;
 use PhpParser\Node\Stmt\PropertyProperty;
 use PhpParser\Node\Stmt\Trait_;
+use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 
 final class ElementNameResolver extends NodeVisitorAbstract
@@ -81,6 +82,10 @@ public function enterNode(Node $node)
             case Class_::class:
             case Trait_::class:
             case Interface_::class:
+                if (is_null($node->name)) {
+                    return NodeTraverser::DONT_TRAVERSE_CHILDREN;
+                }
+
                 $this->parts->push((string)$node->name);
                 $node->fqsen = new Fqsen($this->buildName());
                 break;

tests/unit/phpDocumentor/Reflection/NodeVisitor/ElementNameResolverTest.php

@@ -20,6 +20,7 @@
 use PhpParser\Node\Stmt\ClassConst;
 use PhpParser\Node\Stmt\Function_;
 use PhpParser\Node\Stmt\Namespace_;
+use PhpParser\NodeTraverser;
 
 /**
  * Testcase for FqsenResolver
@@ -61,6 +62,21 @@ public function testWithClass()
         $this->assertEquals('\myClass', (string)$class->fqsen);
     }
 
+    /**
+     * If anonymous classes were processed, we would obtain a
+     * InvalidArgumentException for an invalid Fqsen.
+     *
+     * @covers ::enterNode
+     */
+    public function testDoesNotEnterAnonymousClass()
+    {
+        $class = new Class_(null);
+        $this->assertEquals(
+            NodeTraverser::DONT_TRAVERSE_CHILDREN,
+            $this->fixture->enterNode($class)
+        );
+    }
+
     /**
      * @covers ::enterNode
      */