add strict typing, return types, and more typehints;

Author: ashnazg

src/phpDocumentor/Reflection/Exception.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * This file is part of phpDocumentor.
  *

src/phpDocumentor/Reflection/File/LocalFile.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * This file is part of phpDocumentor.
  *
@@ -29,7 +31,7 @@ final class LocalFile implements File
      * LocalFile constructor.
      * @param string $path
      */
-    public function __construct($path)
+    public function __construct(string $path)
     {
         $this->path = $path;
     }
@@ -39,7 +41,7 @@ public function __construct($path)
      *
      * @return string
      */
-    public function getContents()
+    public function getContents(): string
     {
         return file_get_contents($this->path);
     }
@@ -49,7 +51,7 @@ public function getContents()
      *
      * @return string
      */
-    public function md5()
+    public function md5(): string
     {
         return md5_file($this->path);
     }
@@ -59,7 +61,7 @@ public function md5()
      *
      * @return string
      */
-    public function path()
+    public function path(): string
     {
         return $this->path;
     }

src/phpDocumentor/Reflection/Middleware/ChainFactory.php

@@ -1,8 +1,11 @@
 <?php
+declare(strict_types=1);
+
 /**
- * phpDocumentor
+ * This file is part of phpDocumentor.
  *
- * PHP Version 5.5
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
  *
  * @copyright 2010-2018 Mike van Riel / Naenius (http://www.naenius.com)
  * @license   http://www.opensource.org/licenses/mit-license.php MIT
@@ -21,7 +24,7 @@ final class ChainFactory
      * @param callable $lastCallable
      * @return callable
      */
-    public static function createExecutionChain($middlewareList, callable $lastCallable)
+    public static function createExecutionChain(array $middlewareList, callable $lastCallable): callable
     {
         while ($middleware = array_pop($middlewareList)) {
             if (!$middleware instanceof Middleware) {

src/phpDocumentor/Reflection/Middleware/Middleware.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * This file is part of phpDocumentor.
  *

src/phpDocumentor/Reflection/NodeVisitor/ElementNameResolver.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * This file is part of phpDocumentor.
  *
@@ -15,7 +17,6 @@
 use phpDocumentor\Reflection\Fqsen;
 use PhpParser\Node;
 use PhpParser\Node\Const_;
-use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassConst;
 use PhpParser\Node\Stmt\ClassMethod;
@@ -26,26 +27,27 @@
 use PhpParser\Node\Stmt\Trait_;
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
+use SplDoublyLinkedList;
 
 final class ElementNameResolver extends NodeVisitorAbstract
 {
     /**
-     * @var \SplDoublyLinkedList
+     * @var SplDoublyLinkedList
      */
     private $parts = null;
 
     /**
      * Resets the object to a known state before start processing.
      */
-    public function beforeTraverse(array $nodes)
+    public function beforeTraverse(array $nodes): void
     {
         $this->resetState('\\');
     }
 
     /**
      * Performs a reset of the added element when needed.
      */
-    public function leaveNode(Node $node)
+    public function leaveNode(Node $node): void
     {
         switch (get_class($node)) {
             case Namespace_::class:
@@ -65,7 +67,7 @@ public function leaveNode(Node $node)
     /**
      * Adds fqsen property to a node when applicable.
      */
-    public function enterNode(Node $node)
+    public function enterNode(Node $node): ?int
     {
         switch (get_class($node)) {
             case Namespace_::class:
@@ -103,16 +105,17 @@ public function enterNode(Node $node)
                 $node->fqsen = new Fqsen($this->buildName());
                 break;
         }
+        return null;
     }
 
     /**
      * Resets the state of the object to an empty state.
      *
      * @param string $namespace
      */
-    private function resetState($namespace = null)
+    private function resetState(string $namespace = null): void
     {
-        $this->parts = new \SplDoublyLinkedList();
+        $this->parts = new SplDoublyLinkedList();
         $this->parts->push($namespace);
     }
 
@@ -121,7 +124,7 @@ private function resetState($namespace = null)
      *
      * @return null|string
      */
-    private function buildName()
+    private function buildName(): ?string
     {
         $name = null;
         foreach ($this->parts as $part) {

src/phpDocumentor/Reflection/Php/Argument.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * This file is part of phpDocumentor.
  *
@@ -42,7 +44,7 @@ final class Argument
      * @param bool $byReference
      * @param bool $isVariadic
      */
-    public function __construct($name, $default = null, $byReference = false, $isVariadic = false)
+    public function __construct(string $name, string $default = null, bool $byReference = false, bool $isVariadic = false)
     {
         $this->name = $name;
         $this->default = $default;
@@ -55,40 +57,40 @@ public function __construct($name, $default = null, $byReference = false, $isVar
      *
      * @return string
      */
-    public function getName()
+    public function getName(): string
     {
         return $this->name;
     }
 
     /**
      * {@inheritDoc}
      */
-    public function getTypes()
+    public function getTypes(): array
     {
         return $this->types;
     }
 
     /**
      * Add a type.
-     * @param string $type
+     * @param mixed $type
      */
-    public function addType($type)
+    public function addType($type): void
     {
         $this->types[] = $type;
     }
 
     /**
      * {@inheritDoc}
      */
-    public function getDefault()
+    public function getDefault(): ?string
     {
         return $this->default;
     }
 
     /**
      * {@inheritDoc}
      */
-    public function isByReference()
+    public function isByReference(): bool
     {
         return $this->byReference;
     }
@@ -98,7 +100,7 @@ public function isByReference()
      *
      * @return boolean
      */
-    public function isVariadic()
+    public function isVariadic(): bool
     {
         return $this->isVariadic;
     }