Skip to content

Commit ec449be

Browse files
committed
Rename test + add void hints
1 parent b23d543 commit ec449be

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

test/Exercise/PhpPromotionTest.php renamed to test/Exercise/PhpGetsAPromotionTest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
use PhpSchool\PhpWorkshop\Result\Failure;
1010
use PhpSchool\PhpWorkshop\TestUtils\WorkshopExerciseTest;
1111

12-
class PhpPromotionTest extends WorkshopExerciseTest
12+
class PhpGetsAPromotionTest extends WorkshopExerciseTest
1313
{
1414
public function getExerciseClass(): string
1515
{
@@ -30,7 +30,7 @@ public function testWithNoCode(): void
3030
$this->assertResultsHasFailure(Failure::class, 'No code was found');
3131
}
3232

33-
public function testWithNoPropertyPromotion()
33+
public function testWithNoPropertyPromotion(): void
3434
{
3535
$this->runExercise('solution-no-property-promotion.php');
3636

@@ -39,7 +39,7 @@ public function testWithNoPropertyPromotion()
3939
$this->assertResultsHasFailure(Failure::class, 'Properties "visitor" & "key" were not promoted');
4040
}
4141

42-
public function testWithNotAllPropertiesPromoted()
42+
public function testWithNotAllPropertiesPromoted(): void
4343
{
4444
$this->runExercise('solution-not-all-promoted.php');
4545

@@ -48,7 +48,7 @@ public function testWithNotAllPropertiesPromoted()
4848
$this->assertResultsHasFailure(Failure::class, 'Property "key" was not promoted');
4949
}
5050

51-
public function testFailureWhenPropertiesMissing()
51+
public function testFailureWhenPropertiesMissing(): void
5252
{
5353
$this->runExercise('solution-properties-missing.php');
5454

@@ -57,7 +57,7 @@ public function testFailureWhenPropertiesMissing()
5757
$this->assertResultsHasFailure(Failure::class, 'Property "key" was missing');
5858
}
5959

60-
public function testFailureIfNoClassStatement()
60+
public function testFailureIfNoClassStatement(): void
6161
{
6262
$this->runExercise('solution-no-class.php');
6363

@@ -66,7 +66,7 @@ public function testFailureIfNoClassStatement()
6666
$this->assertResultsHasFailure(Failure::class, 'No class was found');
6767
}
6868

69-
public function testFailureWhenPropertyVisibilityChanges()
69+
public function testFailureWhenPropertyVisibilityChanges(): void
7070
{
7171
$this->runExercise('solution-visibility-mutated.php');
7272

@@ -75,7 +75,7 @@ public function testFailureWhenPropertyVisibilityChanges()
7575
$this->assertResultsHasFailure(Failure::class, 'Visibility changed for properties "basePath" & "key"');
7676
}
7777

78-
public function testBadPropertyPromotion()
78+
public function testBadPropertyPromotion(): void
7979
{
8080
$this->runExercise('solution-incorrect-promotion.php');
8181

@@ -84,7 +84,7 @@ public function testBadPropertyPromotion()
8484
$this->assertResultsHasFailure(Failure::class, 'Property "config" should not be promoted');
8585
}
8686

87-
public function testFaliureIfPropertiesChangeType()
87+
public function testFaliureIfPropertiesChangeType(): void
8888
{
8989
$this->runExercise('solution-type-mutated.php');
9090

@@ -93,7 +93,7 @@ public function testFaliureIfPropertiesChangeType()
9393
$this->assertResultsHasFailure(Failure::class, 'Property "key" should not have changed type');
9494
}
9595

96-
public function testFailureIfPropertyDataIncorrect()
96+
public function testFailureIfPropertyDataIncorrect(): void
9797
{
9898
$this->runExercise('solution-data-not-set.php');
9999

@@ -102,7 +102,7 @@ public function testFailureIfPropertyDataIncorrect()
102102
$this->assertResultsHasFailure(Failure::class, 'Data not correctly set on property "basePath"');
103103
}
104104

105-
public function testSuccessWithCorrectSolution()
105+
public function testSuccessWithCorrectSolution(): void
106106
{
107107
$this->runExercise('solution.php');
108108

0 commit comments

Comments
 (0)