Add tests

Author: AydinHassan

src/Exercise/ASafeSpaceForNulls.php

@@ -16,13 +16,15 @@
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\NodeFinder;
 use PhpParser\Parser;
+use PhpSchool\PhpWorkshop\Check\FileComparisonCheck;
 use PhpSchool\PhpWorkshop\Exercise\AbstractExercise;
 use PhpSchool\PhpWorkshop\Exercise\CliExercise;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
 use PhpSchool\PhpWorkshop\Exercise\SubmissionPatchable;
 use PhpSchool\PhpWorkshop\ExerciseCheck\FileComparisonExerciseCheck;
 use PhpSchool\PhpWorkshop\ExerciseCheck\SelfCheck;
+use PhpSchool\PhpWorkshop\ExerciseDispatcher;
 use PhpSchool\PhpWorkshop\Input\Input;
 use PhpSchool\PhpWorkshop\Patch;
 use PhpSchool\PhpWorkshop\Result\Failure;
@@ -60,6 +62,11 @@ public function getArgs(): array
         return [];
     }
 
+    public function configure(ExerciseDispatcher $dispatcher): void
+    {
+        $dispatcher->requireCheck(FileComparisonCheck::class);
+    }
+
     public function getPatch(): Patch
     {
         $factory = new BuilderFactory();
@@ -172,7 +179,7 @@ public function check(Input $input): ResultInterface
             );
         }
 
-        if (count($addressFetch) !== 3) {
+        if (count($addressFetch) < 3) {
             return new Failure(
                 $this->getName(),
                 'The $user->address property should always be accessed with the null safe operator'

test/Exercise/ASafeSpaceForNullsTest.php

@@ -0,0 +1,120 @@
+<?php
+
+namespace PhpSchool\PHP8AppreciateTest\Exercise;
+
+use PhpSchool\PHP8Appreciate\Exercise\ASafeSpaceForNulls;
+use PhpSchool\PhpWorkshop\Application;
+use PhpSchool\PhpWorkshop\Result\Failure;
+use PhpSchool\PhpWorkshop\Result\FileComparisonFailure;
+use PhpSchool\PhpWorkshop\TestUtils\WorkshopExerciseTest;
+
+class ASafeSpaceForNullsTest extends WorkshopExerciseTest
+{
+    public function getExerciseClass(): string
+    {
+        return ASafeSpaceForNulls::class;
+    }
+
+    public function getApplication(): Application
+    {
+        return require __DIR__ . '/../../app/bootstrap.php';
+    }
+
+    public function tearDown(): void
+    {
+        $this->removeSolutionAsset('users.csv');
+    }
+
+    public function testFailureWhenAgeAccessedWithoutNullSafe(): void
+    {
+        $this->runExercise('no-null-safe-age.php');
+
+        $this->assertVerifyWasNotSuccessful();
+
+        $this->assertResultsHasFailure(
+            Failure::class,
+            'The $user->age property should be accessed with the null safe operator'
+        );
+    }
+
+    public function testFailureWhenAddressAccessedWithoutNullSafe(): void
+    {
+        $this->runExercise('no-null-safe-address.php');
+
+        $this->assertVerifyWasNotSuccessful();
+
+        $this->assertResultsHasFailure(
+            Failure::class,
+            'The $user->address property should always be accessed with the null safe operator'
+        );
+    }
+
+    public function testFailureWhenAddressNumberAccessedWithoutNullSafe(): void
+    {
+        $this->runExercise('no-null-safe-address-number.php');
+
+        $this->assertVerifyWasNotSuccessful();
+
+        $this->assertResultsHasFailure(
+            Failure::class,
+            'The $user->address->number property should be accessed with the null safe operator'
+        );
+    }
+
+    public function testFailureWhenAddressLine1AccessedWithoutNullSafe(): void
+    {
+        $this->runExercise('no-null-safe-address-line1.php');
+
+        $this->assertVerifyWasNotSuccessful();
+
+        $this->assertResultsHasFailure(
+            Failure::class,
+            'The $user->address->addressLine1 property should be accessed with the null safe operator'
+        );
+    }
+
+    public function testFailureWhenAddressLine2AccessedWithoutNullSafe(): void
+    {
+        $this->runExercise('no-null-safe-address-line2.php');
+
+        $this->assertVerifyWasNotSuccessful();
+
+        $this->assertResultsHasFailure(
+            Failure::class,
+            'The $user->address->addressLine2 property should be accessed with the null safe operator'
+        );
+    }
+
+    public function testFailureWhenCsvNotExported(): void
+    {
+        $this->runExercise('no-csv-export.php');
+
+        $this->assertVerifyWasNotSuccessful();
+
+        $this->assertResultsHasFailure(
+            Failure::class,
+            'File: "users.csv" does not exist'
+        );
+    }
+
+    public function testFailureWhenCsvNotCorrect(): void
+    {
+        $this->runExercise('csv-wrong.php');
+
+        $this->assertVerifyWasNotSuccessful();
+
+        $this->assertResultsHasFailure(
+            Failure::class,
+            'File: "users.csv" does not exist'
+        );
+
+//        $this->assertResultsHasFailureAndMatches(
+//            FileComparisonFailure::class,
+//            function (FileComparisonFailure $failure) {
+//                self::assertEquals('users.csv', $failure->getFileName());
+//
+//                return true;
+//            }
+//        );
+    }
+}

test/solutions/a-safe-space-for-nulls/csv-wrong.php

@@ -0,0 +1,6 @@
+<?php
+
+$fp = fopen('users.csv', 'w+');
+fputcsv($fp, ['Wrong column', 'Last Name', 'Age', 'House num', 'Addr 1', 'Addr 2']);
+fputcsv($fp, [$user->firstName, $user->lastName, $user?->age, $user?->address?->number, $user?->address?->addressLine1, $user?->address?->addressLine2]);
+fclose($fp);

test/solutions/a-safe-space-for-nulls/no-csv-export.php

@@ -0,0 +1,6 @@
+<?php
+
+echo $user?->age;
+echo $user?->address?->number;
+echo $user?->address?->addressLine1;
+echo $user?->address?->addressLine2;

test/solutions/a-safe-space-for-nulls/no-null-safe-address-line1.php

@@ -0,0 +1,6 @@
+<?php
+
+echo $user?->age;
+echo $user?->address?->number;
+echo $user?->address->addressLine1;
+echo $user?->address;

test/solutions/a-safe-space-for-nulls/no-null-safe-address-line2.php

@@ -0,0 +1,6 @@
+<?php
+
+echo $user?->age;
+echo $user?->address?->number;
+echo $user?->address?->addressLine1;
+echo $user?->address->addressLine2;

test/solutions/a-safe-space-for-nulls/no-null-safe-address-number.php

@@ -0,0 +1,6 @@
+<?php
+
+echo $user?->age;
+echo $user?->address;
+echo $user?->address;
+echo $user?->address;

test/solutions/a-safe-space-for-nulls/no-null-safe-address.php

@@ -0,0 +1,4 @@
+<?php
+
+echo $user?->age;
+echo $user->address;

test/solutions/a-safe-space-for-nulls/no-null-safe-age.php

@@ -0,0 +1,3 @@
+<?php
+
+echo $user->age;