Skip to content

Commit 4f0d987

Browse files
authored
Update AMatchMadeInHeaven.php (#17)
Add `workshop-manager install` testing to all PR's
1 parent de3367e commit 4f0d987

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

.github/workflows/build.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: MyWorkshop
1+
name: PHP8Appreciate
22

33
on:
44
push:
@@ -39,6 +39,13 @@ jobs:
3939
- name: Run phpstan
4040
run: composer static
4141

42+
- name: Install with workshop-manager
43+
run: |
44+
curl -O https://php-school.github.io/workshop-manager/workshop-manager.phar
45+
chmod +x workshop-manager.phar
46+
./workshop-manager.phar install php8appreciate ${{ github.head_ref }} ${{github.event.pull_request.head.repo.html_url}}
47+
./workshop-manager.phar installed
48+
4249
- name: Coverage upload
4350
if: matrix.php == '8.0'
4451
run: bash <(curl -s https://codecov.io/bash)

src/Exercise/AMatchMadeInHeaven.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function getName(): string
4141

4242
public function getDescription(): string
4343
{
44-
return 'A Match Made In Heaven';
44+
return 'PHP 8\'s Match Expression';
4545
}
4646

4747
public function getArgs(): array

src/Exercise/PhpPromotion.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ private function getPropertyVisibility(\ReflectionProperty $prop): string
163163
return match (true) {
164164
$prop->isPrivate() => 'private',
165165
$prop->isProtected() => 'protected',
166-
default => 'public',
166+
default => 'public',
167167
};
168168
}
169169

0 commit comments

Comments
 (0)