review fixes

Author: mikeymike

exercises/stringify-to-demystify/problem/problem.md

@@ -1,10 +1,10 @@
-`__toString()` a class magic method long-standing in PHP but never truly something you could rely on unless you rolled your own interface. All that has changed with the simple introduction of the `Stringable` interface in PHP 8.
+`__toString()` a magic class method long-standing in PHP but never truly something you could rely on unless you rolled your own interface. All that has changed with the simple introduction of the `Stringable` interface in PHP 8.
 
-A simple interface that requires the implementation of `__toString(): string`
+`Stringable` is a simple interface that requires the implementation of `__toString(): string`
 
 ----------------------------------------------------------------------
 
-Create a program that reads JSON body of the request input stream (mimicking an API response). The body will need to be JSON decoded and will be a variation of the example below:
+Create a program that reads the JSON body of the request input stream (mimicking an API response). The body will need to be JSON decoded and will be a variation of the example below:
 
 ```json
 {
@@ -14,7 +14,7 @@ Create a program that reads JSON body of the request input stream (mimicking an
 }
 ```
 
-You will need to define a new class that implements `Stringable` and it's requirements. This class should take enough information from the request so that the `__toString` method can return a string like below:
+You will need to define a new class that implements `Stringable` and it's method requirements. This class should take enough information from the request so that the `__toString` method can return a string like below:
 
 ```
 Status: 401
@@ -37,11 +37,11 @@ To easily read the request body you can use `file_get_contents('php://input')`
 
 For more details look at the docs for...
 
-**Stringable** - [https://www.php.net/manual/en/class.stringable.php)
+**Stringable** - [https://www.php.net/manual/en/class.stringable.php]()
 
-Note that while the `Stringable` interface isn't required to pass the type hint check, but it should be used if not only to show intent.  
+Note that while the `Stringable` interface isn't required to pass the type hint check, however, it should be used if not only to show intent.  
 
 Oh, and don't forget about the basics for classes and interfaces :)
 
-**class** - [https://www.php.net/manual/en/language.oop5.basic.php)
-**interfaces** - [https://www.php.net/manual/en/language.oop5.interfaces.php)
+**class** - [https://www.php.net/manual/en/language.oop5.basic.php]()
+**interfaces** - [https://www.php.net/manual/en/language.oop5.interfaces.php]()

src/Exercise/StringifyToDemystify.php

@@ -6,6 +6,7 @@
 
 use GuzzleHttp\Psr7\Request;
 use PhpParser\Node\Name;
+use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\TryCatch;
 use PhpParser\NodeFinder;
@@ -133,12 +134,9 @@ public function getBannedFunctions(): array
 
     public function check(Input $input): ResultInterface
     {
+        /** @var Stmt[] $statements */
         $statements = $this->parser->parse((string) file_get_contents($input->getRequiredArgument('program')));
 
-        if (null === $statements) {
-            return new Failure($this->getName(), 'No code statements found');
-        }
-
         /** @var Class_|null $classStmt */
         $classStmt = (new NodeFinder())->findFirstInstanceOf($statements, Class_::class);
 

test/Exercise/StringifyToDemystifyTest.php

@@ -22,15 +22,6 @@ public function getApplication(): Application
         return require __DIR__ . '/../../app/bootstrap.php';
     }
 
-    public function testWithNoCode(): void
-    {
-        $this->runExercise('solution-no-code.php');
-
-        $this->assertVerifyWasNotSuccessful();
-
-        $this->assertResultsHasFailure(Failure::class, 'No code was found');
-    }
-
     public function testWithNoClass(): void
     {
         $this->runExercise('solution-no-class.php');