Skip to content

Commit f4d5e8c

Browse files
committed
Updated code review
1 parent d32fdde commit f4d5e8c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/Common/Service/Builder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,14 +139,14 @@ private function getStack(callable $authHandler, Token $token = null): HandlerSt
139139
return $stack;
140140
}
141141

142-
private function httpClient(string $baseUrl, HandlerStack $stack, string $serviceType, string $microVersion = null): ClientInterface
142+
private function httpClient(string $baseUrl, HandlerStack $stack, string $serviceType = null, string $microVersion = null): ClientInterface
143143
{
144144
$clientOptions = [
145145
'base_uri' => Utils::normalizeUrl($baseUrl),
146146
'handler' => $stack,
147147
];
148148

149-
if ($microVersion) {
149+
if ($microVersion && $serviceType) {
150150
$clientOptions['headers']['OpenStack-API-Version'] = sprintf('%s %s', $serviceType, $microVersion);
151151
}
152152

src/Compute/v2/Params.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,8 @@ public function userId(): array
456456
return [
457457
'type' => self::STRING_TYPE,
458458
'sentAs' => 'user_id',
459-
'location' => self::QUERY
459+
'location' => self::QUERY,
460+
'description' => 'This allows administrative users to operate key-pairs of specified user ID. Requires micro version 2.10.'
460461
];
461462
}
462463

0 commit comments

Comments
 (0)