Various peer review updates

Author: haphan

samples/compute/v2/keypair/create_and_delete_keypair.php renamed to samples/compute/v2/keypairs/create.php

@@ -19,6 +19,5 @@
     'publicKey' => 'ssh-rsa AAAAB3NAAAAB3NAAAAB3NAAAAB3NAAAAB3NAAAAB3NAAAAB3NAAAAB3NAAAAB3NAAAAB3N'
 ];
 
+/** @var \OpenStack\Compute\v2\Models\Keypair $keypair */
 $keypair = $compute->createKeypair($data);
-
-$keypair->delete();

samples/compute/v2/keypairs/delete.php

@@ -0,0 +1,20 @@
+<?php
+
+require 'vendor/autoload.php';
+
+$openstack = new OpenStack\OpenStack([
+    'authUrl' => '{authUrl}',
+    'region'  => '{region}',
+    'user'    => [
+        'id'       => '{userId}',
+        'password' => '{password}'
+    ],
+    'scope'   => ['project' => ['id' => '{projectId}']]
+]);
+
+$compute = $openstack->computeV2(['region' => '{region}']);
+
+/** @var \OpenStack\Compute\v2\Models\Keypair $keypair */
+$keypair = $compute->getKeypair(['name' => 'name_of_keypair']);
+
+$keypair->delete();

samples/compute/v2/servers/add_remove_security_group.php renamed to samples/compute/v2/servers/add_security_group.php.php

@@ -14,9 +14,9 @@
 
 $compute = $openstack->computeV2(['region' => '{region}']);
 
+/**@var OpenStack\Compute\v2\Models\Server $server */
 $server = $compute->getServer([
     'id' => '{serverId}',
 ]);
 
 $server->addSecurityGroup(['name' => 'secgroup name']);
-$server->removeSecurityGroup(['name' => 'default']);

samples/compute/v2/servers/attach_detach_volume_attachment.php renamed to samples/compute/v2/servers/attach_volume_attachment.php

@@ -18,11 +18,8 @@
 
 $compute = $openstack->computeV2(['region' => '{region}']);
 
+/**@var OpenStack\Compute\v2\Models\Server $server */
 $server = $compute->getServer(['id' => 'uuid']);
 
 /**@var VolumeAttachment $volumeAttachment*/
 $volumeAttachment = $server->attachVolume('{volume_uuid}');
-
-
-//Must detach by volumeAttachment id
-$server->detachVolume($volumeAttachment->id);

samples/compute/v2/servers/create_server.php

@@ -26,4 +26,5 @@
 ];
 
 // Create the server
+/**@var OpenStack\Compute\v2\Models\Server $server */
 $server = $compute->createServer($options);

samples/compute/v2/servers/delete_server.php

@@ -14,6 +14,7 @@
 
 $compute = $openstack->computeV2(['region' => '{region}']);
 
+/**@var OpenStack\Compute\v2\Models\Server $server */
 $server = $compute->getServer(['id' => '{serverId}']);
 
 $server->delete();

samples/compute/v2/servers/dettach_volume_attachment.php

@@ -0,0 +1,25 @@
+<?php
+
+use OpenStack\BlockStorage\v2\Models\VolumeAttachment;
+use OpenStack\Networking\v2\Extensions\SecurityGroups\Models\SecurityGroup;
+use OpenStack\Networking\v2\Extensions\SecurityGroups\Models\SecurityGroupRule;
+
+require 'vendor/autoload.php';
+
+$openstack = new OpenStack\OpenStack([
+    'authUrl' => '{authUrl}',
+    'region'  => '{region}',
+    'user'    => [
+        'id'       => '{userId}',
+        'password' => '{password}'
+    ],
+    'scope'   => ['project' => ['id' => '{projectId}']]
+]);
+
+$compute = $openstack->computeV2(['region' => '{region}']);
+
+/**@var OpenStack\Compute\v2\Models\Server $server */
+$server = $compute->getServer(['id' => 'uuid']);
+
+//Must detach by volumeAttachment id
+$server->detachVolume($volumeAttachment->id);

samples/compute/v2/servers/list_security_groups.php

@@ -24,6 +24,5 @@
 
     foreach ($rules as $rule) {
         /**@var SecurityGroupRule $rule */
-        $rule->direction;
     }
 }

samples/compute/v2/servers/list_volume_attachments.php

@@ -22,5 +22,4 @@
 
 foreach ($server->listVolumeAttachments() as $volumeAttachment) {
     /**@var VolumeAttachment $volumeAttachment*/
-    print_r($volumeAttachment);
 }

samples/compute/v2/servers/remove_security_group.php.php

@@ -0,0 +1,22 @@
+<?php
+
+require 'vendor/autoload.php';
+
+$openstack = new OpenStack\OpenStack([
+    'authUrl' => '{authUrl}',
+    'region'  => '{region}',
+    'user'    => [
+        'id'       => '{userId}',
+        'password' => '{password}'
+    ],
+    'scope'   => ['project' => ['id' => '{projectId}']]
+]);
+
+$compute = $openstack->computeV2(['region' => '{region}']);
+
+/**@var OpenStack\Compute\v2\Models\Server $server */
+$server = $compute->getServer([
+    'id' => '{serverId}',
+]);
+
+$server->removeSecurityGroup(['name' => 'security group name']);