Skip to content

Commit 64f4ac7

Browse files
committed
Fixed integration tests
1 parent 7d1409b commit 64f4ac7

File tree

6 files changed

+22
-9
lines changed

6 files changed

+22
-9
lines changed

samples/images/v2/images/create.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
'diskFormat' => '{diskFormat}',
1919
'visibility' => '{visibility}',
2020
'minDisk' => 10,
21-
'protected' => true,
21+
'protected' => false,
2222
'minRam' => 10,
2323
]);
24+
25+
$image->uploadData(\GuzzleHttp\Psr7\Utils::streamFor('fake-image.img'));

samples/images/v2/members/add.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111

1212
$member = $openstack->imagesV2()
1313
->getImage('{imageId}')
14-
->addMember('{tenantId}');
14+
->addMember('{projectId}');

samples/images/v2/members/delete.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@
1111

1212
$openstack->imagesV2()
1313
->getImage('{imageId}')
14-
->getMember('{tenantId}')
14+
->getMember('{projectId}')
1515
->delete();

samples/images/v2/members/update_status.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@
1313

1414
$openstack->imagesV2()
1515
->getImage('{imageId}')
16-
->getMember('{tenantId}')
16+
->getMember('{projectId}')
1717
->updateStatus(Member::STATUS_ACCEPTED);

tests/integration/BlockStorage/v2/CoreTest.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,19 @@ public function runTests()
2828
{
2929
$this->startTimer();
3030

31+
$this->logger->info('-> Volumes');
3132
$this->volumes();
33+
$this->logger->info('-> Volume Types');
3234
$this->volumeTypes();
35+
$this->logger->info('-> Snapshots');
3336
$this->snapshots();
3437

3538
$this->outputTimeTaken();
3639
}
3740

3841
public function volumes()
3942
{
43+
$this->logStep('-> Volumes tests');
4044
$this->logStep('Creating volume type');
4145
$volumeType = $this->getService()->createVolumeType(['name' => $this->randomStr()]);
4246

@@ -88,6 +92,8 @@ public function volumes()
8892

8993
public function volumeTypes()
9094
{
95+
$this->logStep('-> Volumes Types tests');
96+
9197
$replacements = [
9298
'{name}' => $this->randomStr(),
9399
];
@@ -122,9 +128,11 @@ public function volumeTypes()
122128

123129
public function snapshots()
124130
{
131+
$this->logStep('-> Snapshot tests');
132+
125133
$this->logStep('Creating volume');
126134
$volume = $this->getService()->createVolume(['name' => $this->randomStr(), 'size' => 1]);
127-
$volume->waitUntilActive();
135+
$volume->waitUntil('available', 60);
128136

129137
$replacements = [
130138
'{volumeId}' => $volume->id,
@@ -137,7 +145,7 @@ public function snapshots()
137145
require_once $this->sampleFile($replacements, 'snapshots/create.php');
138146
$this->assertInstanceOf(Snapshot::class, $snapshot);
139147
$this->assertEquals($replacements['{name}'], $snapshot->name);
140-
$snapshot->waitUntilActive();
148+
$volume->waitUntil('available', 60);
141149

142150
$snapshotId = $snapshot->id;
143151
$replacements = ['{snapshotId}' => $snapshotId];

tests/integration/Images/v2/CoreTest.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,19 +67,22 @@ public function members()
6767
'{tag2}' => 'quantal',
6868
'{containerFormat}' => 'bare',
6969
'{diskFormat}' => 'qcow2',
70-
'{visibility}' => 'private',
70+
'{visibility}' => 'shared',
7171
'true' => 'false',
7272
];
7373

7474
$this->logStep('Creating image');
7575
/** @var Image $image */
7676
require_once $this->sampleFile($replacements, 'images/create.php');
7777

78-
$replacements = ['{imageId}' => $image->id];
78+
79+
80+
$this->logStep(sprintf('Image created with id=%s', $image->id));
7981

8082
$this->logStep('Adding member');
83+
$replacements += ['{imageId}' => $image->id];
8184
/** @var Member $member */
82-
require_once $this->sampleFile($replacements, 'members/add.php');
85+
require_once $this->sampleFile(['{imageId}' => $image->id, ], 'members/add.php');
8386
$this->assertInstanceOf(Member::class, $member);
8487

8588
$replacements += ['status' => Member::STATUS_REJECTED];

0 commit comments

Comments
 (0)