Merge pull request #140 from php-opencloud/improve-unit-tests

[rtr] Bump up unit tests code coverage

Author: Jamie Hannaford

tests/unit/BlockStorage/v2/Fixtures/GET_quota_set.resp

@@ -0,0 +1,10 @@
+HTTP/1.1 200 OK
+Content-Type: application/json
+
+{
+    "quota_set": {
+        "gigabytes": 1,
+        "snapshots": 2,
+        "volumes": 3
+    }
+}

tests/unit/BlockStorage/v2/Models/QuotaSetTest.php

@@ -0,0 +1,57 @@
+<?php
+
+namespace OpenStack\Test\BlockStorage\v2\Models;
+
+use GuzzleHttp\Psr7\Response;
+use OpenStack\BlockStorage\v2\Api;
+use OpenStack\BlockStorage\v2\Models\QuotaSet;
+use OpenStack\Test\TestCase;
+
+class QuotaSetTest extends TestCase
+{
+    /** @var QuotaSet */
+    private $quotaSet;
+
+    public function setUp()
+    {
+        parent::setUp();
+
+        $this->rootFixturesDir = dirname(__DIR__);
+
+        $this->quotaSet = new QuotaSet($this->client->reveal(), new Api());
+        $this->quotaSet->tenantId = 'tenant-foo';
+    }
+
+    public function test_it_retrieves()
+    {
+        $this->setupMock('GET', 'os-quota-sets/tenant-foo', [], [], 'GET_quota_set');
+
+        $this->quotaSet->retrieve();
+        $this->assertEquals(1, $this->quotaSet->gigabytes);
+        $this->assertEquals(2, $this->quotaSet->snapshots);
+        $this->assertEquals(3, $this->quotaSet->volumes);
+    }
+
+    public function test_it_updates()
+    {
+        $expectedJson = [
+            'quota_set' => [
+                'snapshots' => 2222,
+                'volumes'   => 1111,
+            ],
+        ];
+
+        $this->setupMock('PUT', 'os-quota-sets/tenant-foo', $expectedJson, [], 'GET_type');
+
+        $this->quotaSet->volumes = 1111;
+        $this->quotaSet->snapshots = 2222;
+        $this->quotaSet->update();
+    }
+
+    public function test_it_deletes()
+    {
+        $this->setupMock('DELETE', 'os-quota-sets/tenant-foo', null, [], new Response(204));
+
+        $this->quotaSet->delete();
+    }
+}

tests/unit/BlockStorage/v2/ServiceTest.php

@@ -4,6 +4,7 @@
 
 use GuzzleHttp\Psr7\Response;
 use OpenStack\BlockStorage\v2\Api;
+use OpenStack\BlockStorage\v2\Models\QuotaSet;
 use OpenStack\BlockStorage\v2\Models\Snapshot;
 use OpenStack\BlockStorage\v2\Models\Volume;
 use OpenStack\BlockStorage\v2\Models\VolumeType;
@@ -179,4 +180,19 @@ public function test_it_gets_a_snapshot()
         $this->assertInstanceOf(Snapshot::class, $snapshot);
         $this->assertEquals('snapshotId', $snapshot->id);
     }
+
+    public function test_it_gets_quota_set()
+    {
+        $this->client
+            ->request('GET', 'os-quota-sets/tenant-id-1234', ['headers' => []])
+            ->shouldBeCalled()
+            ->willReturn($this->getFixture('GET_quota_set'));
+
+        $quotaSet = $this->service->getQuotaSet('tenant-id-1234');
+
+        $this->assertInstanceOf(QuotaSet::class, $quotaSet);
+        $this->assertEquals(1, $quotaSet->gigabytes);
+        $this->assertEquals(2, $quotaSet->snapshots);
+        $this->assertEquals(3, $quotaSet->volumes);
+    }
 }

tests/unit/Compute/v2/Models/ServerTest.php

@@ -26,9 +26,6 @@ public function setUp()
         $this->server->id = 'serverId';
     }
 
-    /**
-     * @expectedException \RuntimeException
-     */
     public function test_it_creates()
     {
         $opts = [
@@ -45,12 +42,36 @@ public function test_it_creates()
 
         $this->setupMock('POST', 'servers', $expectedJson, [], 'server-post');
         $this->assertInstanceOf(Server::class, $this->server->create($opts));
+    }
 
+    public function test_it_creates_with_boot_from_volume()
+    {
         $opts = [
             'name'     => 'foo',
             'flavorId' => 'baz',
+            'blockDeviceMapping' => [['uuid' => 'aaaa-ddddd-bbbb-ccccc']]
         ];
-        $this->server->create($opts);
+
+        $expectedJson = ['server' => [
+            'name' => $opts['name'],
+            'flavorRef' => $opts['flavorId'],
+            'block_device_mapping_v2' => $opts['blockDeviceMapping']
+        ]];
+
+        $this->setupMock('POST', 'servers', $expectedJson, [], 'server-post');
+        $this->assertInstanceOf(Server::class, $this->server->create($opts));
+    }
+
+    /**
+     * @expectedException \RuntimeException
+     * @expectedExceptionMessage imageId or blockDeviceMapping.uuid must be set.
+     */
+    public function test_it_requires_image_id_or_volume_id_to_create_servers()
+    {
+        $this->server->create([
+            'name' => 'some-server-name',
+            'flavorId' => 'apple'
+        ]);
     }
 
     public function test_it_updates()

tests/unit/Compute/v2/ServiceTest.php

@@ -18,6 +18,7 @@
 
 class ServiceTest extends TestCase
 {
+    /** @var Service */
     private $service;
 
     public function setUp()