Fix [][] deep array false warning.

Author: dereuromark

.editorconfig

@@ -16,3 +16,6 @@ end_of_line = crlf
 [*.yml]
 indent_style = space
 indent_size = 2
+
+[*.neon]
+indent_style = space

PSR2R/Sniffs/Commenting/DocBlockReturnSelfSniff.php

@@ -75,12 +75,10 @@ public function process(File $phpCsFile, $stackPointer) {
 		}
 	}
 
-	/** @noinspection MoreThanThreeArgumentsInspection */
-
 	/**
 	 * @param \PHP_CodeSniffer\Files\File $phpCsFile
 	 * @param int $classNameIndex
-	 * @param array $parts
+	 * @param string[] $parts
 	 * @param string $appendix
 	 *
 	 * @return void

PSR2R/Sniffs/Commenting/FullyQualifiedClassNameInDocBlockSniff.php

@@ -111,7 +111,7 @@ protected function fixClassNames(File $phpCsFile, $classNameIndex, array $classN
 	/**
 	 * @param \PHP_CodeSniffer\Files\File $phpCsFile
 	 * @param int $classNameIndex
-	 * @param array &$classNames
+	 * @param string[] $classNames
 	 *
 	 * @return array
 	 */
@@ -122,9 +122,9 @@ protected function generateClassNameMap(File $phpCsFile, $classNameIndex, array
 			if (strpos($className, '\\') !== false) {
 				continue;
 			}
-			$arrayOfObject = false;
-			if (substr($className, -2) === '[]') {
-				$arrayOfObject = true;
+			$arrayOfObject = 0;
+			while (substr($className, -2) === '[]') {
+				$arrayOfObject++;
 				$className = substr($className, 0, -2);
 			}
 			if (in_array($className, static::$whitelistedTypes)) {
@@ -139,8 +139,8 @@ protected function generateClassNameMap(File $phpCsFile, $classNameIndex, array
 				$phpCsFile->addError(sprintf($message, $className), $classNameIndex, 'ClassNameInvalid');
 				continue;
 			}
-			$classNames[$key] = $useStatement . ($arrayOfObject ? '[]' : '');
-			$result[$className . ($arrayOfObject ? '[]' : '')] = $classNames[$key];
+			$classNames[$key] = $useStatement . ($arrayOfObject ? str_repeat('[]', $arrayOfObject) : '');
+			$result[$className . ($arrayOfObject ? str_repeat('[]', $arrayOfObject) : '')] = $classNames[$key];
 		}
 
 		return $result;

PSR2R/Sniffs/ControlStructures/ConditionalExpressionOrderSniff.php

@@ -144,7 +144,7 @@ protected function detectRightEnd(File $phpCsFile, $index, $limit = 0) {
 	 * @param \PHP_CodeSniffer\Files\File $phpCsFile
 	 * @param int $index
 	 * @param int $leftIndexStart
-	 * @param int int $leftIndexEnd
+	 * @param int $leftIndexEnd
 	 * @param int $rightIndexStart
 	 * @param int $rightIndexEnd
 	 *
@@ -198,11 +198,9 @@ protected function getComparisonValue(array $token) {
 				T_IS_SMALLER_OR_EQUAL => '>=',
 			];
 			$comparisonIndexValue = $mapping[$token['code']];
-
-			return $comparisonIndexValue;
 		}
 
-		return $comparisonIndexValue;
+		return (int)$comparisonIndexValue;
 	}
 
 }

PSR2R/Sniffs/ControlStructures/NoInlineAssignmentSniff.php

@@ -92,7 +92,7 @@ protected function checkConditions($phpcsFile, $stackPtr) {
 	 * @param \PHP_CodeSniffer\Files\File $phpcsFile
 	 * @param int $startIndex
 	 * @param int $endIndex
-	 * @param int &$indexEqualSign
+	 * @param int $indexEqualSign
 	 *
 	 * @return bool
 	 */

composer.json

@@ -33,11 +33,13 @@
 	"scripts": {
 		"docs": "php docs/generate.php",
 		"docs-listing": "phpcs -e --standard=PSR2R/ruleset.xml",
-		"cs-check": "phpcs --standard=PSR2R/ruleset.xml -vs --ignore=psr2r-sniffer/vendor/,tests/files/,*.inc,*.fixed ./",
-		"cs-fix": "phpcbf --standard=PSR2R/ruleset.xml -v --ignore=psr2r-sniffer/vendor/,tests/files/,*.inc,*.fixed ./",
+		"cs-check": "phpcs --standard=PSR2R/ruleset.xml -p -s --ignore=psr2r-sniffer/vendor/,tests/files/,*.inc,*.fixed ./",
+		"cs-fix": "phpcbf --standard=PSR2R/ruleset.xml --ignore=psr2r-sniffer/vendor/,tests/files/,*.inc,*.fixed ./",
 		"test": "php phpunit.phar",
 		"test-setup": "[ ! -f phpunit.phar ] && wget https://phar.phpunit.de/phpunit-5.7.phar && mv phpunit-5.7.phar phpunit.phar || true",
 		"test-setup-mac": "[ ! -f phpunit.phar ] && curl -OL https://phar.phpunit.de/phpunit-5.7.phar && mv phpunit-5.7.phar phpunit.phar || true",
-		"test-coverage": "php phpunit.phar --log-junit tmp/coverage/unitreport.xml --coverage-html tmp/coverage --coverage-clover tmp/coverage/coverage.xml"
+		"test-coverage": "php phpunit.phar --log-junit tmp/coverage/unitreport.xml --coverage-html tmp/coverage --coverage-clover tmp/coverage/coverage.xml",
+		"phpstan": "phpstan analyse -c tests/phpstan.neon -l 4 PSR2R/",
+		"phpstan-setup": "cp composer.json composer.backup && composer require --dev phpstan/phpstan-shim:^0.11 && mv composer.backup composer.json"
 	}
 }

tests/phpstan.neon

@@ -0,0 +1,7 @@
+parameters:
+    autoload_files:
+        - %rootDir%/../../../tests/phpstan_bootstrap.php
+    excludes_analyse:
+        - %currentWorkingDirectory%/PSR2R/Tools/Sniffer.php
+    ignoreErrors:
+        - '#Empty array passed to foreach.#'

tests/phpstan_bootstrap.php

@@ -0,0 +1,8 @@
+<?php
+
+require dirname(__DIR__) . '/vendor/autoload.php';
+$manualAutoload = dirname(__DIR__) . '/vendor/squizlabs/php_codesniffer/autoload.php';
+if (!class_exists(\PHP_CodeSniffer\Config::class) && file_exists($manualAutoload)) {
+	require $manualAutoload;
+}
+\PHP_CodeSniffer\Autoload::load('PHP_CodeSniffer\Util\Tokens');