Reorganize library tests

Author: SerafimArts

composer.json

@@ -29,10 +29,8 @@
         }
     },
     "require-dev": {
-        "ffi/env": "^0.1|^1.0",
-        "ffi/location": "^0.1|^1.0",
-        "vimeo/psalm": "^4.22.0",
-        "phpunit/phpunit": "^9.5.15"
+        "ffi-headers/testing": "^1.0",
+        "vimeo/psalm": "^4.22"
     },
     "autoload-dev": {
         "psr-4": {

tests/BinaryCompatibilityTestCase.php

@@ -11,24 +11,18 @@
 
 namespace FFI\Headers\Bass\Tests;
 
-use FFI\Env\Runtime;
 use FFI\Headers\Bass;
 use FFI\Headers\Bass\Platform;
-use FFI\Headers\Bass\Tests\BinaryCompatibilityTestCase\Downloader;
 use FFI\Headers\Bass\Version;
+use FFI\Headers\Testing\Downloader;
 
-/**
- * @requires extension ffi
- */
 class BinaryCompatibilityTestCase extends TestCase
 {
-    public function setUp(): void
+    private function skipIfPlatformNotSupported(Version $version, Platform $platform): void
     {
-        if (!Runtime::isAvailable()) {
-            $this->markTestSkipped('An ext-ffi extension must be available and enabled');
+        if (!$version->supportedOn($platform)) {
+            $this->markTestSkipped($platform->name . ' not supported by version ' . $version->toString());
         }
-
-        parent::setUp();
     }
 
     /**
@@ -37,23 +31,16 @@ public function setUp(): void
      */
     public function testLinuxBinaryCompatibility(Version $version): void
     {
-        if (!$version->supportedOn(Platform::LINUX)) {
-            $this->markTestSkipped('Linux not supported by version ' . $version->toString());
-        }
-
-        $binary = __DIR__ . '/storage/libbass-' . $version->toString() . '.so';
+        $this->skipIfPlatformNotSupported($version, Platform::LINUX);
 
-        if (!\is_file($binary)) {
-            Downloader::download('https://www.un4seen.com/files/bass%s-linux.zip', [
+        if (!\is_file($binary = __DIR__ . '/storage/libbass-' . $version->toString() . '.so')) {
+            Downloader::zip('https://www.un4seen.com/files/bass%s-linux.zip', [
                 \str_replace('.', '', $version->toString()),
             ])
                 ->extract('x64/libbass.so', $binary);
         }
 
-        $this->expectNotToPerformAssertions();
-        $headers = (string)Bass::create(Platform::LINUX, $version);
-
-        \FFI::cdef($headers, $binary);
+        $this->assertHeadersCompatibleWith(Bass::create(Platform::LINUX, $version), $binary);
     }
 
     /**
@@ -62,10 +49,8 @@ public function testLinuxBinaryCompatibility(Version $version): void
      */
     public function testWindowsBinaryCompatibility(Version $version): void
     {
-        $binary = __DIR__ . '/storage/bass-' . $version->toString() . '.dll';
-
-        if (!\is_file($binary)) {
-            $result = Downloader::download('https://www.un4seen.com/files/bass%s.zip', [
+        if (!\is_file($binary = __DIR__ . '/storage/bass-' . $version->toString() . '.dll')) {
+            $result = Downloader::zip('https://www.un4seen.com/files/bass%s.zip', [
                 \str_replace('.', '', $version->toString()),
             ]);
 
@@ -80,10 +65,7 @@ public function testWindowsBinaryCompatibility(Version $version): void
             }
         }
 
-        $this->expectNotToPerformAssertions();
-        $headers = (string)Bass::create(Platform::WINDOWS, $version);
-
-        \FFI::cdef($headers, $binary);
+        $this->assertHeadersCompatibleWith(Bass::create(Platform::WINDOWS, $version), $binary);
     }
 
     /**
@@ -92,14 +74,10 @@ public function testWindowsBinaryCompatibility(Version $version): void
      */
     public function testDarwinBinaryCompatibility(Version $version): void
     {
-        if (!$version->supportedOn(Platform::DARWIN)) {
-            $this->markTestSkipped('OSX not supported by version ' . $version->toString());
-        }
+        $this->skipIfPlatformNotSupported($version, Platform::DARWIN);
 
-        $binary = __DIR__ . '/storage/libbass-' . $version->toString() . '.dylib';
-
-        if (!\is_file($binary)) {
-            $result = Downloader::download('https://www.un4seen.com/files/bass%s-osx.zip', [
+        if (!\is_file($binary = __DIR__ . '/storage/libbass-' . $version->toString() . '.dylib')) {
+            $result = Downloader::zip('https://www.un4seen.com/files/bass%s-osx.zip', [
                 \str_replace('.', '', $version->toString()),
             ]);
 
@@ -114,9 +92,6 @@ public function testDarwinBinaryCompatibility(Version $version): void
             }
         }
 
-        $this->expectNotToPerformAssertions();
-        $headers = (string)Bass::create(Platform::DARWIN, $version);
-
-        \FFI::cdef($headers, $binary);
+        $this->assertHeadersCompatibleWith(Bass::create(Platform::DARWIN, $version), $binary);
     }
 }

tests/BinaryCompatibilityTestCase/Downloader.php

@@ -32,4 +32,20 @@ public function testRenderable(Platform $platform, Version $version): void
 
         (string)Bass::create($platform, $version);
     }
+
+    /**
+     * @testdox Testing that headers contain correct syntax
+     *
+     * @dataProvider configDataProvider
+     */
+    public function testCompilation(Platform $platform, Version $version): void
+    {
+        if (!$platform->supportedBy($version)) {
+            $this->expectExceptionMessage('not supported by version');
+        }
+
+        $this->assertHeadersSyntaxValid(
+            Bass::create($platform, $version)
+        );
+    }
 }

tests/BinaryCompatibilityTestCase/DownloaderResult.php

@@ -13,10 +13,13 @@
 
 use FFI\Headers\Bass\Platform;
 use FFI\Headers\Bass\Version;
+use FFI\Headers\Testing\TestingTrait;
 use PHPUnit\Framework\TestCase as BaseTestCase;
 
 abstract class TestCase extends BaseTestCase
 {
+    use TestingTrait;
+
     /**
      * @return array<array{Platform, Version}>
      */