Skip to content

Commit 9b6608c

Browse files
committed
Fixed config:dump-reference, fixed PHPUnit deprecated warning (#477)
1 parent 74b63c0 commit 9b6608c

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

DependencyInjection/OldSoundRabbitMqExtension.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public function load(array $configs, ContainerBuilder $container)
4040
$loader = new XmlFileLoader($this->container, new FileLocator(array(__DIR__ . '/../Resources/config')));
4141
$loader->load('rabbitmq.xml');
4242

43-
$configuration = new Configuration($this->getAlias());
43+
$configuration = $this->getConfiguration($configs, $container);
4444
$this->config = $this->processConfiguration($configuration, $configs);
4545

4646
$this->collectorEnabled = $this->config['enable_collector'];
@@ -69,6 +69,11 @@ public function load(array $configs, ContainerBuilder $container)
6969
}
7070
}
7171

72+
public function getConfiguration(array $config, ContainerBuilder $container)
73+
{
74+
return new Configuration($this->getAlias());
75+
}
76+
7277
protected function loadConnections()
7378
{
7479
foreach ($this->config['connections'] as $key => $connection) {

Tests/RabbitMq/RpcClientTest.php

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace OldSound\RabbitMqBundle\Tests\RabbitMq;
44

55
use OldSound\RabbitMqBundle\RabbitMq\RpcClient;
6+
use PhpAmqpLib\Message\AMQPMessage;
67

78
class RpcClientTest extends \PHPUnit_Framework_TestCase
89
{
@@ -13,16 +14,22 @@ public function testProcessMessageWithCustomUnserializer()
1314
->setMethods(array('sendReply', 'maybeStopConsumer'))
1415
->disableOriginalConstructor()
1516
->getMock();
16-
$message = $this->getMockBuilder('\PhpAmqpLib\Message\AMQPMessage')->setMethods(array('get'))->setConstructorArgs(array('message'))->getMock();
17-
$serializer = $this->getMockBuilder('\Symfony\Component\Serializer\SerializerInterface')->setMethods(array('serialize', 'deserialize'))->getMock();
17+
/** @var AMQPMessage $message */
18+
$message = $this->getMockBuilder('\PhpAmqpLib\Message\AMQPMessage')
19+
->setMethods(array('get'))
20+
->setConstructorArgs(array('message'))
21+
->getMock();
22+
$serializer = $this->getMockBuilder('\Symfony\Component\Serializer\SerializerInterface')
23+
->setMethods(array('serialize', 'deserialize'))
24+
->getMock();
1825
$serializer->expects($this->once())->method('deserialize')->with('message', 'json', null);
1926
$client->initClient(true);
2027
$client->setUnserializer(function($data) use ($serializer) {
2128
$serializer->deserialize($data, 'json', null);
2229
});
2330
$client->processMessage($message);
2431
}
25-
32+
2633
public function testProcessMessageWithNotifyMethod()
2734
{
2835
/** @var RpcClient $client */
@@ -31,7 +38,11 @@ public function testProcessMessageWithNotifyMethod()
3138
->disableOriginalConstructor()
3239
->getMock();
3340
$expectedNotify = 'message';
34-
$message = $this->getMock('\PhpAmqpLib\Message\AMQPMessage', array('get'), array($expectedNotify));
41+
/** @var AMQPMessage $message */
42+
$message = $this->getMockBuilder('\PhpAmqpLib\Message\AMQPMessage')
43+
->setMethods(array('get'))
44+
->setConstructorArgs(array($expectedNotify))
45+
->getMock();
3546
$notified = false;
3647
$client->notify(function ($message) use (&$notified) {
3748
$notified = $message;

0 commit comments

Comments
 (0)