Improve code style (#685)

* use php-cs-fixer to migrate code to php 7.4

* Apply php-cs-fixer changes

Co-authored-by: mihaileu <mihaileu@users.noreply.github.com>

Author: mihaileu

.php-cs-fixer.dist.php

@@ -37,6 +37,7 @@
 $config
     ->setRiskyAllowed(true)
     ->setRules([
+        '@PHP74Migration' => true,
         '@PSR12' => true,
     ])
     ->setFinder($finder)

Command/BaseConsumerCommand.php

@@ -81,9 +81,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 throw new \BadFunctionCallException("Function 'pcntl_signal' is referenced in the php.ini 'disable_functions' and can't be called.");
             }
 
-            pcntl_signal(SIGTERM, array(&$this, 'stopConsumer'));
-            pcntl_signal(SIGINT, array(&$this, 'stopConsumer'));
-            pcntl_signal(SIGHUP, array(&$this, 'restartConsumer'));
+            pcntl_signal(SIGTERM, [&$this, 'stopConsumer']);
+            pcntl_signal(SIGINT, [&$this, 'stopConsumer']);
+            pcntl_signal(SIGHUP, [&$this, 'restartConsumer']);
         }
 
         if (defined('AMQP_DEBUG') === false) {

Command/BatchConsumerCommand.php

@@ -67,8 +67,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 throw new \BadFunctionCallException("Function 'pcntl_signal' is referenced in the php.ini 'disable_functions' and can't be called.");
             }
 
-            pcntl_signal(SIGTERM, array(&$this, 'stopConsumer'));
-            pcntl_signal(SIGINT, array(&$this, 'stopConsumer'));
+            pcntl_signal(SIGTERM, [&$this, 'stopConsumer']);
+            pcntl_signal(SIGINT, [&$this, 'stopConsumer']);
         }
 
         if (defined('AMQP_DEBUG') === false) {

Command/SetupFabricCommand.php

@@ -28,7 +28,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $partsHolder = $this->getContainer()->get('old_sound_rabbit_mq.parts_holder');
 
-        foreach (array('base_amqp', 'binding') as $key) {
+        foreach (['base_amqp', 'binding'] as $key) {
             foreach ($partsHolder->getParts('old_sound_rabbit_mq.' . $key) as $baseAmqp) {
                 if ($baseAmqp instanceof DynamicConsumer) {
                     continue;

Command/StdInProducerCommand.php

@@ -58,7 +58,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 throw new \InvalidArgumentException(sprintf(
                     'Invalid payload format "%s", expecting one of: %s.',
                     $format,
-                    implode(', ', array(self::FORMAT_PHP, self::FORMAT_RAW))
+                    implode(', ', [self::FORMAT_PHP, self::FORMAT_RAW])
                 ));
         }
 

DataCollector/MessageDataCollector.php

@@ -18,7 +18,7 @@ class MessageDataCollector extends DataCollector
     public function __construct($channels)
     {
         $this->channels = $channels;
-        $this->data = array();
+        $this->data = [];
     }
 
     public function collect(Request $request, Response $response, \Throwable $exception = null)

DependencyInjection/Compiler/InjectEventDispatcherPass.php

@@ -30,9 +30,9 @@ public function process(ContainerBuilder $container)
             $definition = $container->getDefinition($id);
             $definition->addMethodCall(
                 'setEventDispatcher',
-                array(
-                    new Reference(self::EVENT_DISPATCHER_SERVICE_ID, ContainerInterface::IGNORE_ON_INVALID_REFERENCE)
-                )
+                [
+                    new Reference(self::EVENT_DISPATCHER_SERVICE_ID, ContainerInterface::IGNORE_ON_INVALID_REFERENCE),
+                ]
             );
         }
     }

DependencyInjection/Compiler/RegisterPartsPass.php

@@ -18,7 +18,7 @@ public function process(ContainerBuilder $container)
 
         $definition = $container->getDefinition('old_sound_rabbit_mq.parts_holder');
 
-        $tags = array(
+        $tags = [
             'old_sound_rabbit_mq.base_amqp',
             'old_sound_rabbit_mq.binding',
             'old_sound_rabbit_mq.producer',
@@ -28,11 +28,11 @@ public function process(ContainerBuilder $container)
             'old_sound_rabbit_mq.batch_consumer',
             'old_sound_rabbit_mq.rpc_client',
             'old_sound_rabbit_mq.rpc_server',
-        );
+        ];
 
         foreach ($tags as $tag) {
             foreach ($container->findTaggedServiceIds($tag) as $id => $attributes) {
-                $definition->addMethodCall('addPart', array($tag, new Reference($id)));
+                $definition->addMethodCall('addPart', [$tag, new Reference($id)]);
             }
         }
     }

DependencyInjection/Configuration.php

@@ -459,7 +459,7 @@ protected function addQueueNodeConfiguration(ArrayNodeDefinition $node)
                 ->scalarNode('ticket')->defaultNull()->end()
                 ->arrayNode('routing_keys')
                     ->prototype('scalar')->end()
-                    ->defaultValue(array())
+                    ->defaultValue([])
                 ->end()
             ->end()
         ;