Fix bug where items that came before their parents where reported as orphans, closes #18

Author: philipstanislaus

build/arrayToTree.js

@@ -243,6 +243,22 @@ describe('arrayToTree', () => {
       'Hint: prevent orphans to result in an error by passing the following option: { throwIfOrphans: false }')
   })
 
+  it('should not throw if no orphans exist and throwIfOrphans is true, but the order is different (see #18)', () => {
+    expect(arrayToTree([
+      { id: '2', parentId: 'root', foo: 'bar' },
+      { id: '1-1', parentId: '1', foo: 'bar' },
+      { id: '1', parentId: 'root', foo: 'bar' },
+      { id: 'root', parentId: null, bar: 'bar' },
+    ], { dataField: null, throwIfOrphans: true })).to.deep.equal([
+      { id: "root", parentId: null, bar: "bar", children: [
+        { id: "2", parentId: "root", foo: "bar", children: [] },
+        { id: "1", parentId: "root", foo: "bar", children: [
+          { id: "1-1", parentId: "1", foo: "bar", children: [] },
+        ]},
+      ]},
+    ])
+  })
+
   it('should work with empty inputs', () => {
     expect(arrayToTree([])).to.deep.equal([])
   })

build/arrayToTree.js.map

@@ -57,7 +57,7 @@ export function arrayToTree (items: Item[], config: Partial<Config> = {}): TreeI
     }
 
     // if we track orphans, delete this item from the orphan set if it is in it
-    if (orphanIds) { orphanIds.delete(parentId) }
+    if (orphanIds) { orphanIds.delete(itemId) }
 
     // add the current item's data to the item in the lookup table
     if (conf.dataField) {