Skip to content

Commit c90cd0b

Browse files
authored
fix: implement workaround for changesets to properly replace workspace: references in package.json (#98)
1 parent 0186930 commit c90cd0b

File tree

6 files changed

+96
-6
lines changed

6 files changed

+96
-6
lines changed

.changeset/calm-cups-swim.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@phantom/browser-sdk": patch
3+
"@phantom/react-sdk": patch
4+
---
5+
6+
Fixed publishing with woekspace: references

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,7 @@ node_modules
1919
**/.DS_Store
2020
.eslintcache
2121
**/.eslintcache
22+
23+
# release workaround for changesets
24+
_release
25+
**/_release

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@
44
"packageManager": "yarn@4.2.2",
55
"scripts": {
66
"build": "yarn workspaces foreach --all --topological-dev run build",
7+
"pack-release": "yarn workspaces foreach --all --topological-dev run pack-release",
78
"format:fix": "prettier . --write",
89
"format:check": "prettier . --check",
910
"lint": "yarn workspaces foreach -Avpi run lint",
10-
"release": "yarn build && yarn changeset publish --publish-args=\"--yarn\"",
11+
"release": "yarn build && yarn pack-release && yarn changeset publish",
1112
"test": "jest"
1213
},
1314
"workspaces": [
@@ -31,6 +32,7 @@
3132
"jest": "^29.7.0",
3233
"jest-environment-jsdom": "^29.7.0",
3334
"prettier": "^3.5.2",
35+
"rimraf": "^6.0.1",
3436
"ts-jest": "^29",
3537
"typescript": "^5.8.3"
3638
}

packages/browser-sdk/package.json

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@
2121
],
2222
"license": "MIT",
2323
"scripts": {
24-
"build": "rm -rf dist && tsup src/index.ts src/solana/index.ts --format cjs,esm --dts",
25-
"build:watch": "rm -rf dist && tsup src/index.ts src/solana/index.ts --format cjs,esm --dts --watch",
26-
"dev": "rm -rf dist && tsup src/index.ts src/solana/index.ts --format cjs,esm --dts --watch",
24+
"?pack-release": "When https://github.com/changesets/changesets/issues/432 has a solution we can remove this trick",
25+
"pack-release": "rimraf ./_release && yarn pack && mkdir ./_release && tar zxvf ./package.tgz --directory ./_release && rm ./package.tgz",
26+
"build": "rimraf ./dist && tsup src/index.ts src/solana/index.ts --format cjs,esm --dts",
27+
"build:watch": "rimraf ./dist && tsup src/index.ts src/solana/index.ts --format cjs,esm --dts --watch",
28+
"dev": "rimraf ./dist && tsup src/index.ts src/solana/index.ts --format cjs,esm --dts --watch",
2729
"lint": "tsc --noEmit && eslint --cache . --ext .ts,.tsx",
2830
"test": "jest"
2931
},
@@ -32,12 +34,16 @@
3234
"@types/jest": "^29.5.14",
3335
"eslint": "8.53.0",
3436
"jest": "^29.7.0",
37+
"rimraf": "^6.0.1",
3538
"tsup": "^6.7.0",
3639
"typescript": "^5.0.4"
3740
},
3841
"dependencies": {
3942
"@solana/compat": "2.1.1",
4043
"@solana/kit": "^2.1.1",
4144
"@solana/transactions": "^2.1.1"
45+
},
46+
"publishConfig": {
47+
"directory": "_release/package"
4248
}
4349
}

packages/react-sdk/package.json

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@
2121
],
2222
"license": "MIT",
2323
"scripts": {
24-
"build": "rm -rf dist && tsup src/index.ts src/solana/index.ts --format cjs,esm --dts",
25-
"dev": "rm -rf dist && tsup src/index.ts src/solana/index.ts --format cjs,esm --dts --watch",
24+
"build": "rimraf ./dist && tsup src/index.ts src/solana/index.ts --format cjs,esm --dts",
25+
"?pack-release": "When https://github.com/changesets/changesets/issues/432 has a solution we can remove this trick",
26+
"pack-release": "rimraf ./_release && yarn pack && mkdir ./_release && tar zxvf ./package.tgz --directory ./_release && rm ./package.tgz",
27+
"dev": "rimraf ./dist && tsup src/index.ts src/solana/index.ts --format cjs,esm --dts --watch",
2628
"lint": "tsc --noEmit && eslint --cache . --ext .ts,.tsx",
2729
"test": "jest"
2830
},
@@ -40,11 +42,15 @@
4042
"jest-environment-jsdom": "^29.7.0",
4143
"react": "18.2.0",
4244
"react-dom": "18.2.0",
45+
"rimraf": "^6.0.1",
4346
"ts-jest": "^29",
4447
"tsup": "^6.7.0",
4548
"typescript": "^5.0.4"
4649
},
4750
"peerDependencies": {
4851
"react": ">=18.0.0"
52+
},
53+
"publishConfig": {
54+
"directory": "_release/package"
4955
}
5056
}

yarn.lock

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1542,6 +1542,7 @@ __metadata:
15421542
"@types/jest": "npm:^29.5.14"
15431543
eslint: "npm:8.53.0"
15441544
jest: "npm:^29.7.0"
1545+
rimraf: "npm:^6.0.1"
15451546
tsup: "npm:^6.7.0"
15461547
typescript: "npm:^5.0.4"
15471548
languageName: unknown
@@ -1580,6 +1581,7 @@ __metadata:
15801581
jest-environment-jsdom: "npm:^29.7.0"
15811582
react: "npm:18.2.0"
15821583
react-dom: "npm:18.2.0"
1584+
rimraf: "npm:^6.0.1"
15831585
ts-jest: "npm:^29"
15841586
tsup: "npm:^6.7.0"
15851587
typescript: "npm:^5.0.4"
@@ -1608,6 +1610,7 @@ __metadata:
16081610
jest: "npm:^29.7.0"
16091611
jest-environment-jsdom: "npm:^29.7.0"
16101612
prettier: "npm:^3.5.2"
1613+
rimraf: "npm:^6.0.1"
16111614
ts-jest: "npm:^29"
16121615
typescript: "npm:^5.8.3"
16131616
languageName: unknown
@@ -5198,6 +5201,22 @@ __metadata:
51985201
languageName: node
51995202
linkType: hard
52005203

5204+
"glob@npm:^11.0.0":
5205+
version: 11.0.2
5206+
resolution: "glob@npm:11.0.2"
5207+
dependencies:
5208+
foreground-child: "npm:^3.1.0"
5209+
jackspeak: "npm:^4.0.1"
5210+
minimatch: "npm:^10.0.0"
5211+
minipass: "npm:^7.1.2"
5212+
package-json-from-dist: "npm:^1.0.0"
5213+
path-scurry: "npm:^2.0.0"
5214+
bin:
5215+
glob: dist/esm/bin.mjs
5216+
checksum: 10c0/49f91c64ca882d5e3a72397bd45a146ca91fd3ca53dafb5254daf6c0e83fc510d39ea66f136f9ac7ca075cdd11fbe9aaa235b28f743bd477622e472f4fdc0240
5217+
languageName: node
5218+
linkType: hard
5219+
52015220
"glob@npm:^7.1.3, glob@npm:^7.1.4":
52025221
version: 7.2.3
52035222
resolution: "glob@npm:7.2.3"
@@ -5997,6 +6016,15 @@ __metadata:
59976016
languageName: node
59986017
linkType: hard
59996018

6019+
"jackspeak@npm:^4.0.1":
6020+
version: 4.1.1
6021+
resolution: "jackspeak@npm:4.1.1"
6022+
dependencies:
6023+
"@isaacs/cliui": "npm:^8.0.2"
6024+
checksum: 10c0/84ec4f8e21d6514db24737d9caf65361511f75e5e424980eebca4199f400874f45e562ac20fa8aeb1dd20ca2f3f81f0788b6e9c3e64d216a5794fd6f30e0e042
6025+
languageName: node
6026+
linkType: hard
6027+
60006028
"jake@npm:^10.8.5":
60016029
version: 10.9.2
60026030
resolution: "jake@npm:10.9.2"
@@ -6787,6 +6815,13 @@ __metadata:
67876815
languageName: node
67886816
linkType: hard
67896817

6818+
"lru-cache@npm:^11.0.0":
6819+
version: 11.1.0
6820+
resolution: "lru-cache@npm:11.1.0"
6821+
checksum: 10c0/85c312f7113f65fae6a62de7985348649937eb34fb3d212811acbf6704dc322a421788aca253b62838f1f07049a84cc513d88f494e373d3756514ad263670a64
6822+
languageName: node
6823+
linkType: hard
6824+
67906825
"lru-cache@npm:^5.1.1":
67916826
version: 5.1.1
67926827
resolution: "lru-cache@npm:5.1.1"
@@ -6903,6 +6938,15 @@ __metadata:
69036938
languageName: node
69046939
linkType: hard
69056940

6941+
"minimatch@npm:^10.0.0":
6942+
version: 10.0.1
6943+
resolution: "minimatch@npm:10.0.1"
6944+
dependencies:
6945+
brace-expansion: "npm:^2.0.1"
6946+
checksum: 10c0/e6c29a81fe83e1877ad51348306be2e8aeca18c88fdee7a99df44322314279e15799e41d7cb274e4e8bb0b451a3bc622d6182e157dfa1717d6cda75e9cd8cd5d
6947+
languageName: node
6948+
linkType: hard
6949+
69066950
"minimatch@npm:^3.0.4, minimatch@npm:^3.0.5, minimatch@npm:^3.1.1, minimatch@npm:^3.1.2":
69076951
version: 3.1.2
69086952
resolution: "minimatch@npm:3.1.2"
@@ -7462,6 +7506,16 @@ __metadata:
74627506
languageName: node
74637507
linkType: hard
74647508

7509+
"path-scurry@npm:^2.0.0":
7510+
version: 2.0.0
7511+
resolution: "path-scurry@npm:2.0.0"
7512+
dependencies:
7513+
lru-cache: "npm:^11.0.0"
7514+
minipass: "npm:^7.1.2"
7515+
checksum: 10c0/3da4adedaa8e7ef8d6dc4f35a0ff8f05a9b4d8365f2b28047752b62d4c1ad73eec21e37b1579ef2d075920157856a3b52ae8309c480a6f1a8bbe06ff8e52b33c
7516+
languageName: node
7517+
linkType: hard
7518+
74657519
"path-type@npm:^4.0.0":
74667520
version: 4.0.0
74677521
resolution: "path-type@npm:4.0.0"
@@ -7964,6 +8018,18 @@ __metadata:
79648018
languageName: node
79658019
linkType: hard
79668020

8021+
"rimraf@npm:^6.0.1":
8022+
version: 6.0.1
8023+
resolution: "rimraf@npm:6.0.1"
8024+
dependencies:
8025+
glob: "npm:^11.0.0"
8026+
package-json-from-dist: "npm:^1.0.0"
8027+
bin:
8028+
rimraf: dist/esm/bin.mjs
8029+
checksum: 10c0/b30b6b072771f0d1e73b4ca5f37bb2944ee09375be9db5f558fcd3310000d29dfcfa93cf7734d75295ad5a7486dc8e40f63089ced1722a664539ffc0c3ece8c6
8030+
languageName: node
8031+
linkType: hard
8032+
79678033
"rollup@npm:^3.2.5":
79688034
version: 3.29.5
79698035
resolution: "rollup@npm:3.29.5"

0 commit comments

Comments
 (0)