static link fftw in CI builds, fix compiler warnings

Author: phandasm

.github/workflows/main.yml

@@ -23,7 +23,7 @@ jobs:
           sudo apt-get install -y libobs-dev libfftw3-dev
       
       - name: 'Cmake'
-        run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=${{github.workspace}}/bin
+        run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=Release -DSTATIC_FFTW=ON -DCMAKE_INSTALL_PREFIX=${{github.workspace}}/bin
 
       - name: 'Build'
         working-directory: ${{github.workspace}}/build

CMakeLists.txt

@@ -18,6 +18,9 @@ if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
 endif()
 
 option(BUILD_SHARED_LIBS "Build shared libraries" OFF) # static link dependencies
+if(NOT MSVC)
+    option(STATIC_FFTW "Static link FFTW" OFF) # allow static linking FFTW on non-windows platforms
+endif()
 
 if(WIN32)
     list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
@@ -54,7 +57,11 @@ if(MSVC)
     set(FFTW_INCLUDE_DIRS "deps/fftw-3.3.10/api")
 else()
     find_path(FFTW_INCLUDE_DIRS fftw3.h)
-    find_library(FFTW_LIBRARIES fftw3f)
+    if(STATIC_FFTW)
+        find_library(FFTW_LIBRARIES libfftw3f.a)
+    else()
+        find_library(FFTW_LIBRARIES fftw3f)
+    endif()
     if(NOT FFTW_INCLUDE_DIRS)
         message(FATAL_ERROR "Could not locate FFTW header.")
     endif()

changelog.md

@@ -21,7 +21,6 @@ or
 ### Linux (Ubuntu 20.04)
 #### Prebuilt Binaries
 - Extract Waveform\_v#.#.#\_Ubuntu\_x64.tar.gz to your `~/.config/obs-studio/plugins` folder.  
-- Install FFTW `sudo apt-get install libfftw3-3`  
 
 #### Source Build
 - Step-by-step instructions in the [readme](https://github.com/phandasm/waveform/blob/master/README.md#linux-ubuntu-20043-lts).

src/source.cpp

@@ -764,7 +764,7 @@ void WAVSource::render_bars([[maybe_unused]] gs_effect_t *effect)
     const auto cpos = m_stereo ? center : bottom;
 
     auto max_steps = (size_t)(cpos / step_stride);
-    if(((int)cpos - (max_steps * step_stride)) >= m_step_width)
+    if(((int)cpos - (int)(max_steps * step_stride)) >= m_step_width)
         ++max_steps;
 
     // vertex buffer
@@ -880,7 +880,7 @@ void WAVSource::render_bars([[maybe_unused]] gs_effect_t *effect)
 
             if(m_display_mode == DisplayMode::STEPPED_BAR)
             {
-                for(auto j = 0; j < max_steps; ++j)
+                for(auto j = 0u; j < max_steps; ++j)
                 {
                     auto y1 = (float)(j * step_stride);
                     auto y2 = y1 + m_step_width;