Skip to content

Commit 750f56c

Browse files
authored
Merge pull request #16493 from kuhler-Stratege/manager-return-types
Added return type for Manager::getReusableRecords
2 parents 7212ba0 + 8793a7f commit 750f56c

File tree

6 files changed

+14
-12
lines changed

6 files changed

+14
-12
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Questions? Forum: https://phalcon.io/forum or Discord: https://phalcon.io/discor
1313
A clear and concise description of what the bug is.
1414

1515
**To Reproduce**
16-
> Provide output if related. Provide coredump if any. Use https://docs.phalcon.io/en/latest/generating-backtrace as reference.
16+
> Provide output if related. Provide coredump if any. Use https://docs.phalcon.io/latest/generating-backtrace as reference.
1717
1818
Steps to reproduce the behavior:
1919

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ Please report bugs when you've exhausted all of the above options.
3434
## Bug Report Checklist
3535

3636
* Make sure you are using the latest released version of Phalcon before submitting a bug report. Bugs in versions older than the latest released one will not be addressed by the core team (so long as the version is not LTS).
37-
* If you have found a bug it is important to add relevant reproducibility information to your issue to allow us to reproduce the bug and fix it quicker. Add a script, small program or repository providing the necessary code to make everyone reproduce the issue reported easily. If a bug cannot be reproduced by the development it would be difficult provide corrections and solutions. [Submit Reproducible Test](https://docs.phalcon.io/en/latest/reproducible-tests) for more information
37+
* If you have found a bug it is important to add relevant reproducibility information to your issue to allow us to reproduce the bug and fix it quicker. Add a script, small program or repository providing the necessary code to make everyone reproduce the issue reported easily. If a bug cannot be reproduced by the development it would be difficult provide corrections and solutions. [Submit Reproducible Test](https://docs.phalcon.io/latest/reproducible-tests/) for more information
3838
* Be sure that information such as OS, Phalcon version and PHP version are part of the bug report
39-
* If you're submitting a [Segmentation Fault](https://en.wikipedia.org/wiki/Segmentation_fault) error, we would require a backtrace, please see [Generating a Backtrace](https://docs.phalcon.io/en/latest/generating-backtrace)
39+
* If you're submitting a [Segmentation Fault](https://en.wikipedia.org/wiki/Segmentation_fault) error, we would require a backtrace, please see [Generating a Backtrace](https://docs.phalcon.io/latest/generating-backtrace)
4040

4141
## Pull Request Checklist
4242

@@ -48,7 +48,7 @@ Please report bugs when you've exhausted all of the above options.
4848

4949
## Requesting Features
5050

51-
If you have a change or new feature in mind, please fill a [NFR](https://docs.phalcon.io/en/latest/new-feature-request) on the GitHub. Alternatively you may also request features via [the FeatHub page](https://feathub.com/phalcon/cphalcon).
51+
If you have a change or new feature in mind, please fill a [NFR](https://docs.phalcon.io/latest/new-feature-request) on the GitHub. Alternatively you may also request features via [the FeatHub page](https://feathub.com/phalcon/cphalcon).
5252

5353

5454
Thanks!

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ You can either download a binary package for the system of your choice or build
2626

2727
## Installation
2828

29-
For detailed installation instructions you can check our [installation](https://docs.phalcon.io/5.0/installation) page in the docs.
29+
For detailed installation instructions you can check our [installation](https://docs.phalcon.io/latest/installation/) page in the docs.
3030

3131
## Generating API Documentation
3232

ext/phalcon/di/di.zep.c

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

phalcon/Di/Di.zep

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ class Di implements DiInterface
388388
* ];
389389
* ```
390390
*
391-
* @link https://docs.phalcon.io/en/latest/reference/di.html
391+
* @link https://docs.phalcon.io/latest/di/
392392
*/
393393
public function loadFromPhp(string! filePath) -> void
394394
{
@@ -430,7 +430,7 @@ class Di implements DiInterface
430430
* className: \Acme\User
431431
* ```
432432
*
433-
* @link https://docs.phalcon.io/en/latest/reference/di.html
433+
* @link https://docs.phalcon.io/latest/di/
434434
*/
435435
public function loadFromYaml(string! filePath, array! callbacks = null) -> void
436436
{

phalcon/Mvc/Model/Manager.zep

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1670,6 +1670,8 @@ class Manager implements ManagerInterface, InjectionAwareInterface, EventsAwareI
16701670
*
16711671
* @param string $modelName
16721672
* @param string $key
1673+
*
1674+
* @return mixed
16731675
*/
16741676
public function getReusableRecords(string! modelName, string! key)
16751677
{

0 commit comments

Comments
 (0)