Skip to content

MOB-typer in multi mode does not respect primary cluster mash distance? #183

@schorlton-bugseq

Description

@schorlton-bugseq

Thanks for all of your work on this tool! As per title, I think this comes down to:

In single mode, there is logic to handle mash distance > primary_cluster_dist:
https://github.com/phac-nml/mob-suite/blob/3.1.9/mob_suite/mob_typer.py#L502-L507

I couldn't find similar logic in multi mode (but let me know if I'm missing something!):
https://github.com/phac-nml/mob-suite/blob/3.1.9/mob_suite/mob_typer.py#L436

This leads to MOB-typer clusters with mash distance to nearest neighbour of 1, even when settings left at defaults.

I don't have capacity to fix soon but thought I could at least document as a first step. Thanks again!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions