From 00ec72d152bab1b93c070a382ac161e9a4cefec8 Mon Sep 17 00:00:00 2001 From: Katherine Thiessen Date: Thu, 9 Oct 2025 13:58:24 -0500 Subject: [PATCH 1/2] making project url required and announcing path & description errors --- app/views/projects/_project_namespace_fields.html.erb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/views/projects/_project_namespace_fields.html.erb b/app/views/projects/_project_namespace_fields.html.erb index 81ce167275..b523173d5f 100644 --- a/app/views/projects/_project_namespace_fields.html.erb +++ b/app/views/projects/_project_namespace_fields.html.erb @@ -57,7 +57,7 @@ end %>
<% selected_value = params.has_key?(:group_id) ? params[:group_id] : current_user.namespace.id %> - <%= viral_prefixed_select2(form: builder, name: :parent_id, id: form_id, selected_value: selected_value, placeholder: t(:"projects.new.select_namespace"), aria: { invalid: invalid_namespace, + <%= viral_prefixed_select2(form: builder, name: :parent_id, id: form_id, selected_value: selected_value, placeholder: t(:"projects.new.select_namespace"), aria: { required: true, invalid: invalid_namespace, describedby: [invalid_namespace ? builder.field_id(:namespace, "error") : nil, builder.field_id(:namespace, "hint")].join(" ") } ) do |select| %> <% authorized_namespaces.each do |namespace| %> <% select.with_option( @@ -115,6 +115,7 @@ end %> <% if invalid_path %> <%= render "shared/form/field_errors", + id: builder.field_id(:path, "error"), errors: @project.namespace.errors.full_messages_for(:path) %> <% end %> " class="field-hint"> @@ -144,6 +145,7 @@ end %> } %> <% if invalid_description %> <%= render "shared/form/field_errors", + id: builder.field_id(:description, "error"), errors: @project.namespace.errors.full_messages_for(:description) %> <% end %> " class="field-hint"> From f8080b896c5e443fad18d94e9ea3fba836d3cd78 Mon Sep 17 00:00:00 2001 From: Katherine Thiessen Date: Fri, 10 Oct 2025 15:07:47 -0500 Subject: [PATCH 2/2] making viral_prefixed_select2 required --- app/views/projects/_project_namespace_fields.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/projects/_project_namespace_fields.html.erb b/app/views/projects/_project_namespace_fields.html.erb index b523173d5f..f4a4a227f0 100644 --- a/app/views/projects/_project_namespace_fields.html.erb +++ b/app/views/projects/_project_namespace_fields.html.erb @@ -57,7 +57,7 @@ end %>
<% selected_value = params.has_key?(:group_id) ? params[:group_id] : current_user.namespace.id %> - <%= viral_prefixed_select2(form: builder, name: :parent_id, id: form_id, selected_value: selected_value, placeholder: t(:"projects.new.select_namespace"), aria: { required: true, invalid: invalid_namespace, + <%= viral_prefixed_select2(form: builder, name: :parent_id, id: form_id, selected_value: selected_value, placeholder: t(:"projects.new.select_namespace"), required: true, aria: { invalid: invalid_namespace, describedby: [invalid_namespace ? builder.field_id(:namespace, "error") : nil, builder.field_id(:namespace, "hint")].join(" ") } ) do |select| %> <% authorized_namespaces.each do |namespace| %> <% select.with_option(