Improved hamming_distance and jaccard_distance

Author: ankane

lib/pgvector/ecto/query.ex

@@ -45,7 +45,7 @@ if Code.ensure_loaded?(Ecto) do
     """
     defmacro hamming_distance(column, value) do
       quote do
-        fragment("(? <~> ?)", unquote(column), ^Pgvector.Ecto.Utils.to_bit_sql(unquote(value)))
+        fragment("(? <~> ?)", unquote(column), unquote(value))
       end
     end
 
@@ -54,7 +54,7 @@ if Code.ensure_loaded?(Ecto) do
     """
     defmacro jaccard_distance(column, value) do
       quote do
-        fragment("(? <%> ?)", unquote(column), ^Pgvector.Ecto.Utils.to_bit_sql(unquote(value)))
+        fragment("(? <%> ?)", unquote(column), unquote(value))
       end
     end
   end

lib/pgvector/ecto/utils.ex

@@ -13,8 +13,4 @@ defmodule Pgvector.Ecto.Utils do
   def to_sql(vector) do
     vector |> Pgvector.new()
   end
-
-  def to_bit_sql(vector) when is_bitstring(vector) do
-    vector
-  end
 end

test/ecto_test.exs

@@ -82,12 +82,12 @@ defmodule EctoTest do
   end
 
   test "bit hamming distance" do
-    items = Repo.all(from i in Item, order_by: hamming_distance(i.binary_embedding, <<1::1, 0::1, 1::1>>), limit: 5)
+    items = Repo.all(from i in Item, order_by: hamming_distance(i.binary_embedding, ^<<1::1, 0::1, 1::1>>), limit: 5)
     assert Enum.map(items, fn v -> v.id end) == [2, 3, 1]
   end
 
   test "bit jaccard distance" do
-    items = Repo.all(from i in Item, order_by: jaccard_distance(i.binary_embedding, <<1::1, 0::1, 1::1>>), limit: 5)
+    items = Repo.all(from i in Item, order_by: jaccard_distance(i.binary_embedding, ^<<1::1, 0::1, 1::1>>), limit: 5)
     assert Enum.map(items, fn v -> v.id end) == [2, 3, 1]
   end