fix sequence issues (#1587)

Co-authored-by: Klepov Alex <aklepov@rutube.ru>

Author: xelavopelk

qdb/etcdqdb.go

@@ -1848,7 +1848,7 @@ func (q *EtcdQDB) AlterSequenceDetachRelation(ctx context.Context, relName *rfqn
 		Str("relation", relName.RelationName).
 		Msg("etcdqdb: detach relation from sequence")
 
-	resp, err := q.cli.Delete(ctx, relationSequenceMappingNodePath(relName.RelationName))
+	resp, err := q.cli.Delete(ctx, relationSequenceMappingNodePath(relName.RelationName), clientv3.WithPrefix())
 	spqrlog.Zero.Debug().
 		Interface("response", resp).
 		Msg("etcdqdb: detach relation from sequence")
@@ -1861,7 +1861,7 @@ func (q *EtcdQDB) GetRelationSequence(ctx context.Context, relName *rfqn.Relatio
 		Msg("etcdqdb: get column sequence")
 
 	key := relationSequenceMappingNodePath(relName.RelationName)
-	resp, err := q.cli.Get(ctx, key)
+	resp, err := q.cli.Get(ctx, key, clientv3.WithPrefix())
 	if err != nil {
 		return nil, err
 	}

qdb/memqdb.go

@@ -1145,7 +1145,8 @@ func (q *MemQDB) DropSequence(ctx context.Context, seqName string, force bool) e
 		return nil
 	}
 
-	return ExecuteCommands(q.DumpState, NewDeleteCommand(q.Sequences, seqName))
+	return ExecuteCommands(q.DumpState, NewDeleteCommand(q.Sequences, seqName),
+		NewDeleteCommand(q.SequenceToValues, seqName))
 }
 
 func (q *MemQDB) GetRelationSequence(_ context.Context, relName *rfqn.RelationFQN) (map[string]string, error) {

qdb/memqdb_test.go

@@ -174,6 +174,34 @@ func TestMemQDB_GetAbsentDistribution(t *testing.T) {
 	assert.Error(err)
 }
 
+func TestDropReferenceRelation(t *testing.T) {
+
+	assert := assert.New(t)
+
+	memqdb, err := qdb.RestoreQDB(MemQDBPath)
+	assert.NoError(err)
+
+	ctx := context.TODO()
+	referenceRelation := &qdb.ReferenceRelation{
+		TableName:             "test2",
+		SchemaVersion:         1,
+		ColumnSequenceMapping: map[string]string{"id": "test2_id"},
+		ShardIds:              []string{"sh1", "sh2"},
+	}
+	err = memqdb.CreateReferenceRelation(ctx, referenceRelation)
+	assert.NoError(err)
+	err = memqdb.DropReferenceRelation(ctx, &rfqn.RelationFQN{RelationName: "test2"})
+	assert.NoError(err)
+	_, err = memqdb.GetReferenceRelation(ctx, &rfqn.RelationFQN{RelationName: "test2"})
+	assert.Error(err)
+	assert.Equal(0, len(memqdb.Sequences))
+	assert.Equal(0, len(memqdb.ColumnSequence))
+	assert.Equal(0, len(memqdb.SequenceToValues))
+	assert.Equal(0, len(memqdb.ReferenceRelations))
+
+	assert.NoError(memqdb.DropKeyRange(ctx, "nonexistentKeyRange"))
+}
+
 func TestKeyRanges(t *testing.T) {
 
 	assert := assert.New(t)

test/feature/features/sequence.feature

@@ -100,3 +100,48 @@ Feature: Sequence test
         }
     ]
     """
+
+  Scenario: Remove sequence
+    #
+    # Make host "coordinator" take control
+    #
+    Given cluster environment is
+    """
+    ROUTER_CONFIG=/spqr/test/feature/conf/router_cluster.yaml
+    """
+    Given cluster is up and running
+    And host "coordinator2" is stopped
+    And host "coordinator2" is started
+
+
+    When I run SQL on host "coordinator"
+    """
+    CREATE REFERENCE TABLE t AUTO INCREMENT id;
+    """
+    Then command return code should be "0"
+
+    When I run SQL on host "coordinator"
+    """
+    SHOW sequences;
+    """
+    Then command return code should be "0"
+    And SQL result should match json_exactly
+    """
+    [
+        {
+            "name": "t_id",
+            "value": "0"
+        }
+    ]
+    """
+
+    When I run SQL on host "coordinator"
+    """
+    DROP REFERENCE RELATION t;
+    SHOW sequences;
+    """
+    Then command return code should be "0"
+    And SQL result should match json_exactly
+    """
+    []
+    """