Protected constructor and static items

Author: Petr Knap

src/Enum/AbstractEnum.php

@@ -8,7 +8,7 @@
  * @author  Petr Knap <dev@petrknap.cz>
  * @since   2016-01-23
  * @package PetrKnap\Php\Enum
- * @version 0.1
+ * @version 0.2
  * @license https://github.com/petrknap/php-enum/blob/master/LICENSE MIT
  */
 abstract class AbstractEnum
@@ -19,9 +19,9 @@ abstract class AbstractEnum
     private static $instances;
 
     /**
-     * @var mixed[]
+     * @var mixed[][]
      */
-    private $items = [];
+    private static $items = [];
 
     /**
      * @var mixed
@@ -37,7 +37,7 @@ abstract class AbstractEnum
      * @param mixed $key
      * @throws EnumException
      */
-    public function __construct($key)
+    protected function __construct($key)
     {
         $this->key = $key;
         $this->value = $this->get($key);
@@ -88,9 +88,9 @@ public function getValue()
     /**
      * @param mixed[] $items
      */
-    protected function setItems(array $items)
+    protected static function setItems(array $items)
     {
-        $this->items = $items;
+        self::$items[get_called_class()] = $items;
     }
 
     /**
@@ -99,7 +99,7 @@ protected function setItems(array $items)
      */
     private function exists($key)
     {
-        return array_key_exists($key, $this->items);
+        return array_key_exists($key, self::$items[get_called_class()]);
     }
 
     /**
@@ -120,6 +120,6 @@ private function get($key)
             );
         }
 
-        return $this->items[$key];
+        return self::$items[get_called_class()][$key];
     }
 }

tests/Enum/EnumTest.php

@@ -17,35 +17,6 @@ public function wrongKeyProvider()
         return [["C"], ["D"]];
     }
 
-    /**
-     * @dataProvider goodKeyProvider
-     * @param string $key
-     * @param string $value
-     */
-    public function testEnumDirectConstruction_GoodKey($key, $value)
-    {
-        $enum = new EnumMock($key);
-
-        $this->assertInstanceOf(EnumMock::getClass(), $enum);
-        $this->assertSame($key, $enum->getKey());
-        $this->assertSame($value, $enum->getValue());
-    }
-
-    /**
-     * @dataProvider wrongKeyProvider
-     * @param string $key
-     */
-    public function testEnumDirectConstruction_WrongKey($key)
-    {
-        $this->setExpectedException(
-            get_class(new EnumException()),
-            "",
-            EnumException::OUT_OF_RANGE
-        );
-
-        new EnumMock($key);
-    }
-
     /**
      * @dataProvider goodKeyProvider
      * @param string $key

tests/Enum/EnumTest/EnumMock.php

@@ -10,9 +10,9 @@
  */
 class EnumMock extends AbstractEnum
 {
-    public function __construct($key)
+    protected function __construct($key)
     {
-        $this->setItems([
+        self::setItems([
             "A" => "a",
             "B" => "b"
         ]);