-
Notifications
You must be signed in to change notification settings - Fork 52
Closed
Description
Hello,
Thanks a lot for the awesome lib 👍
I've observed that PartialEq
is derived automatically. But that means that sets with different capacities are always considered different, even when having the same "elements" (in the sense of the values obtained with ones()
).
let a = FixedBitSet::with_capacity(0);
let b = FixedBitSet::with_capacity(1);
assert_ne!(a, b); // both are "empty", but considered different
Wouldn't it be better to consider sets that return the same values when iterated over with ones()
as equal, regardless of their internal capacities? That would be more in line with how the standard library works, for Vec
and other data structures.
This could arguably be a breaking change though, not sure the maintainers would be ok with this.
I'll be glad to work on a PR for this change if well received.
Best regards,
Metadata
Metadata
Assignees
Labels
No labels