Skip to content

Commit c5cbf29

Browse files
committed
Remove excess debugging logs
1 parent 9d62fc1 commit c5cbf29

File tree

2 files changed

+7
-21
lines changed

2 files changed

+7
-21
lines changed

ada_feeding/ada_feeding/idioms/servo_until.py

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import py_trees
2828
from py_trees.behaviours import UnsetBlackboardVariable
2929
from py_trees.blackboard import Blackboard
30-
import rclpy # TODO: remove!
3130
from rclpy.duration import Duration
3231
from rclpy.time import Time
3332
import ros2_numpy
@@ -151,17 +150,6 @@ def pose_within_tolerances(
151150
target_pose.pose.position
152151
) - ros2_numpy.numpify(current_pose.pose.position)
153152

154-
# TODO: remove!
155-
rclpy.logging.get_logger("pose_within_tolerances").info(
156-
f"linear_displacement: {linear_displacement}"
157-
)
158-
rclpy.logging.get_logger("pose_within_tolerances").info(
159-
f"target_pose: {ros2_numpy.numpify(target_pose.pose.position)}"
160-
)
161-
rclpy.logging.get_logger("pose_within_tolerances").info(
162-
f"current_pose: {ros2_numpy.numpify(current_pose.pose.position)}"
163-
)
164-
165153
linear_distance = np.linalg.norm(linear_displacement)
166154
if linear_distance > tolerance_position:
167155
return False
@@ -201,8 +189,7 @@ def servo_until_pose(
201189
ignore_orientation: bool = False,
202190
subscribe_to_servo_status: bool = True,
203191
pub_topic: str = "~/servo_twist_cmds",
204-
# TODO: change default to False!
205-
viz: bool = True,
192+
viz: bool = False,
206193
) -> py_trees.behaviour.Behaviour:
207194
"""
208195
Servos until the end_effector_frame reaches within the specified tolerances

ada_planning_scene/config/ada_planning_scene.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -151,12 +151,6 @@ ada_planning_scene:
151151
disable_workspace_wall_y_max: True # Remove the back wall, to be able to see in in RVIZ
152152
bedside:
153153
disable_workspace_wall_y_min: True # Remove the back wall, to be able to see in in RVIZ
154-
# TODO: remove!
155-
disable_workspace_wall_y_max: True # Remove the back wall, to be able to see in in RVIZ
156-
disable_workspace_wall_x_min: True # Remove the back wall, to be able to see in in RVIZ
157-
disable_workspace_wall_x_max: True # Remove the back wall, to be able to see in in RVIZ
158-
disable_workspace_wall_z_min: True # Remove the back wall, to be able to see in in RVIZ
159-
disable_workspace_wall_z_max: True # Remove the back wall, to be able to see in in RVIZ
160154

161155
# Whether the workspace walls should contain the robot's current configuration
162156
# at time of recomputation.
@@ -166,7 +160,12 @@ ada_planning_scene:
166160
# from it, to get the robot URDF
167161
get_urdf_parameter_service_name: "/move_group/get_parameters"
168162
urdf_parameter_name: "robot_description"
169-
163+
# TODO: remove!
164+
disable_workspace_wall_y_max: True # Remove the back wall, to be able to see in in RVIZ
165+
disable_workspace_wall_x_min: True # Remove the back wall, to be able to see in in RVIZ
166+
disable_workspace_wall_x_max: True # Remove the back wall, to be able to see in in RVIZ
167+
disable_workspace_wall_z_min: True # Remove the back wall, to be able to see in in RVIZ
168+
disable_workspace_wall_z_max: True # Remove the back wall, to be able to see in in RVIZ
170169
# The service that needs to be called, and parameters that need to be requested,
171170
# to get the robot joint positions that must be in the workspace walls. Note that
172171
# the parameter name is made by first getting the parameter value from the

0 commit comments

Comments
 (0)