Skip to content

Commit f5ba860

Browse files
committed
fix(*): use more getter and setter
1 parent 08f4f9f commit f5ba860

File tree

4 files changed

+22
-13
lines changed

4 files changed

+22
-13
lines changed

src/item.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ export abstract class Item {
1919
protected _boards: Array<string>;
2020

2121
public constructor(kwArgs: ItemProperties) {
22-
this._id = kwArgs.id;
23-
this._date = kwArgs.date || now.toDateString();
24-
this._timestamp = kwArgs.timestamp || now.getTime();
25-
this._description = kwArgs.description || '';
26-
this._isStarred = kwArgs.isStarred || false;
27-
this._boards = kwArgs.boards || ['My Board'];
22+
this.id = kwArgs.id;
23+
this.date = kwArgs.date || now.toDateString();
24+
this.timestamp = kwArgs.timestamp || now.getTime();
25+
this.description = kwArgs.description || '';
26+
this.isStarred = kwArgs.isStarred || false;
27+
this.boards = kwArgs.boards || ['My Board'];
2828
}
2929

3030
public get id(): number {

src/note.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ export class Note extends Item {
55

66
public constructor(kwArgs: ItemProperties) {
77
super(kwArgs);
8-
this._isTask = false;
8+
this.isTask = false;
99
}
1010
}

src/task.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ export class Task extends Item {
2424

2525
public constructor(kwArgs: TaskProperties) {
2626
super(kwArgs);
27-
this._isTask = true;
28-
this._priority = kwArgs.priority || TaskPriority.Normal;
29-
this._inProgress = kwArgs.inProgress || false;
30-
this._isCanceled = kwArgs.isCanceled || false;
31-
this._isComplete = kwArgs.isComplete || false;
32-
this._dueDate = kwArgs.dueDate || 0;
27+
this.isTask = true;
28+
this.priority = kwArgs.priority || TaskPriority.Normal;
29+
this.inProgress = kwArgs.inProgress || false;
30+
this.isCanceled = kwArgs.isCanceled || false;
31+
this.isComplete = kwArgs.isComplete || false;
32+
this.dueDate = kwArgs.dueDate || 0;
3333
}
3434

3535
public get priority(): TaskPriority {

test/relativedate.spec.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import { getRelativeHumanizedDate } from '../src/libs/date';
2+
import { Helper } from './helper';
3+
4+
const helper = new Helper();
25

36
describe('Test hummanized date functionality', () => {
7+
48
it('should test in 1 day', () => {
59
const now = new Date('2019-09-14 14:00:00');
610
const humanizedDate = getRelativeHumanizedDate(
@@ -81,4 +85,9 @@ describe('Test hummanized date functionality', () => {
8185
);
8286
expect(humanizedDate).toBe('due in 59 seconds');
8387
});
88+
89+
afterAll(done => {
90+
helper.resetConfig();
91+
done();
92+
});
8493
});

0 commit comments

Comments
 (0)