File tree Expand file tree Collapse file tree 4 files changed +18
-58
lines changed
include/opentelemetry/trace/propagation Expand file tree Collapse file tree 4 files changed +18
-58
lines changed Original file line number Diff line number Diff line change @@ -15,6 +15,20 @@ Increment the:
15
15
16
16
## [ Unreleased]
17
17
18
+ * [ API] Jaeger Propagator should not be deprecated
19
+ [ #3086 ] ( https://github.com/open-telemetry/opentelemetry-cpp/pull/3086 )
20
+
21
+ Important changes:
22
+
23
+ * [ API] Jaeger Propagator should not be deprecated
24
+ [ #3086 ] ( https://github.com/open-telemetry/opentelemetry-cpp/pull/3086 )
25
+
26
+ * Deprecation of the Jaeger propagator, as announced on 2023-01-31
27
+ in version 1.8.2, is now reverted.
28
+ * This deprecation turned out to be not justified,
29
+ as the Jaeger propagator can be used without the (now removed)
30
+ Jaeger exporter.
31
+
18
32
## [ 1.17 2024-10-07]
19
33
20
34
* [ CI] Add a clang-tidy build
Original file line number Diff line number Diff line change 46
46
47
47
## [ opentelemetry-cpp API]
48
48
49
- ### Jaeger propagator
50
-
51
- #### Announcement (Jaeger)
52
-
53
- * Version: 1.8.2
54
- * Date: 2023-01-31
55
- * PR: [ DEPRECATION] Deprecate the Jaeger exporter
56
- [ #1923 ] ( https://github.com/open-telemetry/opentelemetry-cpp/pull/1923 )
57
-
58
- This PR also listed the Jaeger propagator as deprecated.
59
-
60
- #### Motivation (Jaeger)
61
-
62
- The Jaeger Exporter is now (July 2023) removed from the OpenTelemetry specification.
63
-
64
- The Jaeger Propagator remains, because changing propagation is a longer
65
- process compared to changing an export format.
66
-
67
- New deployments however are encouraged to use a W3C compliant propagator,
68
- and avoid the Jaeger propagator, which is now deprecated.
69
-
70
- #### Scope (Jaeger)
71
-
72
- The following are deprecated and planned for removal:
73
-
74
- * the API header ` opentelemetry/trace/propagation/jaeger.h ` , including:
75
- * the C++ class ` JaegerPropagator `
76
-
77
- #### Mitigation (Jaeger)
78
-
79
- Use a W3C compliant propagator instead.
80
-
81
- That is, use class HttpTraceContext and "traceparent" tags.
82
-
83
- Do not use class JaegerPropagator and "uber-trace-id" tags.
84
-
85
- #### Planned removal (Jaeger)
86
-
87
- No date set yet for the Jaeger Propagator.
49
+ N/A
88
50
89
51
## [ opentelemetry-cpp SDK]
90
52
Original file line number Diff line number Diff line change 3
3
4
4
#pragma once
5
5
6
- #ifdef OPENTELEMETRY_NO_DEPRECATED_CODE
7
- # error "header <opentelemetry/trace/propagation/jaeger.h> is deprecated."
8
- #endif
9
-
10
6
#include " detail/hex.h"
11
7
#include " detail/string.h"
12
8
#include " opentelemetry/context/propagation/text_map_propagator.h"
@@ -21,7 +17,7 @@ namespace propagation
21
17
22
18
static const nostd::string_view kJaegerTraceHeader = " uber-trace-id" ;
23
19
24
- class OPENTELEMETRY_DEPRECATED JaegerPropagator : public context::propagation::TextMapPropagator
20
+ class JaegerPropagator : public context ::propagation::TextMapPropagator
25
21
{
26
22
public:
27
23
void Inject (context::propagation::TextMapCarrier &carrier,
Original file line number Diff line number Diff line change 3
3
4
4
add_subdirectory (detail )
5
5
6
- foreach (testname http_text_format_test b3_propagation_test )
6
+ foreach (testname http_text_format_test b3_propagation_test
7
+ jaeger_propagation_test )
7
8
add_executable (${testname} "${testname} .cc" )
8
9
target_link_libraries (${testname} ${GTEST_BOTH_LIBRARIES}
9
10
${CMAKE_THREAD_LIBS_INIT} opentelemetry_api )
@@ -12,16 +13,3 @@ foreach(testname http_text_format_test b3_propagation_test)
12
13
TEST_PREFIX trace.
13
14
TEST_LIST ${testname} )
14
15
endforeach ()
15
-
16
- if (NOT WITH_NO_DEPRECATED_CODE )
17
- foreach (testname jaeger_propagation_test )
18
-
19
- add_executable (${testname} "${testname} .cc" )
20
- target_link_libraries (${testname} ${GTEST_BOTH_LIBRARIES}
21
- ${CMAKE_THREAD_LIBS_INIT} opentelemetry_api )
22
- gtest_add_tests (
23
- TARGET ${testname}
24
- TEST_PREFIX trace.
25
- TEST_LIST ${testname} )
26
- endforeach ()
27
- endif ()
You can’t perform that action at this time.
0 commit comments