K8SPS-126: Support volume expansion (#937)

* K8SPS-126: Support volume expansion

* add pvc-resize e2e test

* fix pvc-resize test

* K8SPS-126 Introduce controller test for pvc resize

* fix formatting

* fix duplicate annotation functions and usage

* fix lint

* remove pxc references

---------

Co-authored-by: George Kechagias <george.kechagias@percona.com>
Co-authored-by: Andrii Dema <a.dema@jazzserve.com>
Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>

Author: 4 people

api/v1alpha1/perconaservermysql_types.go

@@ -57,23 +57,24 @@ const (
 // +kubebuilder:validation:XValidation:rule="!(self.mysql.clusterType == 'group-replication' && has(self.mysql.size) && self.mysql.size >= 9) || self.unsafeFlags.mysqlSize",message="Invalid configuration: For 'group replication', scaling MySQL replicas above 9 requires 'unsafeFlags.mysqlSize: true'"
 // +kubebuilder:validation:XValidation:rule="!(self.mysql.clusterType == 'group-replication' && has(self.mysql.size) && self.mysql.size % 2 == 0) || self.unsafeFlags.mysqlSize",message="Invalid configuration: For 'group replication', using an even number of MySQL replicas requires 'unsafeFlags.mysqlSize: true'"
 type PerconaServerMySQLSpec struct {
-	CRVersion         string                               `json:"crVersion,omitempty"`
-	Pause             bool                                 `json:"pause,omitempty"`
-	SecretsName       string                               `json:"secretsName,omitempty"`
-	SSLSecretName     string                               `json:"sslSecretName,omitempty"`
-	Unsafe            UnsafeFlags                          `json:"unsafeFlags,omitempty"`
-	InitImage         string                               `json:"initImage,omitempty"`
-	IgnoreAnnotations []string                             `json:"ignoreAnnotations,omitempty"`
-	IgnoreLabels      []string                             `json:"ignoreLabels,omitempty"`
-	MySQL             MySQLSpec                            `json:"mysql,omitempty"`
-	Orchestrator      OrchestratorSpec                     `json:"orchestrator,omitempty"`
-	PMM               *PMMSpec                             `json:"pmm,omitempty"`
-	Backup            *BackupSpec                          `json:"backup,omitempty"`
-	Proxy             ProxySpec                            `json:"proxy,omitempty"`
-	TLS               *TLSSpec                             `json:"tls,omitempty"`
-	Toolkit           *ToolkitSpec                         `json:"toolkit,omitempty"`
-	UpgradeOptions    UpgradeOptions                       `json:"upgradeOptions,omitempty"`
-	UpdateStrategy    appsv1.StatefulSetUpdateStrategyType `json:"updateStrategy,omitempty"`
+	CRVersion              string                               `json:"crVersion,omitempty"`
+	Pause                  bool                                 `json:"pause,omitempty"`
+	VolumeExpansionEnabled bool                                 `json:"enableVolumeExpansion,omitempty"`
+	SecretsName            string                               `json:"secretsName,omitempty"`
+	SSLSecretName          string                               `json:"sslSecretName,omitempty"`
+	Unsafe                 UnsafeFlags                          `json:"unsafeFlags,omitempty"`
+	InitImage              string                               `json:"initImage,omitempty"`
+	IgnoreAnnotations      []string                             `json:"ignoreAnnotations,omitempty"`
+	IgnoreLabels           []string                             `json:"ignoreLabels,omitempty"`
+	MySQL                  MySQLSpec                            `json:"mysql,omitempty"`
+	Orchestrator           OrchestratorSpec                     `json:"orchestrator,omitempty"`
+	PMM                    *PMMSpec                             `json:"pmm,omitempty"`
+	Backup                 *BackupSpec                          `json:"backup,omitempty"`
+	Proxy                  ProxySpec                            `json:"proxy,omitempty"`
+	TLS                    *TLSSpec                             `json:"tls,omitempty"`
+	Toolkit                *ToolkitSpec                         `json:"toolkit,omitempty"`
+	UpgradeOptions         UpgradeOptions                       `json:"upgradeOptions,omitempty"`
+	UpdateStrategy         appsv1.StatefulSetUpdateStrategyType `json:"updateStrategy,omitempty"`
 }
 
 type UnsafeFlags struct {
@@ -1114,6 +1115,11 @@ func (cr *PerconaServerMySQL) InnoDBClusterName() string {
 	return NonAlphaNumeric.ReplaceAllString(cr.Name, "")
 }
 
+func (cr *PerconaServerMySQL) PVCResizeInProgress() bool {
+	_, ok := cr.Annotations[string(naming.AnnotationPVCResizeInProgress)]
+	return ok
+}
+
 // Registers PerconaServerMySQL types with the SchemeBuilder.
 func init() {
 	SchemeBuilder.Register(&PerconaServerMySQL{}, &PerconaServerMySQLList{})

cmd/manager/main.go

@@ -17,6 +17,7 @@ limitations under the License.
 package main
 
 import (
+	"context"
 	"flag"
 	"os"
 	"strconv"
@@ -26,12 +27,14 @@ import (
 	"github.com/go-logr/logr"
 	uzap "go.uber.org/zap"
 	"go.uber.org/zap/zapcore"
+	eventsv1 "k8s.io/api/events/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 	clientgoscheme "k8s.io/client-go/kubernetes/scheme"
 	_ "k8s.io/client-go/plugin/pkg/client/auth"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/cache"
+	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/healthz"
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 	metricsServer "sigs.k8s.io/controller-runtime/pkg/metrics/server"
@@ -180,6 +183,20 @@ func main() {
 	}
 	//+kubebuilder:scaffold:builder
 
+	err = mgr.GetFieldIndexer().IndexField(
+		context.Background(),
+		&eventsv1.Event{},
+		"regarding.name",
+		func(rawObj client.Object) []string {
+			event := rawObj.(*eventsv1.Event)
+			return []string{event.Regarding.Name}
+		},
+	)
+	if err != nil {
+		setupLog.Error(err, "unable to index field")
+		os.Exit(1)
+	}
+
 	if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {
 		setupLog.Error(err, "unable to set up health check")
 		os.Exit(1)

config/crd/bases/ps.percona.com_perconaservermysqls.yaml

@@ -2326,6 +2326,8 @@ spec:
                 type: object
               crVersion:
                 type: string
+              enableVolumeExpansion:
+                type: boolean
               ignoreAnnotations:
                 items:
                   type: string

config/rbac/cluster/role.yaml

@@ -23,9 +23,13 @@ rules:
   - ""
   resources:
   - events
+  - serviceaccounts
   verbs:
   - create
+  - get
+  - list
   - patch
+  - watch
 - apiGroups:
   - ""
   resources:
@@ -40,16 +44,6 @@ rules:
   - patch
   - update
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - serviceaccounts
-  verbs:
-  - create
-  - get
-  - list
-  - patch
-  - watch
 - apiGroups:
   - apps
   resources:
@@ -90,6 +84,16 @@ rules:
   - patch
   - update
   - watch
+- apiGroups:
+  - events.k8s.io
+  resources:
+  - events
+  verbs:
+  - create
+  - get
+  - list
+  - patch
+  - watch
 - apiGroups:
   - ps.percona.com
   resources:

config/rbac/role.yaml

@@ -23,9 +23,13 @@ rules:
   - ""
   resources:
   - events
+  - serviceaccounts
   verbs:
   - create
+  - get
+  - list
   - patch
+  - watch
 - apiGroups:
   - ""
   resources:
@@ -40,16 +44,6 @@ rules:
   - patch
   - update
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - serviceaccounts
-  verbs:
-  - create
-  - get
-  - list
-  - patch
-  - watch
 - apiGroups:
   - apps
   resources:
@@ -90,6 +84,16 @@ rules:
   - patch
   - update
   - watch
+- apiGroups:
+  - events.k8s.io
+  resources:
+  - events
+  verbs:
+  - create
+  - get
+  - list
+  - patch
+  - watch
 - apiGroups:
   - ps.percona.com
   resources:

deploy/bundle.yaml

@@ -4249,6 +4249,8 @@ spec:
                 type: object
               crVersion:
                 type: string
+              enableVolumeExpansion:
+                type: boolean
               ignoreAnnotations:
                 items:
                   type: string
@@ -11520,9 +11522,13 @@ rules:
   - ""
   resources:
   - events
+  - serviceaccounts
   verbs:
   - create
+  - get
+  - list
   - patch
+  - watch
 - apiGroups:
   - ""
   resources:
@@ -11537,16 +11543,6 @@ rules:
   - patch
   - update
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - serviceaccounts
-  verbs:
-  - create
-  - get
-  - list
-  - patch
-  - watch
 - apiGroups:
   - apps
   resources:
@@ -11587,6 +11583,16 @@ rules:
   - patch
   - update
   - watch
+- apiGroups:
+  - events.k8s.io
+  resources:
+  - events
+  verbs:
+  - create
+  - get
+  - list
+  - patch
+  - watch
 - apiGroups:
   - ps.percona.com
   resources:

deploy/crd.yaml

@@ -4249,6 +4249,8 @@ spec:
                 type: object
               crVersion:
                 type: string
+              enableVolumeExpansion:
+                type: boolean
               ignoreAnnotations:
                 items:
                   type: string

deploy/cw-bundle.yaml

@@ -4249,6 +4249,8 @@ spec:
                 type: object
               crVersion:
                 type: string
+              enableVolumeExpansion:
+                type: boolean
               ignoreAnnotations:
                 items:
                   type: string
@@ -11520,9 +11522,13 @@ rules:
   - ""
   resources:
   - events
+  - serviceaccounts
   verbs:
   - create
+  - get
+  - list
   - patch
+  - watch
 - apiGroups:
   - ""
   resources:
@@ -11537,16 +11543,6 @@ rules:
   - patch
   - update
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - serviceaccounts
-  verbs:
-  - create
-  - get
-  - list
-  - patch
-  - watch
 - apiGroups:
   - apps
   resources:
@@ -11587,6 +11583,16 @@ rules:
   - patch
   - update
   - watch
+- apiGroups:
+  - events.k8s.io
+  resources:
+  - events
+  verbs:
+  - create
+  - get
+  - list
+  - patch
+  - watch
 - apiGroups:
   - ps.percona.com
   resources:

deploy/cw-rbac.yaml

@@ -64,9 +64,13 @@ rules:
   - ""
   resources:
   - events
+  - serviceaccounts
   verbs:
   - create
+  - get
+  - list
   - patch
+  - watch
 - apiGroups:
   - ""
   resources:
@@ -81,16 +85,6 @@ rules:
   - patch
   - update
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - serviceaccounts
-  verbs:
-  - create
-  - get
-  - list
-  - patch
-  - watch
 - apiGroups:
   - apps
   resources:
@@ -131,6 +125,16 @@ rules:
   - patch
   - update
   - watch
+- apiGroups:
+  - events.k8s.io
+  resources:
+  - events
+  verbs:
+  - create
+  - get
+  - list
+  - patch
+  - watch
 - apiGroups:
   - ps.percona.com
   resources: