K8SPSMDB-1055: return ErrNoOplogsForPITR on empty oplog.Timeline (#1502)

pooknull · hors · web-flow · commit 8536422f9a04 · 2024-04-08T20:08:22.000+03:00
https://perconadev.atlassian.net/browse/K8SPSMDB-1055 Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>
diff --git a/pkg/psmdb/backup/pbm.go b/pkg/psmdb/backup/pbm.go
@@ -462,7 +462,12 @@ func (b *pbmC) GetLatestTimelinePITR(ctx context.Context) (oplog.Timeline, error
 		return oplog.Timeline{}, ErrNoOplogsForPITR
 	}
 
-	return timelines[len(timelines)-1], nil
+	tl := timelines[len(timelines)-1]
+	if tl.Start == 0 || tl.End == 0 {
+		return oplog.Timeline{}, ErrNoOplogsForPITR
+	}
+
+	return tl, nil
 }
 
 // PITRGetChunkContains returns a pitr slice chunk that belongs to the

Original file line number	Diff line number	Diff line change
`@@ -462,7 +462,12 @@ func (b *pbmC) GetLatestTimelinePITR(ctx context.Context) (oplog.Timeline, error`
`462`	`462`	`return oplog.Timeline{}, ErrNoOplogsForPITR`
`463`	`463`	`}`
`464`	`464`
`465`		`- return timelines[len(timelines)-1], nil`
	`465`	`+ tl := timelines[len(timelines)-1]`
	`466`	`+ if tl.Start == 0 \|\| tl.End == 0 {`
	`467`	`+ return oplog.Timeline{}, ErrNoOplogsForPITR`
	`468`	`+ }`
	`469`	`+`
	`470`	`+ return tl, nil`
`466`	`471`	`}`
`467`	`472`
`468`	`473`	`// PITRGetChunkContains returns a pitr slice chunk that belongs to the`