K8SPSMDB-1070: Fix panic in delete-psmdb-pods-in-order finalizer (#1525)

* K8SPSMDB-1070: Fix panic in delete-psmdb-pods-in-order finalizer

* fix cw-bundle.yaml

* fix pause

---------

Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>

Author: egegunes

deploy/cw-bundle.yaml

@@ -18300,7 +18300,7 @@ spec:
       serviceAccountName: percona-server-mongodb-operator
       containers:
         - name: percona-server-mongodb-operator
-          image: perconalab/percona-server-mongodb-operator:k8spsmdb-755
+          image: perconalab/percona-server-mongodb-operator:main
           imagePullPolicy: Always
           livenessProbe:
             failureThreshold: 3

pkg/controller/perconaservermongodb/finalizers.go

@@ -87,16 +87,14 @@ func (r *ReconcilePerconaServerMongoDB) deletePSMDBPods(ctx context.Context, cr
 	replsetsDeleted := true
 	for _, rs := range cr.Spec.Replsets {
 		if err := r.deleteRSPods(ctx, cr, rs); err != nil {
-			if err != nil {
-				switch err {
-				case errWaitingTermination, errWaitingFirstPrimary:
-					log.Info(err.Error(), "rs", rs.Name)
-				default:
-					log.Error(err, "failed to delete rs pods", "rs", rs.Name)
-				}
-				replsetsDeleted = false
-				continue
+			switch err {
+			case errWaitingTermination, errWaitingFirstPrimary:
+				log.Info(err.Error(), "rs", rs.Name)
+			default:
+				log.Error(err, "failed to delete rs pods", "rs", rs.Name)
 			}
+			replsetsDeleted = false
+			continue
 		}
 	}
 	if !replsetsDeleted {

pkg/controller/perconaservermongodb/statefulset.go

@@ -13,7 +13,6 @@ import (
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
 )
 
-// TODO: reduce cyclomatic complexity
 func (r *ReconcilePerconaServerMongoDB) reconcileStatefulSet(ctx context.Context, cr *api.PerconaServerMongoDB, rs *api.ReplsetSpec, ls map[string]string) (*appsv1.StatefulSet, error) {
 	log := logf.FromContext(ctx)