Support proxy settings with user and password #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active Merchantにはプロキシ設定がありますが、ユーザーとパスワードを渡すことができません。そのため、Active Merchantはユーザー名・パスワードによる認証が必要なプロキシを利用できませんでした。
そこで以下のPull Requestにて、
ActiveMerchant::Connectionのattr_accessorとして:proxy_user/:proxy_passwordを渡せるようにしました。activemerchant/active_merchant#5102
この
:proxy_user/:proxy_passwordをactive_merchant-epsilonから利用できるようにします。以下のように設定できるようになります。activemerchant/active_merchant#5102 はマージはされましたがまだリリースされておらず、このPull Requestのマージタイミングについては相談したいです。
Active Merchant has proxy settings, but is unable to pass a user and password. Therefore, Active Merchant could not use authenticated proxies.
Therefore, the following Pull Request allows
:proxy_user/:proxy_passwordto be passed asattr_accessorofActiveMerchant::Connection.activemerchant/active_merchant#5102
Make this
:proxy_user/:proxy_passwordavailable to active_merchant-epsilon.activemerchant/active_merchant#5102 has been merged but not yet released, and we would like to discuss the merge timing of this Pull Request.