Support 3D Secure parameters for link type payments

Author: hrysd

lib/active_merchant/billing/gateways/epsilon.rb

@@ -22,20 +22,6 @@ module CreditType
         capture:                 'sales_payment.cgi',
       }.freeze
 
-      RISK_BASE_AUTH_PARAMS_KEYS = %i[
-        tds_flag billAddrCity billAddrCountry billAddrLine1 billAddrLine2 billAddrLine3
-        billAddrPostCode billAddrState shipAddrCity shipAddrCountry shipAddrLine1 shipAddrLine2
-        shipAddrLine3 shipAddrPostCode shipAddrState chAccAgeInd chAccChange
-        chAccChangeIndchAccDate chAccPwdChange chAccPwChangeInd nbPurchaseAccount paymentAccAge
-        paymentAccInd provisionAttemptsDay shipAddressUsage shipAddressUsageInd shipNameIndicator
-        suspiciousAccActivity txnActivityDay txnActivityYear threeDSReqAuthData threeDSReqAuthMethod
-        threeDSReqAuthTimestamp addrMatch cardholderName homePhone mobilePhone
-        workPhone challengeInd deliveryEmailAddress deliveryTimeframe giftCardAmount
-        giftCardCount preOrderDate preOrderPurchaseInd reorderItemsInd shipIndicator
-      ].freeze
-
-      THREE_D_SECURE_2_INDICATORS = [21, 22].freeze
-
       self.supported_cardtypes = [:visa, :master, :american_express, :discover]
 
       def purchase(amount, credit_card, detail = {})
@@ -44,7 +30,7 @@ def purchase(amount, credit_card, detail = {})
         params = billing_params(amount, credit_card, detail)
 
         if three_d_secure_2?(detail)
-          params.merge!(detail.slice(*RISK_BASE_AUTH_PARAMS_KEYS).compact)
+          params.merge!(detail.slice(*EpsilonRiskBaseAuthParams::KEYS).compact)
         end
 
         commit(PATHS[:purchase], params)
@@ -73,7 +59,7 @@ def registered_purchase(amount, detail = {})
         params[:kari_flag] = detail[:capture] ? 2 : 1 if detail.has_key?(:capture)
 
         if three_d_secure_2?(detail)
-          params.merge!(detail.slice(*RISK_BASE_AUTH_PARAMS_KEYS).compact)
+          params.merge!(detail.slice(*EpsilonRiskBaseAuthParams::KEYS).compact)
         end
 
         commit(PATHS[:registered_purchase], params)
@@ -263,7 +249,7 @@ def billing_params(amount, payment_method, detail)
       end
 
       def three_d_secure_2?(detail)
-        THREE_D_SECURE_2_INDICATORS.include?(detail[:tds_flag])
+        EpsilonRiskBaseAuthParams.three_d_secure_2?(detail[:tds_flag])
       end
     end
   end

lib/active_merchant/billing/gateways/epsilon/epsilon_risk_base_auth_params.rb

@@ -0,0 +1,25 @@
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    module EpsilonRiskBaseAuthParams
+      KEYS = %i[
+        tds_flag billAddrCity billAddrCountry billAddrLine1 billAddrLine2 billAddrLine3
+        billAddrPostCode billAddrState shipAddrCity shipAddrCountry shipAddrLine1 shipAddrLine2
+        shipAddrLine3 shipAddrPostCode shipAddrState chAccAgeInd chAccChange
+        chAccChangeIndchAccDate chAccPwdChange chAccPwChangeInd nbPurchaseAccount paymentAccAge
+        paymentAccInd provisionAttemptsDay shipAddressUsage shipAddressUsageInd shipNameIndicator
+        suspiciousAccActivity txnActivityDay txnActivityYear threeDSReqAuthData threeDSReqAuthMethod
+        threeDSReqAuthTimestamp addrMatch cardholderName homePhone mobilePhone
+        workPhone challengeInd deliveryEmailAddress deliveryTimeframe giftCardAmount
+        giftCardCount preOrderDate preOrderPurchaseInd reorderItemsInd shipIndicator
+      ].freeze
+
+      THREE_D_SECURE_2_INDICATORS = [21, 22].freeze
+
+      def three_d_secure_2?(tds_flag)
+        THREE_D_SECURE_2_INDICATORS.include?(tds_flag)
+      end
+
+      module_function :three_d_secure_2?
+    end
+  end
+end

lib/active_merchant/billing/gateways/epsilon_link_payment.rb

@@ -39,6 +39,10 @@ def purchase(amount, detail = {}, delivery_info_required = true)
         params[:memo2] = detail[:memo2] if detail.has_key?(:memo2)
         params[:user_tel] = detail[:user_tel] if detail.has_key?(:user_tel)
 
+        if three_d_secure_2?(detail)
+          params.merge!(detail.slice(*EpsilonRiskBaseAuthParams::KEYS).compact)
+        end
+
         commit('receive_order3.cgi', params, RESPONSE_KEYS)
       end
 
@@ -50,6 +54,12 @@ def void(order_number)
 
         commit('cancel_payment.cgi', params)
       end
+
+      private
+
+      def three_d_secure_2?(detail)
+        EpsilonRiskBaseAuthParams.three_d_secure_2?(detail[:tds_flag])
+      end
     end
   end
 end

lib/active_merchant/epsilon.rb

@@ -5,6 +5,7 @@
 require_relative 'billing/convenience_store'
 require_relative 'billing/gateways/epsilon/epsilon_mission_code'
 require_relative 'billing/gateways/epsilon/epsilon_process_code'
+require_relative 'billing/gateways/epsilon/epsilon_risk_base_auth_params'
 require_relative 'billing/gateways/epsilon/epsilon_base'
 require_relative 'billing/gateways/epsilon'
 require_relative 'billing/gateways/epsilon_convenience_store'

test/fixtures/vcr_cassettes/epsilon_link_type_with_3d_secure.yml

@@ -33,6 +33,16 @@ def test_epsilon_link_type_purchase_fail
     end
   end
 
+  def test_epsilon_link_type_with_3d_secure
+    ActiveMerchant::Billing::Base.stub(:mode, :production) do
+      VCR.use_cassette(:epsilon_link_type_with_3d_secure) do
+        response = gateway.purchase(10000, valid_epsilon_link_type_purchase_detail_for_3d_secure, false)
+
+        pp response
+      end
+    end
+  end
+
   def test_epsilon_link_type_void_successfull
     VCR.use_cassette(:epsilon_link_type_void_successfull) do
       # あらかじめ課金済ステータスの受注がイプシロン側にないと取り消しができないため、課金済の受注をイプシロン側で作成しておいた。

test/remote/gateways/remote_epsilon_link_payment_test.rb

@@ -295,6 +295,22 @@ def valid_epsilon_link_type_not_sending_delivery_information_purchase_detail
     }
   end
 
+  def valid_epsilon_link_type_purchase_detail_for_3d_secure
+    now = Time.now
+    {
+      user_id:      "U#{Time.now.to_i}",
+      user_name:    '山田 太郎',
+      user_email:   'yamada-taro@example.com',
+      item_code:    'ITEM001',
+      item_name:    'Greate Product',
+      order_number: "O#{now.sec}#{now.usec}",
+      st_code:      '10000-0000-00000-00000-00000-00000-00000',
+      memo1:        'memo1',
+      memo2:        'memo2',
+      tds_flag:     21
+    }
+  end
+
   def invalid_epsilon_link_type_purchase_detail
     now = Time.now
     {