Use Generic Overloads in VB Code and minor cleanup (dotnet#12615)

* Use Generic Overloads in VB Code

* Add missing test to improve coverage

* Simplify some paths that can now be shortened due to changes in Global Imports

Author: paul1956

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/ConsoleApplicationBase.vb

@@ -43,7 +43,7 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         '''  Returns the command line arguments for the current application.
         ''' </summary>
         ''' <remarks>
-        '''  This function differs from <see cref="System.Environment.GetCommandLineArgs"/>
+        '''  This function differs from <see cref="Environment.GetCommandLineArgs"/>
         '''  in that the path of the executing file (the 0th entry) is omitted from
         '''  the returned collection
         ''' </remarks>

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/Audio.vb

@@ -55,7 +55,7 @@ Namespace Microsoft.VisualBasic.Devices
         Private Sub Play(sound As Media.SoundPlayer, mode As AudioPlayMode)
 
             Debug.Assert(sound IsNot Nothing, "There's no SoundPlayer")
-            Debug.Assert([Enum].IsDefined(GetType(AudioPlayMode), mode), "Enum value is out of range")
+            Debug.Assert([Enum].IsDefined(mode), "Enum value is out of range")
 
             ' Stopping the sound ensures it's safe to dispose it. This could happen when we change the value of _Sound below
             _sound?.Stop()

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/ComputerInfo.InternalMemoryStatus.vb

@@ -11,7 +11,7 @@ Namespace Microsoft.VisualBasic.Devices
         '''  Calls GlobalMemoryStatusEx and returns the correct value.
         ''' </summary>
         Private NotInheritable Class InternalMemoryStatus
-            Private _memoryStatusEx As NativeMethods.MEMORYSTATUSEX
+            Private _memoryStatusEx As MEMORYSTATUSEX
 
             Friend Sub New()
             End Sub
@@ -49,7 +49,7 @@ Namespace Microsoft.VisualBasic.Devices
 #Enable Warning IDE0049
 
             Private Sub Refresh()
-                _memoryStatusEx = New NativeMethods.MEMORYSTATUSEX
+                _memoryStatusEx = New MEMORYSTATUSEX
                 _memoryStatusEx.Init()
                 If Not NativeMethods.GlobalMemoryStatusEx(_memoryStatusEx) Then
                     Throw ExceptionUtils.GetWin32Exception(SR.DiagnosticInfo_Memory)

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Helpers/FileSystemUtils.vb

@@ -32,7 +32,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 
                 ' DirectoryInfo.GetFiles and GetDirectories call FindFirstFile which resolves 8.3 path.
                 ' Get the DirectoryInfo (user must have code permission or access permission).
-                Dim dInfo As New IO.DirectoryInfo(FileIO.FileSystem.GetParentPath(fullPath))
+                Dim dInfo As New DirectoryInfo(FileIO.FileSystem.GetParentPath(fullPath))
 
                 If IO.File.Exists(fullPath) Then
                     Debug.Assert(dInfo.GetFiles(IO.Path.GetFileName(fullPath)).Length = 1, "Must found exactly 1")
@@ -50,15 +50,15 @@ Namespace Microsoft.VisualBasic.CompilerServices
                 ' or indicate that caller does not have enough permission and should get back the 8.3 path.
                 If TypeOf ex Is ArgumentException OrElse
                     TypeOf ex Is ArgumentNullException OrElse
-                    TypeOf ex Is IO.PathTooLongException OrElse
+                    TypeOf ex Is PathTooLongException OrElse
                     TypeOf ex Is NotSupportedException OrElse
-                    TypeOf ex Is IO.DirectoryNotFoundException OrElse
+                    TypeOf ex Is DirectoryNotFoundException OrElse
                     TypeOf ex Is SecurityException OrElse
                     TypeOf ex Is UnauthorizedAccessException Then
 
                     Debug.Assert(Not (TypeOf ex Is ArgumentException OrElse
                         TypeOf ex Is ArgumentNullException OrElse
-                        TypeOf ex Is IO.PathTooLongException OrElse
+                        TypeOf ex Is PathTooLongException OrElse
                         TypeOf ex Is NotSupportedException), "These exceptions should be caught above")
 
                     Return fullPath
@@ -149,8 +149,8 @@ Namespace Microsoft.VisualBasic.CompilerServices
         ''' </summary>
         ''' <param name="path">The path to be normalized.</param>
         ''' <returns>The normalized path.</returns>
-        ''' <exception cref="IO.Path.GetFullPath">
-        '''  <see cref="IO.Path.GetFullPath"/> for possible exceptions.
+        ''' <exception cref="Path.GetFullPath">
+        '''  <see cref="Path.GetFullPath"/> for possible exceptions.
         ''' </exception>
         ''' <remarks>
         '''  Keep this function since we might change the implementation / behavior later.

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Helpers/NativeMethods.vb

@@ -127,7 +127,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 #Enable Warning IDE1006
 
             Friend Sub Init()
-                dwLength = CType(Marshal.SizeOf(GetType(MEMORYSTATUSEX)), UInt32)
+                dwLength = CType(Marshal.SizeOf(Of MEMORYSTATUSEX)(), UInt32)
             End Sub
 
         End Structure

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Helpers/NativeTypes.SECURITY_ATTRIBUTES.vb

@@ -14,7 +14,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
             Implements IDisposable
 
             Friend Sub New()
-                nLength = Marshal.SizeOf(GetType(SECURITY_ATTRIBUTES))
+                nLength = Marshal.SizeOf(Of SECURITY_ATTRIBUTES)()
             End Sub
 
             Public nLength As Integer

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Logging/FileLogTraceListener.vb

@@ -878,7 +878,7 @@ Namespace Microsoft.VisualBasic.Logging
             outBuilder.Append($"{source}{Delimiter}")
 
             ' eventType
-            outBuilder.Append($"{[Enum].GetName(GetType(TraceEventType), eventType)}{Delimiter}")
+            outBuilder.Append($"{[Enum].GetName(eventType)}{Delimiter}")
 
             ' id
             outBuilder.Append(FormattableString.Invariant($"{id}{Delimiter}"))

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb

@@ -653,7 +653,7 @@ Namespace Microsoft.VisualBasic.MyServices
         ''' </param>
         ''' <param name="fileWildcards">The search patterns to use for the file name ("*.*")</param>
         ''' <returns>A string array containing the files that match the search condition.</returns>
-        ''' <exception cref="System.ArgumentNullException">
+        ''' <exception cref="ArgumentNullException">
         '''  <paramref name="directory"/> is Nothing or an empty string.
         ''' </exception>
         ''' <exception cref="ArgumentException">

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/Internal/ProgressDialog.vb

@@ -29,7 +29,7 @@ Namespace Microsoft.VisualBasic.MyServices.Internal
         Private Const WS_THICKFRAME As Integer = &H40000
 
         'Required by the Windows Form Designer
-        Private ReadOnly _components As System.ComponentModel.IContainer
+        Private ReadOnly _components As IContainer
 
         ' Indicates whether or not the user has canceled the copy
         Private _canceled As Boolean
@@ -121,7 +121,7 @@ Namespace Microsoft.VisualBasic.MyServices.Internal
         'Do not modify it using the code editor.
         <DebuggerStepThrough()>
         Private Sub InitializeComponent()
-            Dim resources As New System.ComponentModel.ComponentResourceManager(GetType(ProgressDialog))
+            Dim resources As New ComponentResourceManager(GetType(ProgressDialog))
             LabelInfo = New Label
             ProgressBarWork = New ProgressBar
             ButtonCloseDialog = New Button

src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/SecurityAttributesTests.vb

@@ -13,7 +13,7 @@ Namespace Microsoft.VisualBasic.Forms.Tests
         <WinFormsFact>
         Public Sub SECURITY_ATTRIBUTES_New_Success()
             Using securityAttributes As New SECURITY_ATTRIBUTES
-                securityAttributes.nLength.Should.Be(Marshal.SizeOf(GetType(SECURITY_ATTRIBUTES)))
+                securityAttributes.nLength.Should.Be(Marshal.SizeOf(Of SECURITY_ATTRIBUTES)())
             End Using
         End Sub