File tree Expand file tree Collapse file tree 3 files changed +30
-4
lines changed Expand file tree Collapse file tree 3 files changed +30
-4
lines changed Original file line number Diff line number Diff line change 11# QOwnNotes Changelog
22
3+ ## 25.6.2
4+ 
5+ - The _Find action_ dialog is now working again
6+   (for [#3294](https://github.com/pbek/QOwnNotes/issues/3294))
7+ 
38## 25.6.1
49
510- A segmentation fault when quitting the application on ARM macOS was fixed
Original file line number Diff line number Diff line change @@ -462,6 +462,7 @@ MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent) {
462462        QString::number (schemaCount) + QStringLiteral ("  schemas" 
463463
464464    _actionDialog = nullptr ;
465+     _commandBar = nullptr ;
465466    _todoDialog = nullptr ;
466467    _storedImagesDialog = nullptr ;
467468    _storedAttachmentsDialog = nullptr ;
@@ -10983,10 +10984,29 @@ void MainWindow::on_actionFind_action_triggered() {
1098310984        }
1098410985    }
1098510986
10986-     CommandBar commandBar (this );
10987-     commandBar.updateBar (actions);
10988-     commandBar.setFocus ();
10989-     commandBar.exec ();
10987+     if  (_commandBar != nullptr ) {
10988+         delete  _commandBar;
10989+     }
10990+ 
10991+     //  We need to instantiate the class every time, otherwise no and then it's not drawn correctly
10992+     _commandBar = new  CommandBar (this );
10993+ 
10994+     _commandBar->updateBar (actions);
10995+     _commandBar->setFocus ();
10996+ 
10997+     //  Keep in mind this call is not synchronous anymore for some reason, so we can't delete the
10998+     //  instance
10999+     _commandBar->exec ();
11000+ 
11001+     //     QPointer<CommandBar> commandBar = new CommandBar(this);
11002+     // 
11003+     //     commandBar->updateBar(actions);
11004+     //     commandBar->setFocus();
11005+     //     QAction *action = commandBar->exec();
11006+     // 
11007+     //     delete commandBar;
11008+     // 
11009+     //     qDebug() << __func__ << " - 'action': " << action;
1099011010}
1099111011
1099211012/* *
Original file line number Diff line number Diff line change @@ -841,6 +841,7 @@ class MainWindow : public QMainWindow {
841841    bool  _noteSubFolderDockWidgetVisible;
842842    bool  _closeEventWasFired;
843843    ActionDialog *_actionDialog;
844+     CommandBar *_commandBar;
844845    TodoDialog *_todoDialog;
845846    IssueAssistantDialog *_issueAssistantDialog;
846847    StoredImagesDialog *_storedImagesDialog;
 
 
   
 
     
   
   
          
    
    
     
    
      
     
     
    You can’t perform that action at this time.
  
 
    
  
    
      
        
     
       
      
     
   
 
    
    
  
 
  
 
     
    
0 commit comments